From: Jens Axboe <axboe@kernel.dk>
To: Lauri Kasanen <cand@gmx.com>
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
linux-block@vger.kernel.org
Subject: Re: [PATCH 6/6] block: Add n64 cart driver
Date: Mon, 4 Jan 2021 08:49:55 -0700 [thread overview]
Message-ID: <db1936b0-a1ab-41b3-be09-ec301ea7ebc3@kernel.dk> (raw)
In-Reply-To: <20210104174348.cda010a3af0ec3d989732b37@gmx.com>
On 1/4/21 8:43 AM, Lauri Kasanen wrote:
> On Mon, 4 Jan 2021 08:40:10 -0700
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> On 1/4/21 6:50 AM, Lauri Kasanen wrote:
>>> Signed-off-by: Lauri Kasanen <cand@gmx.com>
>>> ---
>>> drivers/block/Kconfig | 6 ++
>>> drivers/block/Makefile | 1 +
>>> drivers/block/n64cart.c | 203 ++++++++++++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 210 insertions(+)
>>> create mode 100644 drivers/block/n64cart.c
>>>
>>> block folks: rest of the series is on linux-mips. Being a
>>> mips-specific driver, not sure which tree it should go to.
>>
>> It should definitely get reviewed first. One easy question - there's no
>> commit message in this one. It's a new driver, it should include some
>> documentation on what it is, etc.
>
> It's already had one (rfc) round on linux-mips. Or do you mean by
> others (who?)
I mean the actual block driver from the block point of view. From
a quick look, looks like there's no irq or anything, so it's
strictly polled mode? Probably would make sense to push this out
of the app path then, by using BLK_MQ_F_BLOCKING.
--
Jens Axboe
next prev parent reply other threads:[~2021-01-04 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 13:50 [PATCH 6/6] block: Add n64 cart driver Lauri Kasanen
2021-01-04 15:40 ` Jens Axboe
2021-01-04 15:43 ` Lauri Kasanen
2021-01-04 15:49 ` Jens Axboe [this message]
2021-01-04 15:56 ` Lauri Kasanen
2021-01-04 16:07 ` Jens Axboe
2021-01-04 15:49 ` Keith Busch
2021-01-04 16:01 ` Lauri Kasanen
2021-01-04 16:13 ` Keith Busch
2021-01-04 16:27 ` Lauri Kasanen
2021-01-04 16:28 ` Jens Axboe
2021-01-04 16:42 ` Lauri Kasanen
-- strict thread matches above, loose matches on Subject: below --
2020-12-25 17:01 Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db1936b0-a1ab-41b3-be09-ec301ea7ebc3@kernel.dk \
--to=axboe@kernel.dk \
--cc=cand@gmx.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox