From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>, Conor Dooley <conor@kernel.org>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: dma: Add Loongson-1 DMA
Date: Sun, 8 Oct 2023 13:15:09 +0200 [thread overview]
Message-ID: <dcd1a84c-3fd1-4e46-965d-dd1ca4cb299a@linaro.org> (raw)
In-Reply-To: <CAJhJPsVT371gPN++UNK-cggb8uVxWqpJAoEbFGV8+syxfvnGAQ@mail.gmail.com>
On 07/10/2023 07:45, Keguang Zhang wrote:
>
>>> + Loongson-1 DMA controller provides 3 independent channels for
>>> + peripherals such as NAND and AC97.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - loongson,ls1b-dma
>>> + - loongson,ls1c-dma
>>
>> From a skim of the driver, these two devices seem to be compatible,
>> and therefore one should fall back to the other.
>>
> Got it. How about changing to one const?
> compatible:
> const: loongson,ls1-dma
No, because there is no fallback here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-08 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 12:19 [PATCH v5 0/2] Add Loongson1 dmaengine driver Keguang Zhang
2023-09-28 12:19 ` [PATCH v5 1/2] dt-bindings: dma: Add Loongson-1 DMA Keguang Zhang
2023-09-28 16:42 ` Conor Dooley
2023-10-07 5:45 ` Keguang Zhang
2023-10-07 10:34 ` Conor Dooley
2023-10-08 11:15 ` Krzysztof Kozlowski [this message]
2023-09-28 12:19 ` [PATCH v5 2/2] dmaengine: Loongson1: Add Loongson1 dmaengine driver Keguang Zhang
2023-09-28 12:46 ` Eric Schwarz
2023-10-04 7:43 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd1a84c-3fd1-4e46-965d-dd1ca4cb299a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).