From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28555C433FE for ; Thu, 3 Nov 2022 07:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230527AbiKCHZp (ORCPT ); Thu, 3 Nov 2022 03:25:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbiKCHZo (ORCPT ); Thu, 3 Nov 2022 03:25:44 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F872DDD for ; Thu, 3 Nov 2022 00:25:43 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id k8so1356723wrh.1 for ; Thu, 03 Nov 2022 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=KBb4CRffvbqT8vCYmIjrzMCnn1vGDH3hTE8kztkuirWCWDx5vmnnhlY12+76G8HB+D zNMscqf1aWjU1jn9Q/+2qznV1nyjnfJgJejU0eBLDst+wEJ5JP32F9KCikAYwccYRz/4 CEoS+rbiQf+EK76mQ+O07yD4/kZHVOkQQ4sHVGI67dP7iLfCkYZsRk0ZykZuinHxGqnw VBepbg5NHi4yk+ONf1CC+WSt8MwwyKu83Az0OvU8HlQtsrRUhgNXczuxh+p9v62b1ye5 0/LNF3gKJJGGBQ4GVZwf3fHBWg9tW8pDxWcOYgxGkG6PYQEim2NR9gsO5CmPy3fAtv6n sc3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EDXCjZngZdqFd0T8UNtaJgIVNUXtxy5kh+IvZcYgc3o=; b=t4GCdmyrG/sOfFqg2GfD2WNgtfq7YvgcWuXK5aaKS2CgYIPV+OJth9nIQYWz3OHMBJ MLAnyaj+pIvqd7fcQjevUGkI9HSn0uhKlZne5NhVs7QqR2WM3+GVeC+JiKkusJPFfB/I S9UJRpGnlTAidN/q+6lWpjKvRu2697+042DhA9p1VQbZ/9k5ILfIgG4AyiThKI/XPKS2 F+uHqskuUnpVt2MLf599oMoRzaFScxdFV764FYZj5vKNwjC1aQpiAZSukwc5etWxt5E1 KL0vuz1xOlk222zmJNpG6zasRtK0IrnnncxrtHM4v6V/j/+HHGKGJxXvtBloiA3hOd4g 8jKg== X-Gm-Message-State: ACrzQf25/NvSgWvbVz/RpzQm/DLZe9wE6eg7ABLNLYGG+I+Udk1kNY3S HXPvjBTiIiaBXOFSjwSywtJx/A== X-Google-Smtp-Source: AMsMyM74HX/NoI0zgj7ni+fuzXHxAnM/kiJpMAz2sP8bktGhOQR4suw74I3bBM5aFs9fFpQjlVL3zA== X-Received: by 2002:a5d:50ca:0:b0:236:776c:3075 with SMTP id f10-20020a5d50ca000000b00236776c3075mr17956880wrt.656.1667460341889; Thu, 03 Nov 2022 00:25:41 -0700 (PDT) Received: from [192.168.11.175] (216.red-88-29-181.dynamicip.rima-tde.net. [88.29.181.216]) by smtp.gmail.com with ESMTPSA id i10-20020a1c540a000000b003a3442f1229sm4408723wmb.29.2022.11.03.00.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 00:25:40 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:25:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init() Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Matthew Rosato , Eric Farman , Vitaly Kuznetsov Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Fabiano Rosas , Michael Ellerman , Chao Gao , Thomas Gleixner , Yuan Yao References: <20221102231911.3107438-1-seanjc@google.com> <20221102231911.3107438-18-seanjc@google.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20221102231911.3107438-18-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: > Move arm/arch specific initialization directly in arm's module_init(), > now called kvm_arm_init(), instead of bouncing through kvm_init() to > reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action > performed by kvm_init(), i.e. this is a glorified nop. > > Making kvm_arch_init() a nop will allow dropping it entirely once all > other architectures follow suit. > > No functional change intended. > > Signed-off-by: Sean Christopherson > --- > arch/arm64/kvm/arm.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > /* NOP: Compiling as a module not supported */ > void kvm_arch_exit(void) > { > - kvm_unregister_perf_callbacks(); Doesn't this belong to the previous patch? > + > }