From: Thor Thayer <thor.thayer@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>, linux-edac <linux-edac@vger.kernel.org>
Cc: "Mark Gross" <mark.gross@intel.com>,
"Robert Richter" <rric@kernel.org>,
"Tim Small" <tim@buttersideup.com>,
"Ranganathan Desikan" <ravi@jetztechnologies.com>,
"Arvind R." <arvino55@gmail.com>,
"Jason Baron" <jbaron@akamai.com>,
"Tony Luck" <tony.luck@intel.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"David Daney" <david.daney@cavium.com>, "Loc Ho" <lho@apm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] EDAC: Get rid of mci->mod_ver
Date: Thu, 29 Jun 2017 08:57:57 -0500 [thread overview]
Message-ID: <deade91d-7326-8a39-3881-50db582c3098@linux.intel.com> (raw)
In-Reply-To: <20170629100311.vmdq6fojpo5ye4ne@pd.tnic>
On 06/29/2017 05:03 AM, Borislav Petkov wrote:
> Hi,
>
> any objections?
>
> ---
> It is a write-only variable so get rid of it.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Thor Thayer <thor.thayer@linux.intel.com>
> Cc: Mark Gross <mark.gross@intel.com>
> Cc: Robert Richter <rric@kernel.org>
> Cc: Tim Small <tim@buttersideup.com>
> Cc: Ranganathan Desikan <ravi@jetztechnologies.com>
> Cc: "Arvind R." <arvino55@gmail.com>
> Cc: Jason Baron <jbaron@akamai.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: David Daney <david.daney@cavium.com>
> Cc: Loc Ho <lho@apm.com>
> Cc: linux-edac@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mips@linux-mips.org
> ---
> drivers/edac/altera_edac.c | 2 --
<snip>
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index db75d4b614f7..fa2e5db56d24 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -38,7 +38,6 @@
> #include "edac_module.h"
>
> #define EDAC_MOD_STR "altera_edac"
> -#define EDAC_VERSION "1"
> #define EDAC_DEVICE "Altera"
>
<snip>
Looks fine for Altera EDAC.
Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
next prev parent reply other threads:[~2017-06-29 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 10:03 [PATCH] EDAC: Get rid of mci->mod_ver Borislav Petkov
2017-06-29 10:14 ` Robert Richter
2017-06-29 10:29 ` Michal Simek
2017-06-29 13:57 ` Thor Thayer [this message]
2017-06-29 14:39 ` Gross, Mark
2017-06-29 16:55 ` Luck, Tony
2017-06-30 18:32 ` Loc Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deade91d-7326-8a39-3881-50db582c3098@linux.intel.com \
--to=thor.thayer@linux.intel.com \
--cc=arvino55@gmail.com \
--cc=bp@alien8.de \
--cc=david.daney@cavium.com \
--cc=jbaron@akamai.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.gross@intel.com \
--cc=michal.simek@xilinx.com \
--cc=ralf@linux-mips.org \
--cc=ravi@jetztechnologies.com \
--cc=rric@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=tim@buttersideup.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox