From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
bcm-kernel-feedback-list@broadcom.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: add Broadcom's BCM63xx watchdog
Date: Wed, 27 Oct 2021 15:33:07 -0700 [thread overview]
Message-ID: <dfc39077-d20f-97ab-591b-d0cb25b6f1aa@gmail.com> (raw)
In-Reply-To: <20211027215531.9996-1-zajec5@gmail.com>
On 10/27/21 2:55 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's a block that can be found on old MIPS devices as well as on
> relatively new BCM4908.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/watchdog/brcm,bcm63xx-wdt.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml
> new file mode 100644
> index 000000000000..f89bdefdeb19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm63xx-wdt.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/brcm,bcm63xx-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BCM63xx watchdog
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +maintainers:
> + - Rafał Miłecki <rafal@milecki.pl>
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,bcm3368-wdt
> + - brcm,bcm4908-wdt
> + - brcm,bcm6328-wdt
> + - brcm,bcm6338-wdt
> + - brcm,bcm6345-wdt
> + - brcm,bcm6348-wdt
> + - brcm,bcm6358-wdt
> + - brcm,bcm6362-wdt
> + - brcm,bcm6368-wdt
> + - brcm,bcm6838-wdt
> + - brcm,bcm6848-wdt
> + - brcm,bcm6858-wdt
> + - brcm,bcm60333-wdt
> + - brcm,bcm63138-wdt
> + - brcm,bcm63148-wdt
> + - brcm,bcm63268-wdt
> + - brcm,bcm63381-wdt
> + - brcm,bcm68360-wdt
That's a lot of compatible strings for a piece of hardware that has not
really change from the venerable BCM6345 days. I believe if you use only
"brcm,bcm6345-wdt" we ought to have everything covered. Similar to the
bcm63xx-uart binding.
--
Florian
next prev parent reply other threads:[~2021-10-27 22:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 21:55 [PATCH 1/3] dt-bindings: watchdog: add Broadcom's BCM63xx watchdog Rafał Miłecki
2021-10-27 21:55 ` [PATCH 2/3] watchdog: bcm63xx_wdt: support compiling with COMPILE_TEST Rafał Miłecki
2021-10-27 21:55 ` [PATCH 3/3] watchdog: bcm63xx_wdt: support BCM4908 Rafał Miłecki
2021-10-27 22:22 ` Guenter Roeck
2021-10-27 22:28 ` Florian Fainelli
2021-10-27 22:33 ` Florian Fainelli [this message]
2021-10-28 5:50 ` [PATCH 1/3] dt-bindings: watchdog: add Broadcom's BCM63xx watchdog Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfc39077-d20f-97ab-591b-d0cb25b6f1aa@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wim@linux-watchdog.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).