From: "Rafał Miłecki" <zajec5@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Willem-Jan de Hoog" <wdehoog@exalondelft.nl>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Florian Fainelli" <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data
Date: Wed, 8 Feb 2023 11:45:15 +0100 [thread overview]
Message-ID: <e3ee64da-e8d9-ba8d-f4d4-f166b7ca825f@gmail.com> (raw)
In-Reply-To: <2e2ff1ec-34a9-db77-64d2-c088e5f1a13d@arinc9.com>
On 8.02.2023 11:29, Arınç ÜNAL wrote:
> On 8.02.2023 13:25, Rafał Miłecki wrote:
>> On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
>>> From: Willem-Jan de Hoog <wdehoog@exalondelft.nl>
>>>
>>> The bcm47xx module has a copy of the NVRAM data in ram. When available, use
>>> this one instead of reading from io memory since it causes mtd/ubi to fail.
>>
>> This doesn't explain anything. Why do we need that? If anything we
>> should rather get rid of that NVRAM firmware driver. It was needed
>> before we had all NVMEM stuff in place. Finally how can reading
>> iomem break mtd/ubi?!
>
> Did you take a look at the bootlog on this post on the thread, I've mentioned your user handle a few times but received no response on the forum.
>
> https://forum.openwrt.org/t/asus-rt-ac88u-hw-a6-broken-in-22-03-3/147882/6?u=arinc9
Well, it doesn't really matter *in context* of getting this patch
accepted for mainline. It needs to be properly described on its own so
people can review it without looking through dozens of forum posts.
Sorry for not following that closely, I lagged behind due to my work on
other Broadcom topics. Broken LZMA, broken Linksys device support,
broken BCM5358. I'll see if I can figure out sth from that thread.
prev parent reply other threads:[~2023-02-08 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1675717472.git.wdehoog@exalondelft.nl>
2023-02-07 8:50 ` [PATCH v3 0/2] nvmem: brcm_nvram: use buffered nvram data for cell values Arınç ÜNAL
2023-02-08 10:17 ` Arınç ÜNAL
[not found] ` <e179c12f73a6035690e814b842f677bbb38f5c96.1675717472.git.wdehoog@exalondelft.nl>
2023-02-08 10:25 ` [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data Rafał Miłecki
2023-02-08 10:29 ` Arınç ÜNAL
2023-02-08 10:45 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ee64da-e8d9-ba8d-f4d4-f166b7ca825f@gmail.com \
--to=zajec5@gmail.com \
--cc=arinc.unal@arinc9.com \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
--cc=wdehoog@exalondelft.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox