Re: [PATCH 1/3] mips: bmips: add PCI support

Thomas Bogendoerfer
2020-06-17T11:17:49Z

On Wed, Jun 17, 2020 at 12:25:54PM +0200, Álvaro Fernández Rojas wrote:
> BMIPS SoCs with PCI: BCM6358, BCM6368.
> BMIPS SoCs with PCIe (gen1): BCM6328, BCM6362, BCM63268.
> BMIPS SoCs with PCIe (gen2): BCM6318.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> arch/mips/Kconfig | 1 +
> arch/mips/pci/Makefile | 1 +
> arch/mips/pci/fixup-bmips.c | 17 +++++++++++++++++
> 3 files changed, 19 insertions(+)
> create mode 100644 arch/mips/pci/fixup-bmips.c
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 6fee1a133e9d..357026cb51de 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -230,6 +230,7 @@ config BMIPS_GENERIC
> select ARCH_HAS_SYNC_DMA_FOR_CPU_ALL
> select ARCH_HAS_PHYS_TO_DMA
> select BOOT_RAW
> + select HAVE_PCI
> select NO_EXCEPT_FILL
> select USE_OF
> select CEVT_R4K

as everything is using DT in your patch, can't you use PCI_DRIVERS_GENERIC
here and drop fixup-bmips ?

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]