From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC746C4332F for ; Wed, 8 Nov 2023 18:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbjKHSNF (ORCPT ); Wed, 8 Nov 2023 13:13:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbjKHSNE (ORCPT ); Wed, 8 Nov 2023 13:13:04 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90C221FEE for ; Wed, 8 Nov 2023 10:13:01 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c7369df9d6so19520521fa.1 for ; Wed, 08 Nov 2023 10:13:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699467180; x=1700071980; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=XyM6VQ+HEN7IzJJ5bMoPN5/yYHnG+EAx9sBxv2Z/Ai8=; b=Lz2Jw7ANw1o+YV6f3bPla8aS+dt3X553EcMsu2E/HGveSuIdvE7kFjv0RrsL0+vTD2 UOJkqS7fZHlMfpIs1EbsGSvS/0fMeYSUq0Q1hySCAQm5KwiQAQWbiFbh/8q7+yxCZGAf hmHaHlFrOTNRtov3lrUAmGRSX6iBucGrmgD5OrzOpdqSeIyTl2K9gXBncsNTMkBMELcf IOwmLlQz6a7xq1pqmRDx/PrC5yoUKMb7992TuLvtkN5k6pEc6r6Y65ITy/5VC9bmE5nv GxwRCumKBjLstfKXxfljTPuFQQZopeD+vMVwkAxls8LP44k18WSWpagZkr3pC4Hss4Lf 6bmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699467180; x=1700071980; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XyM6VQ+HEN7IzJJ5bMoPN5/yYHnG+EAx9sBxv2Z/Ai8=; b=YeayPahEwdPPjf3ZGkwUfGhQyQyaL+CNO4EVGTtIEQfhHWfdb3gwNHjM9rs/qH0jv0 euMSWBGS9ER31Bzaijn3k+87ViGQzzImjaikGjojWcfTZnIbRC4j567lIdwJpkA/emdl jToeCjC6ukY6HjADYz6uMr+bYryE7y22io/DXxxnIsUswz4shVmIYAl6cMxvXBrtpVE8 jeLoo4vuSlo7UVf/XJaEEqUyb9/Mn9VkOBVSw01ZvcxiQ4vbjtwBh8vQmDHRlQcOdxHW uMSkRGqLbJX01KEdazs2lS0cvY498qjGd2FMhp8pI/E7PGsd5Bg7IT2YcMJyHsnuNLor 0ryg== X-Gm-Message-State: AOJu0YyvScYmFoJxz/R/im7NuFSrJI7lnO4U8mVtyPwNuwJ63gFjZ91Y upB0APb4vKVUtz85kFN7XyNPEA== X-Google-Smtp-Source: AGHT+IEAPIM/7orU2/kUz+9e+TY8CYDTNJKLdVzPi+Pze4e6FKjzPA1Tq2W37LpeXm1IyotL7oPMlg== X-Received: by 2002:a2e:8e7b:0:b0:2c5:582:fd8d with SMTP id t27-20020a2e8e7b000000b002c50582fd8dmr2179335ljk.30.1699467179768; Wed, 08 Nov 2023 10:12:59 -0800 (PST) Received: from [10.1.1.118] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id d20-20020a05600c4c1400b003fd2d3462fcsm739766wmp.1.2023.11.08.10.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 10:12:58 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 12/17] iommu: Make iommu_ops_from_fwnode() static From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Jason Gunthorpe , acpica-devel@lists.linuxfoundation.org, Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Lu Baolu , Catalin Marinas , Dexuan Cui , devicetree@vger.kernel.org, David Woodhouse , Frank Rowand , Hanjun Guo , Haiyang Zhang , Christoph Hellwig , iommu@lists.linux.dev, Jean-Philippe Brucker , Jonathan Hunter , Joerg Roedel , "K. Y. Srinivasan" , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-tegra@vger.kernel.org, Russell King , Lorenzo Pieralisi , Marek Szyprowski , Hector Martin , Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Robert Moore , Rob Herring , Robin Murphy , Sudeep Holla , Suravee Suthikulpanit , Sven Peter , Thierry Reding , Thomas Bogendoerfer , Krishna Reddy , Vineet Gupta , virtualization@lists.linux-foundation.org, Wei Liu , Will Deacon Cc: Zhenhua Huang Date: Wed, 08 Nov 2023 18:12:56 +0000 In-Reply-To: <12-v1-5f734af130a3+34f-iommu_fwspec_jgg@nvidia.com> References: <12-v1-5f734af130a3+34f-iommu_fwspec_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Jason, On Fri, 2023-11-03 at 13:44 -0300, Jason Gunthorpe wrote: > There are no external callers now. >=20 > Signed-off-by: Jason Gunthorpe > --- > =C2=A0drivers/iommu/iommu.c | 3 ++- > =C2=A0include/linux/iommu.h | 6 ------ > =C2=A02 files changed, 2 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 62c82a28cd5db3..becd1b881e62dc 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -2945,7 +2945,8 @@ bool iommu_default_passthrough(void) > =C2=A0} > =C2=A0EXPORT_SYMBOL_GPL(iommu_default_passthrough); > =C2=A0 > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle > *fwnode) > +static const struct iommu_ops * > +iommu_ops_from_fwnode(struct fwnode_handle *fwnode) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0const struct iommu_ops *o= ps =3D NULL; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct iommu_device *iomm= u; > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 27e4605d498850..37948eee8d7394 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -701,7 +701,6 @@ static inline void iommu_fwspec_free(struct > device *dev) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dev->iommu->fwspec =3D NU= LL; > =C2=A0} > =C2=A0int iommu_fwspec_add_ids(struct device *dev, u32 *ids, int num_ids)= ; > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle > *fwnode); > =C2=A0int iommu_fwspec_append_ids(struct iommu_fwspec *fwspec, u32 *ids, > int num_ids); > =C2=A0 > =C2=A0static inline struct iommu_fwspec *dev_iommu_fwspec_get(struct > device *dev) > @@ -1044,11 +1043,6 @@ static inline int iommu_fwspec_add_ids(struct > device *dev, u32 *ids, > =C2=A0} > =C2=A0 > =C2=A0static inline > -const struct iommu_ops *iommu_ops_from_fwnode(struct fwnode_handle > *fwnode) > -{ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return NULL; > -} > - > =C2=A0static inline int > =C2=A0iommu_dev_enable_feature(struct device *dev, enum iommu_dev_feature= s > feat) This leaves the extra line with 'static inline', it should also be removed. Cheers, Andre'