linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: linux-kernel@vger.kernel.org, Song Liu <song@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	linux-mips@vger.kernel.org
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory
Date: Fri, 17 Feb 2023 07:53:17 -0800	[thread overview]
Message-ID: <e68c3825-fc8a-d607-1afe-543a4537a81c@infradead.org> (raw)
In-Reply-To: <1dac9eee-f0b9-a6f0-9fed-359242ccb02e@linaro.org>



On 2/17/23 04:35, Philippe Mathieu-Daudé wrote:
> On 17/2/23 12:58, Thomas Bogendoerfer wrote:
>> On Tue, Feb 14, 2023 at 08:52:04AM -0800, Randy Dunlap wrote:
>>>
>>>
>>> On 2/13/23 23:22, Philippe Mathieu-Daudé wrote:
>>>> Hi Randy,
>>>>
>>>> On 14/2/23 01:54, Randy Dunlap wrote:
>>>>> Correct the struct's field/member name from mod_mem to mem.
>>>>>
>>>>> Fixes this build error:
>>>>> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
>>>>> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
>>>>>     643 |         v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>>>>>
>>>>> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
>>>>
>>>> On which tree is your patch based?
>>>
>>> linux-next-20230213.
>>
>> so I can't apply, because this is not in mips-next tree. It should be
>> applied to the tree, where this commit is coming from.
> 
> Or squashed...
> 

Sure, either one of those. I copied Song and Luis on the patch
and it begins with "module:".

@Song !??
@Luis !??

thanks.
-- 
~Randy

  reply	other threads:[~2023-02-17 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  0:54 [PATCH] module: fix MIPS module_layout -> module_memory Randy Dunlap
2023-02-14  7:22 ` Philippe Mathieu-Daudé
2023-02-14 16:52   ` Randy Dunlap
2023-02-17 11:58     ` Thomas Bogendoerfer
2023-02-17 12:35       ` Philippe Mathieu-Daudé
2023-02-17 15:53         ` Randy Dunlap [this message]
2023-02-21 21:39           ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e68c3825-fc8a-d607-1afe-543a4537a81c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=philmd@linaro.org \
    --cc=song@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).