From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D1D8366DD5 for ; Thu, 5 Feb 2026 08:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770280793; cv=none; b=eJ+m9chaWBSacXJ+UjTADsK2iYa/cbqXX5ct2cClhX872WevJnkMgow2oFPwGXlPaA+dyEx3ChGUhw844qoLU0XFHyoZqxop107sggs6dTuv60GEIZ0JO49oYlkPlAaCRMRdHdpPvYCHoyTzwJZdPewBORj7IoWx40ef1A5PH2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770280793; c=relaxed/simple; bh=YvD04nQyj1/NEz9sq9P4Bg/004zZVjWDe2tCRNbeF9o=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=lqWRpyS8i5P+c6NafXQXwkwSBRHjDOvkiwm/TA1g0jn1oMzumXMdi54QdWzySaNDKQXtH6ySMASKzEiN4tHeEEAZ2pbxZIq9evzXnimXiGNPuHJMdanmHGsZZLMZhCbji5YPOOhLmxt+h1k8M47CaEXLDdRmsy9zghqsjfvLAqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V77r26dW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V77r26dW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A93BEC16AAE; Thu, 5 Feb 2026 08:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770280792; bh=YvD04nQyj1/NEz9sq9P4Bg/004zZVjWDe2tCRNbeF9o=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=V77r26dW7HwTNUYJVbKHRYfmwl0/7Ut+k589x6FkFF0ByVk4ky5qelsqjJA7v9jc/ eFblXq90/q1nJFhW7wct34ZKkg489smnbrFNqp73mvzEfa3hlDkOVyqqQ4difHILmx hhzEs0zcaqBMAf2ORRZ1xgr4LXppqvwuBZUcdawgg67VGmcoDzQUTGz2UDNviGkzn1 aU/ObF3iBS6Wvb/l+t4zOk4Flx4LJAvWsgJ3ueZMHJKUM3+ZFBPWuUKtRp9K0jXyIB dj/Ep237KU7qKKI7OlXdL9r5TLGt7X8X43sQgnoizb5ANLGC+O4SvqQu8PHCZDGnbW tAhk9hz9tj04g== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 865ABF40068; Thu, 5 Feb 2026 03:39:51 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Thu, 05 Feb 2026 03:39:51 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukeegkeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpedvueehiedtvedtleekuddutefgffdtleetfeetveejveejieehfefhjeei jeefudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphht thhopehtshgsohhgvghnugesrghlphhhrgdrfhhrrghnkhgvnhdruggvpdhrtghpthhtoh epnhgrthhhrghnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrggtrhhosehorhgt rghmrdhmvgdruhhkpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkh gvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhiphhssehvghgvrhdrkhgv rhhnvghlrdhorhhgpdhrtghpthhtohepmhgvseiiihihrghordgttg X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 572D1700069; Thu, 5 Feb 2026 03:39:51 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A8lqlFeQHG57 Date: Thu, 05 Feb 2026 09:39:31 +0100 From: "Ard Biesheuvel" To: "Maciej W. Rozycki" , "Yao Zi" Cc: "Nathan Chancellor" , "Thomas Bogendoerfer" , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20260202041610.61389-1-me@ziyao.cc> <99c54e93-fb8c-4bdb-ad40-a3161a42bb8b@app.fastmail.com> <20260202230729.GA2319189@ax162> Subject: Re: [PATCH] MIPS: tools: relocs: Ship a definition of R_MIPS_PC32 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, 5 Feb 2026, at 02:26, Maciej W. Rozycki wrote: > On Tue, 3 Feb 2026, Yao Zi wrote: > >> > I interpret that to mean that the kallsyms patch should work fine since >> > the toolchain can handle these relocations? It is just building the >> > relocs tool against an older glibc or musl that does not have the >> > R_MIPS_PC32 definition that is broken? Or am I misunderstanding >> > something? >> >> Yes, this patch is only meant to fix building of relocs tool. I don't >> think there are problems about toolchain supporting since R_MIPS_PC32 >> has been in binutils for a long time, as Nathan found, since 2004. The > > Since Y2K to be exact: > > commit bb2d6cd7b19cd82313963d2d878a94e6e85a38b6 > Author: Geoffrey Keating > Date: Sat Mar 11 02:16:25 2000 +0000 > > [...] > In include/elf: > * mips.h: Add R_MIPS_GNU_REL_HI16, R_MIPS_GNU_REL_LO16, > R_MIPS_GNU_REL16_S2, R_MIPS_PC64 and R_MIPS_PC32 relocation > numbers. > >> situation is that it's likely to have a toolchain supporting >> R_MIPS_PC32, while elf.h on the build machine doesn't have its >> definition. And after ff79d31eb536 ("mips: Add support for PC32 >> relocations in vmlinux"), the relocs tool started to require a >> definition of R_MIPS_PC32 to build. > > But where does ff79d31eb536 come from? I can't see it on Linus's master > and you can't refer an SHA-1 ID from another repo in a 'Fixes:' tag AFAIK, Yes, you can, as long as the owner of the tree does not rebase.