From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB91208A9 for ; Tue, 7 Jan 2025 00:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736211199; cv=none; b=Qt4lc2EG1ybC7k2QpGuDNU5gREnrsXd41Y/eH35+uvbqg4JGjJqsRaiagI+PrYfH/iZclZuhJOwa0K7yPkqtBo4Y2c2MbYHo7krNNfZj5mlnO5r6o5yV001aKugONJqaVdonFuohO7/L0e/4UvgPKkuihp37T8Yuz9/9/Cx+l5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736211199; c=relaxed/simple; bh=c3Gsli1t6Qs5m45O8lq5F4Uh3ZhkcWazXHBcYZPmIQg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rzGrChRxv0PsEkg2D/Rh+y+Wq2SJjfUMSPK4EwpQDJbRIJRHttpSQ4csuxnB1rmjcJEr7b0mWyn6TK00UHdJVrIxZBQkVYMiB91UnLjyTFwt2ljDCj8GTkM4hUPcDb93R4Ac58rGvqJBecY/VDVmxdxEdBaa42Rf5iQtsosgQEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WjYSN5f+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WjYSN5f+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736211195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CtbBZcEWixSx8WxKTGxxVe9YGJddjHivheFuJ/OEl4U=; b=WjYSN5f+y7bmupS5LASENbcmq6uWr1zwhaNHqTOWPRjvciYxq+TP+VhRGI/rZf4sxTPp38 4vU8OngTRcn88F4AKwhLReMNOQy8X17IxqM72466Rdcv4A+JVubJrk79nId6eRmSN4hk+L HcD3MhWH+JGk0SHXeLzbxpH/CgUp/GU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-p1eK94KcOEOBrqrYjSBqqA-1; Mon, 06 Jan 2025 19:53:14 -0500 X-MC-Unique: p1eK94KcOEOBrqrYjSBqqA-1 X-Mimecast-MFC-AGG-ID: p1eK94KcOEOBrqrYjSBqqA Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b6f3b93f5cso2895871885a.0 for ; Mon, 06 Jan 2025 16:53:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736211193; x=1736815993; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CtbBZcEWixSx8WxKTGxxVe9YGJddjHivheFuJ/OEl4U=; b=qiFrSoZI1heDnRRACd/WrCI8/n8KKjBUrUSfP6XXl6JbcTvkxKBdnlRsbHmq6/5gtr 1z8mGVZt7CyjQMof4URNhc0jLlkR20DC/MDGwuWoYqtgXobWN0lVNv7yOoxFuQven6z3 WGhOr/aMYX5/gwfghIiiIA5fPCN3SaDlmDQg5g2ubPtwoBmdr4/EzMIgDVVxsVVKd4O1 Nk19sRD8XqFcSVr0CEzRSHZ6O78isuAaBODkRosBZsex2oZeBdMvML9Ab5EJpGZpL4d+ 7E1znjIcdkmg5q8vgK64lg0t1VhSHATc3QRMgRN9u6zCDvz5el7d/cop2sPndEUwU5QH 7oxw== X-Forwarded-Encrypted: i=1; AJvYcCXHapspHkLa5d9NSyCeHhgOtj+RO4qrZRsF0n3UVKOnBFeneJuTu6MCAaHaWieve8BIFlm5PVQLjTOC@vger.kernel.org X-Gm-Message-State: AOJu0YyMwY/J0BUP254FnOLG4rGS/o5oBxN7v2T0b+yLEXVt5MUfdTgY TM7lzN+NdSqWsVXlkpC9JKn4O5kJyvv/DHwvQtgZY+dJM82bL5XFyyIOlTycGdiUiPK7Y2o+cPK ESdA9TFBcp1gHKrAdr2uRjXpoUgpEu/Ee+w34PHA8dr8nZX2NAyU4/d2KiKE= X-Gm-Gg: ASbGncvRSSTeAV8/FOYam2g+q0MugeDNFLB3z8XMqFRN0RYivMLDYZZiCLMGU62UZVo ZKLw4QfNY9A9RZu3OilGAibNHD0iBL2dIBH31tsZP0Qx9yAjRuh3pEnNMxyd7xXTOWSfvLEPEN8 SRYHfFrlMNBguOhnjsVAEUYjS3/DDrNVY5q9m1g/WiAmsGbXKr54XaJ5nw2Vel3n+zwxLSw+656 yemChwD5lCWhHpYRX4v1v2mL1Mvg8fagwAUgjhSxowzlBzb7WNy+DoF1MK0bUHWgVVO+4VxjYd7 VWa4xo61M/KTvMpYNPLMvWftYPOzrpbsA4k3vBpRQIvllg== X-Received: by 2002:a05:620a:4391:b0:7b1:5545:7104 with SMTP id af79cd13be357-7bb90248f5emr233294085a.2.1736211193454; Mon, 06 Jan 2025 16:53:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGH3zXukWoOxxE9GTC98eC7YuZVzhkxHUhqQrhYMYf+Tp1nGh3nJP16xZ6Vg5mME8zl35azTw== X-Received: by 2002:a05:620a:4391:b0:7b1:5545:7104 with SMTP id af79cd13be357-7bb90248f5emr233291885a.2.1736211193119; Mon, 06 Jan 2025 16:53:13 -0800 (PST) Received: from crwood-thinkpadp16vgen1.minnmso.csb (syn-050-074-019-099.biz.spectrum.com. [50.74.19.99]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac4cd95fsm1549579385a.103.2025.01.06.16.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 16:53:12 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 3/5] powerpc: kvm: drop 32-bit booke From: Crystal Wood To: Arnd Bergmann , kvm@vger.kernel.org Cc: Arnd Bergmann , Thomas Bogendoerfer , Huacai Chen , Jiaxun Yang , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Alexander Graf , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , Marc Zyngier , "A. Wilcox" , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Date: Mon, 06 Jan 2025 19:53:11 -0500 In-Reply-To: <20241221214223.3046298-4-arnd@kernel.org> References: <20241221214223.3046298-1-arnd@kernel.org> <20241221214223.3046298-4-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2024-12-21 at 22:42 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > KVM on PowerPC BookE was introduced in 2008 and supported IBM 44x, > Freescale e500v2 (32-bit mpc85xx, QuorIQ P1/P2), e500mc (32bit QorIQ > P2/P3/P4), e5500 (64-bit QorIQ P5/T1) and e6500 (64-bit QorIQ T2/T4). >=20 > Support for 44x was dropped in 2014 as it was seeing very little use, > but e500v2 and e500mc are still supported as most of the code is shared > with the 64-bit e5500/e6500 implementation. >=20 > The last of those 32-bit chips were introduced in 2010 but not widely > adopted when the following 64-bit PowerPC and Arm variants ended up > being more successful. >=20 > The 64-bit e5500/e6500 are still known to be used with KVM, but I could > not find any evidence of continued use of the 32-bit ones, so drop > discontinue those in order to simplify the implementation. > The changes are purely mechanical, dropping all #ifdef checks for > CONFIG_64BIT, CONFIG_KVM_E500V2, CONFIG_KVM_E500MC, CONFIG_KVM_BOOKE_HV, > CONFIG_PPC_85xx, CONFIG_PPC_FPU, CONFIG_SPE and CONFIG_SPE_POSSIBLE, > which are all known on e5500/e6500. >=20 > Support for 64-bit hosts remains unchanged, for both 32-bit and > 64-bit guests. >=20 > Link: https://lore.kernel.org/lkml/Z1B1phcpbiYWLgCD@google.com/ > Signed-off-by: Arnd Bergmann > --- > arch/powerpc/include/asm/kvm_book3s_32.h | 36 -- > arch/powerpc/include/asm/kvm_booke.h | 4 - > arch/powerpc/include/asm/kvm_booke_hv_asm.h | 2 - > arch/powerpc/kernel/head_85xx.S | 14 - > arch/powerpc/kernel/head_booke.h | 39 -- > arch/powerpc/kvm/Kconfig | 22 +- > arch/powerpc/kvm/Makefile | 15 - > arch/powerpc/kvm/book3s_32_mmu_host.c | 396 -------------- Why are book3s files removed by this patch? > @@ -228,23 +176,16 @@ static inline void kvmppc_save_guest_altivec(struct= kvm_vcpu *vcpu) > static void kvmppc_vcpu_sync_debug(struct kvm_vcpu *vcpu) > { > /* Synchronize guest's desire to get debug interrupts into shadow MSR *= / > -#ifndef CONFIG_KVM_BOOKE_HV > vcpu->arch.shadow_msr &=3D ~MSR_DE; > vcpu->arch.shadow_msr |=3D vcpu->arch.shared->msr & MSR_DE; > -#endif This is an ifndef... the contents should be removed. -Crystal