Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Clem Taylor <clem.taylor@gmail.com>
To: linux-mips@linux-mips.org
Subject: Re: CONFIG_PM depends on CONFIG_MACH_AU1X00?
Date: Fri, 21 Jan 2005 14:22:29 -0500	[thread overview]
Message-ID: <ecb4efd1050121112268e163ba@mail.gmail.com> (raw)
In-Reply-To: <ecb4efd10501210949db48ce1@mail.gmail.com>

I guess I should recompile after making a change to a Kconfig file. It
turns out that the arch/mips/au1000/common/irq.c code doesn't compile
for the Au1550 with CONFIG_PM defined.

arch/mips/au1000/common/irq.c: In function `startup_match20_interrupt':
arch/mips/au1000/common/irq.c:302: error: `AU1000_TOY_MATCH2_INT'
undeclared (first use in this function)
arch/mips/au1000/common/irq.c:302: error: (Each undeclared identifier
is reported only once
arch/mips/au1000/common/irq.c:302: error: for each function it appears in.)
arch/mips/au1000/common/irq.c: In function `intc0_req1_irqdispatch':
arch/mips/au1000/common/irq.c:525: error: `AU1000_TOY_MATCH2_INT'
undeclared (first use in this function)

I fixe this with the following patch:
RCS file: /home/cvs/linux/include/asm-mips/mach-au1x00/au1000.h,v
retrieving revision 1.12
diff -U1 -r1.12 au1000.h
--- ./include/asm-mips/mach-au1x00/au1000.h     4 Dec 2004 18:16:09
-0000      1.12
+++ ./include/asm-mips/mach-au1x00/au1000.h     21 Jan 2005 19:13:36 -0000
@@ -513,3 +513,3 @@
 #define AU1550_PSC3_INT           13
-#define AU1550_TOY_INT                   14
+#define AU1550_TOY_INT            14
 #define AU1550_TOY_MATCH0_INT     15
@@ -517,2 +517,6 @@
 #define AU1550_TOY_MATCH2_INT     17
+#define AU1000_TOY_INT            AU1550_TOY_INT
+#define AU1000_TOY_MATCH0_INT     AU1550_TOY_MATCH0_INT
+#define AU1000_TOY_MATCH1_INT     AU1550_TOY_MATCH1_INT
+#define AU1000_TOY_MATCH2_INT     AU1550_TOY_MATCH2_INT
 #define AU1550_RTC_INT            18

But I then hit some additional errors in arch/mips/au1000/common/time.c:
arch/mips/au1000/common/time.c: In function `counter0_irq':
arch/mips/au1000/common/time.c:126: error: `kstat' undeclared (first
use in this function)
arch/mips/au1000/common/time.c:126: error: (Each undeclared identifier
is reported only once
arch/mips/au1000/common/time.c:126: error: for each function it appears in.)

kstat is only used in common/time.c in the arch/mips/au1000 code. I
don't enough exposure to the codebase to know the right way to fix
this.

                                          --Clem

  parent reply	other threads:[~2005-01-21 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-21 17:49 CONFIG_PM depends on CONFIG_MACH_AU1X00? Clem Taylor
2005-01-21 18:07 ` Dan Malek
2005-01-21 19:22 ` Clem Taylor [this message]
2005-01-21 19:30   ` Dan Malek
2005-01-24 11:45     ` Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecb4efd1050121112268e163ba@mail.gmail.com \
    --to=clem.taylor@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox