From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDF2C433E2 for ; Fri, 11 Sep 2020 07:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EA5A21D91 for ; Fri, 11 Sep 2020 07:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599810293; bh=2SvjM3wyWRinDmfWSZWn8mWwjteNXOXQUxYQxPMk0NY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=L+5+4zIihw/bKxU6nmuuZGbZhk+RENy9kFX9KgBjWrn3S4Xtwv1VNwWBeWjYkskPn Dsiq5baxNz+DM9eT6dKuhQgtYHhUWr5YqrTKzTeco4JQtOksutD5sNVo8yF6vS6VRG I3VZ/O7bfluIl0Vb9U1o1JMt2NQKWkdBVqUvW1g0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725767AbgIKHow (ORCPT ); Fri, 11 Sep 2020 03:44:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:37172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgIKHov (ORCPT ); Fri, 11 Sep 2020 03:44:51 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25DA9214F1; Fri, 11 Sep 2020 07:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599810290; bh=2SvjM3wyWRinDmfWSZWn8mWwjteNXOXQUxYQxPMk0NY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lSYhYhdreUzwBmoUffYyOyHCw/DZO58XxteXwRg9moPDiZxGxLR9vkTubmO8RWW+B 1tNkOG0vjmlw1sWunTJukHwnqkvHwaudYEejFqr4aY45yyDDyeYnhj7KQf+o0UvpWQ 4S0fb1FCRNnXkgOhuveE+iZzXoQJ0I8+cqF2X81k= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kGdjk-00Avb7-3c; Fri, 11 Sep 2020 08:44:48 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 11 Sep 2020 08:44:47 +0100 From: Marc Zyngier To: Huacai Chen Cc: Thomas Bogendoerfer , Thomas Gleixner , Jason Cooper , "open list:MIPS" , Fuxin Zhang , Jiaxun Yang , stable Subject: Re: [PATCH 1/3] MIPS: Loongson64: Increase NR_IRQS to 320 In-Reply-To: References: <1599624552-17523-1-git-send-email-chenhc@lemote.com> <894f35a7883451c4c2bf91b6181376fb@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: chenhc@lemote.com, tsbogend@alpha.franken.de, tglx@linutronix.de, jason@lakedaemon.net, linux-mips@vger.kernel.org, zhangfx@lemote.com, jiaxun.yang@flygoat.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 2020-09-11 04:24, Huacai Chen wrote: > Hi, Marc, > > On Thu, Sep 10, 2020 at 6:10 PM Marc Zyngier wrote: >> >> On 2020-09-09 05:09, Huacai Chen wrote: >> > Modernized Loongson64 uses a hierarchical organization for interrupt >> > controllers (INTCs), all INTC nodes (not only leaf nodes) need some IRQ >> > numbers. This means 280 (i.e., NR_IRQS_LEGACY + NR_MIPS_CPU_IRQS + 256) >> > is not enough to represent all interrupts, so let's increase NR_IRQS to >> > 320. >> > >> > Cc: stable@vger.kernel.org >> > Signed-off-by: Huacai Chen >> > --- >> > arch/mips/include/asm/mach-loongson64/irq.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/arch/mips/include/asm/mach-loongson64/irq.h >> > b/arch/mips/include/asm/mach-loongson64/irq.h >> > index f5e362f7..0da3017 100644 >> > --- a/arch/mips/include/asm/mach-loongson64/irq.h >> > +++ b/arch/mips/include/asm/mach-loongson64/irq.h >> > @@ -7,7 +7,7 @@ >> > /* cpu core interrupt numbers */ >> > #define NR_IRQS_LEGACY 16 >> > #define NR_MIPS_CPU_IRQS 8 >> > -#define NR_IRQS (NR_IRQS_LEGACY + NR_MIPS_CPU_IRQS + 256) >> > +#define NR_IRQS 320 >> > >> > #define MIPS_CPU_IRQ_BASE NR_IRQS_LEGACY >> >> Why are you hardcoding a random value instead of bumping the constant >> in NR_IRQS? > Because INTCs can organized in many kinds of hierarchy, we cannot use > constants to define a accurate value, but 320 is big enough. You're not answering my question. You have a parameterized NR_IRQS, and you're turning it into an absolute constant. Why? I.e: #define NR_IRQS (NR_IRQS_LEGACY + NR_MIPS_CPU_IRQS + 296) And why 320? Why not 512? or 2^15? As for a "modernized" setup, the fact that you are not using SPARSE_IRQ is pretty backward. M. -- Jazz is not dead. It just smells funny...