From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Huacai Chen <chenhuacai@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression
Date: Wed, 19 Jul 2023 13:34:27 +0200 [thread overview]
Message-ID: <f05a7376-6a88-e502-28fe-353db59f61f7@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2307181353110.61566@angie.orcam.me.uk>
On 18/7/23 16:37, Maciej W. Rozycki wrote:
> Remove a build-time check for the presence of the GCC `-msym32' option.
> This option has been there since GCC 4.1.0, which is below the minimum
> required as at commit 805b2e1d427a ("kbuild: include Makefile.compiler
> only when compiler is needed"), when an error message:
>
> arch/mips/Makefile:306: *** CONFIG_CPU_DADDI_WORKAROUNDS unsupported without -msym32. Stop.
>
> started to trigger for the `modules_install' target with configurations
> such as `decstation_64_defconfig' that set CONFIG_CPU_DADDI_WORKAROUNDS,
> because said commit has made `cc-option-yn' an undefined function for
> non-build targets.
>
> Reported-by: Jan-Benedict Glaw <jbglaw@lug-owl.de>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Fixes: 805b2e1d427a ("kbuild: include Makefile.compiler only when compiler is needed")
> Cc: stable@vger.kernel.org # v5.13+
> ---
> arch/mips/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-19 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 14:37 [PATCH 0/3] MIPS: Fix build issues from the introduction of `need-compiler' Maciej W. Rozycki
2023-07-18 14:37 ` [PATCH 1/3] MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression Maciej W. Rozycki
2023-07-19 11:34 ` Philippe Mathieu-Daudé [this message]
2023-07-18 14:37 ` [PATCH 2/3] MIPS: Only fiddle with CHECKFLAGS if `need-compiler' Maciej W. Rozycki
2023-07-18 14:45 ` Guillaume Tucker
2023-07-18 14:37 ` [PATCH 3/3] Revert MIPS: Loongson: Fix build error when make modules_install Maciej W. Rozycki
2023-07-18 14:54 ` [PATCH 0/3] MIPS: Fix build issues from the introduction of `need-compiler' Huacai Chen
2023-07-19 15:39 ` Maciej W. Rozycki
2023-07-20 1:55 ` Huacai Chen
2023-07-21 10:53 ` Maciej W. Rozycki
2023-07-25 8:44 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f05a7376-6a88-e502-28fe-353db59f61f7@linaro.org \
--to=philmd@linaro.org \
--cc=chenhuacai@loongson.cn \
--cc=guillaume.tucker@collabora.com \
--cc=jbglaw@lug-owl.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).