From: David Daney <ddaney@caviumnetworks.com>
To: Matt Redfearn <matt.redfearn@imgtec.com>,
David Daney <david.daney@cavium.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 1/5] MIPS: Optimize uasm insn lookup.
Date: Fri, 26 May 2017 11:25:14 -0700 [thread overview]
Message-ID: <f4472a45-a67b-763f-fffc-26fdc9fa27b4@caviumnetworks.com> (raw)
In-Reply-To: <c8d6691a-0c17-eab7-ac34-efc4e18589b9@imgtec.com>
On 05/26/2017 01:07 AM, Matt Redfearn wrote:
[...]
>> - { insn_lwx, 0, 0 },
>> - { insn_ldx, 0, 0 },
>> - { insn_invalid, 0, 0 }
>> +static struct insn insn_table_MM[insn_invalid] = {
>
> ^ You could make this const too, like you have the one in uasm-mips.c.
>
Good catch. I meant to do that.
I will fix it for the next revision of the patch set.
> Thanks,
> Matt
>
next prev parent reply other threads:[~2017-05-26 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 0:38 [PATCH 0/5] MIPS: Implement eBPF JIT David Daney
2017-05-26 0:38 ` [PATCH 1/5] MIPS: Optimize uasm insn lookup David Daney
2017-05-26 8:07 ` Matt Redfearn
2017-05-26 8:07 ` Matt Redfearn
2017-05-26 18:25 ` David Daney [this message]
2017-05-26 0:38 ` [PATCH 2/5] MIPS: Correctly define DBSHFL type instruction opcodes David Daney
2017-05-26 0:38 ` [PATCH 3/5] MIPS: Add some instructions to uasm David Daney
2017-05-26 0:38 ` [PATCH 4/5] MIPS: Sort uasm enum opcode elements David Daney
2017-05-26 0:38 ` [PATCH 5/5] MIPS: Add support for eBPF JIT David Daney
2017-05-26 2:23 ` Alexei Starovoitov
2017-05-26 16:10 ` David Daney
2017-05-26 15:14 ` Daniel Borkmann
2017-05-26 15:35 ` Daniel Borkmann
2017-05-26 15:39 ` David Daney
2017-05-26 19:09 ` Daniel Borkmann
2017-05-26 19:20 ` David Daney
2017-05-26 19:22 ` Daniel Borkmann
2017-05-26 15:29 ` David Miller
2017-05-26 17:12 ` kbuild test robot
2017-05-26 17:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4472a45-a67b-763f-fffc-26fdc9fa27b4@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=matt.redfearn@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox