From: Aaron Conole <aconole@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
horms@kernel.org, kernel@xen0n.name, chenhuacai@kernel.org,
tsbogend@alpha.franken.de, deller@gmx.de, razor@blackwall.org,
idosch@nvidia.com, ardb@kernel.org, tim.bird@sony.com,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: drop unused LLC-related includes
Date: Tue, 29 Sep 2026 10:11:53 -0400 [thread overview]
Message-ID: <f7tpkxw405y.fsf@aconole-thinkpadt14gen4.rmtusnh.csb> (raw)
In-Reply-To: <20260928190800.2521749-4-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 28 Sep 2026 12:08:00 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> The bridge and the openvswitch code include <net/llc.h>,
> <net/llc_pdu.h> and <linux/llc.h> without using anything out of them.
> parse_ethertype() is the one exception: it wants LLC_SAP_SNAP, which
> comes from the uAPI header <linux/llc.h> pulls in, so flow.c keeps
> that one. The LLC core has leftovers of its own - slab, string,
> interrupt and net_namespace - which it has not used in a long time.
>
> None of this is new, the type 2 removal has just shrunk the LLC
> headers enough to make it easy to see.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
The openvswitch changes look fine to me. I guess it's just a minimal
header adjustment so:
Acked-by: Aaron Conole <aconole@redhat.com>
NOTE: I didn't review anything else in the series.
next prev parent reply other threads:[~2026-09-29 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 19:07 [PATCH net-next 0/3] net: move the type 2 sockets out of tree Jakub Kicinski
2026-09-28 19:07 ` [PATCH net-next 1/3] llc: " Jakub Kicinski
2026-10-01 22:35 ` David Laight
2026-09-28 19:07 ` [PATCH net-next 2/3] llc: strip the leftovers of the llc2 removal Jakub Kicinski
2026-09-28 19:08 ` [PATCH net-next 3/3] net: drop unused LLC-related includes Jakub Kicinski
2026-09-29 14:11 ` Aaron Conole [this message]
2026-09-30 8:15 ` [PATCH net-next 0/3] net: move the type 2 sockets out of tree Nikolay Aleksandrov
2026-10-01 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tpkxw405y.fsf@aconole-thinkpadt14gen4.rmtusnh.csb \
--to=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kernel@xen0n.name \
--cc=kuba@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=tim.bird@sony.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox