From: Florian Fainelli <f.fainelli@gmail.com>
To: Marc Zyngier <maz@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Serge Semin <fancer.lancer@gmail.com>,
Huacai Chen <chenhuacai@kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online()
Date: Mon, 25 Oct 2021 19:17:34 -0700 [thread overview]
Message-ID: <fca3586f-bb7e-a1f7-0f02-97218afcc56d@gmail.com> (raw)
In-Reply-To: <20211021170414.3341522-3-maz@kernel.org>
On 10/21/2021 10:04 AM, Marc Zyngier wrote:
> The MIPS GIC driver uses irq_cpu_online() to go and program the
> per-CPU interrupts. However, this method iterates over all IRQs
> in the system, despite only 3 per-CPU interrupts being of interest.
>
> Let's be terribly bold and do the iteration ourselves. To ensure
> mutual exclusion, hold the gic_lock spinlock that is otherwise
> taken while dealing with these interrupts.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-10-26 2:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:04 [PATCH 0/3] genirq: Make irq_cpu_{on,off}line() an Octeon-special Marc Zyngier
2021-10-21 17:04 ` [PATCH 1/3] MIPS: loongson64: Drop call to irq_cpu_offline() Marc Zyngier
2021-10-24 15:28 ` Thomas Bogendoerfer
2021-10-26 2:16 ` Florian Fainelli
2021-10-21 17:04 ` [PATCH 2/3] irqchip/mips-gic: Get rid of the reliance on irq_cpu_online() Marc Zyngier
2021-10-22 13:57 ` Serge Semin
2021-10-26 2:17 ` Florian Fainelli [this message]
2021-10-21 17:04 ` [PATCH 3/3] genirq: Hide irq_cpu_{on,off}line() behind a deprecated option Marc Zyngier
2021-10-26 2:41 ` Florian Fainelli
2021-10-22 13:53 ` [PATCH 0/3] genirq: Make irq_cpu_{on,off}line() an Octeon-special Serge Semin
2021-10-22 13:59 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fca3586f-bb7e-a1f7-0f02-97218afcc56d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).