From: Alexander Clouter <alex@digriz.org.uk>
To: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: cleanup switches with cases that can be merged
Date: Wed, 20 Jan 2010 11:47:29 +0000 [thread overview]
Message-ID: <h37j27-hgu.ln1@chipmunk.wormnet.eu> (raw)
In-Reply-To: 4B56641E.1030803@caviumnetworks.com
In gmane.linux.ports.mips.general David Daney <ddaney@caviumnetworks.com> wrote:
>
> [snipped]
>
> This brings us to the larger question: This is just code churn. Is it
> even worthwhile?
>
Anything which reduces the line count and remove duplication whilst
sticking to CodingStyle I would always argue for, but "who am I" :)
It at a glance, this type of code churn, shows there are no differences
between two classes of <whatever> and the effect is it makes the chunk
of code a mental NOOP for the person reading the code. :)
To me this is a natural extension of running with Chapter 14 of
CodingStyle where you kmalloc using 'sizeof(*p)' rather than
'sizeof(struct *foo)' so reducing the chance of errors later on.
Just my thoughts.
Cheers
--
Alexander Clouter
.sigmonster says: Snoopy: No problem is so big that it can't be run away from.
next prev parent reply other threads:[~2010-01-20 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 23:59 [PATCH] MIPS: cleanup switches with cases that can be merged Roel Kluin
2010-01-20 2:02 ` David Daney
2010-01-20 11:47 ` Alexander Clouter [this message]
2010-01-23 16:31 ` Ralf Baechle
2010-01-24 0:23 ` Ralf Baechle
2010-01-24 17:58 ` 1 GB RAM with RM9000 SOC Anoop P.A.
2010-01-24 17:58 ` Anoop P.A.
2010-01-25 17:15 ` David Daney
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:38 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h37j27-hgu.ln1@chipmunk.wormnet.eu \
--to=alex@digriz.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).