From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F8AC2BB1D for ; Wed, 8 Apr 2020 18:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 772FD2082F for ; Wed, 8 Apr 2020 18:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730695AbgDHSXi (ORCPT ); Wed, 8 Apr 2020 14:23:38 -0400 Received: from foss.arm.com ([217.140.110.172]:42060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730703AbgDHSXi (ORCPT ); Wed, 8 Apr 2020 14:23:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 753527FA; Wed, 8 Apr 2020 11:23:37 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC5403F73D; Wed, 8 Apr 2020 11:23:32 -0700 (PDT) References: <20200408113505.2528103-1-jiaxun.yang@flygoat.com> <20200408113505.2528103-5-jiaxun.yang@flygoat.com> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, Thomas Bogendoerfer , Huacai Chen , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Florian Fainelli , Robert Richter , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , Thomas Gleixner , Jason Cooper , Marc Zyngier , Paul Burton , Allison Randal , Enrico Weigelt , Vladimir Kondratiev , Alexios Zavras , Richard Fontana , Paul Cercueil , Zhou Yanjie , =?utf-8?B?5ZGo55Cw5p2wIChaaG91IFlhbmppZSk=?= , YunQiang Su , Arnd Bergmann , Serge Semin , Matt Redfearn , Steve Winslow , Peter Xu , afzal mohammed , Mike Rapoport , Kamal Dasu , Oleksij Rempel , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, oprofile-list@lists.sf.net Subject: Re: [PATCH 04/12] arch_topology: Reset all cpus in reset_cpu_topology In-reply-to: <20200408113505.2528103-5-jiaxun.yang@flygoat.com> Date: Wed, 08 Apr 2020 19:23:30 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 08/04/20 12:34, Jiaxun Yang wrote: > For MIPS platform, when topology isn't probed by DeviceTree, > possible_cpu might be empty when calling init_cpu_topology, > that may result cpu_topology not fully reseted for all CPUs. > So here we can reset all cpus instead of possible cpus. > > Signed-off-by: Jiaxun Yang > --- > drivers/base/arch_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 9c2405d08dae..3398b7ac7dfb 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -542,7 +542,7 @@ void __init reset_cpu_topology(void) > { > unsigned int cpu; > > - for_each_possible_cpu(cpu) { > + for (cpu = 0; cpu < NR_CPUS; cpu++) { Hmph, kind of a shame but if you really have to do it then perhaps you should go with ARRAY_SIZE(cpu_topology) instead. > struct cpu_topology *cpu_topo = &cpu_topology[cpu]; > > cpu_topo->thread_id = -1;