From: Juan Quintela <quintela@mandrakesoft.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Ralf Baechle <ralf@linux-mips.org>, mipslist <linux-mips@linux-mips.org>
Subject: Re: [PATCH]:
Date: 19 Dec 2002 22:09:57 +0100 [thread overview]
Message-ID: <m23cotiul6.fsf@demo.mitica> (raw)
In-Reply-To: <Pine.GSO.3.96.1021219215031.27339S-100000@delta.ds2.pg.gda.pl>
>>>>> "maciej" == Maciej W Rozycki <macro@ds2.pg.gda.pl> writes:
maciej> On 19 Dec 2002, Juan Quintela wrote:
>> - pte_val() returs a long, print it directly.
maciej> [...]
>> - printk("Memory Mapping: VA = %08x, PA = %08x ", addr, (unsigned int) pte_val(page));
>> + printk("Memory Mapping: VA = %08x, PA = %08x ", addr, pte_val(page));
maciej> Well, I guess you need "%08lx" then. For both formats, actually.
Arghhhhhhhh, wrong patch,
Ralf, don't apply, appy this other:
Sorry for the inconvenience, just diff the wrong tree :(
Later, Juan.
Index: arch/mips64/mm/tlb-r4k.c
===================================================================
RCS file: /home/cvs/linux/arch/mips64/mm/tlb-r4k.c,v
retrieving revision 1.1.2.5
diff -u -r1.1.2.5 tlb-r4k.c
--- arch/mips64/mm/tlb-r4k.c 2 Dec 2002 00:24:53 -0000 1.1.2.5
+++ arch/mips64/mm/tlb-r4k.c 19 Dec 2002 21:03:09 -0000
@@ -244,7 +244,7 @@
pmd = pmd_offset(pgd, addr);
pte = pte_offset(pmd, addr);
page = *pte;
- printk("Memory Mapping: VA = %08x, PA = %08x ", addr, (unsigned int) pte_val(page));
+ printk("Memory Mapping: VA = %08lx, PA = %08lx ", addr, pte_val(page));
val = pte_val(page);
if (val & _PAGE_PRESENT) printk("present ");
if (val & _PAGE_READ) printk("read ");
@@ -259,7 +259,7 @@
void show_tlb(void)
{
- unsigned int flags;
+ unsigned long flags;
unsigned int old_ctx;
unsigned int entry;
unsigned int entrylo0, entrylo1, entryhi;
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next prev parent reply other threads:[~2002-12-19 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-19 20:00 [PATCH]: Juan Quintela
2002-12-19 20:54 ` [PATCH]: Maciej W. Rozycki
2002-12-19 21:09 ` Juan Quintela [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-18 1:42 [PATCH]: Juan Quintela
2002-12-18 19:29 ` [PATCH]: Ralf Baechle
2002-12-18 21:41 ` [PATCH]: Juan Quintela
2002-12-18 22:35 ` [PATCH]: Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m23cotiul6.fsf@demo.mitica \
--to=quintela@mandrakesoft.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox