From: Juan Quintela <quintela@mandrakesoft.com>
To: Ralf Baechle <ralf@linux-mips.org>, mipslist <linux-mips@linux-mips.org>
Subject: [PATCH]: test_bit returns int in all the architectures
Date: 20 Dec 2002 11:20:02 +0100 [thread overview]
Message-ID: <m2fzstgffx.fsf@demo.mitica> (raw)
Hi
to be consistent with everybody else, test_bit should return a
int. Notice that it only returns 0/1, not a big deal.
Later, Juan.
Index: include/asm-mips64/bitops.h
===================================================================
RCS file: /home/cvs/linux/include/asm-mips64/bitops.h,v
retrieving revision 1.15.2.10
diff -u -r1.15.2.10 bitops.h
--- include/asm-mips64/bitops.h 5 Dec 2002 03:25:20 -0000 1.15.2.10
+++ include/asm-mips64/bitops.h 20 Dec 2002 09:55:13 -0000
@@ -302,7 +302,7 @@
* @nr: bit number to test
* @addr: Address to start counting from
*/
-static inline unsigned long test_bit(int nr, volatile void * addr)
+static inline unsigned int test_bit(int nr, volatile void * addr)
{
return 1UL & (((volatile unsigned long *) addr)[nr >> 6] >> (nr & 0x3f));
}
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next reply other threads:[~2002-12-20 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 10:20 Juan Quintela [this message]
2002-12-20 12:59 ` [PATCH]: test_bit returns int in all the architectures Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fzstgffx.fsf@demo.mitica \
--to=quintela@mandrakesoft.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox