From: Juan Quintela <quintela@mandrakesoft.com>
To: linux mips mailing list <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH]: fix compiler warnings in the math-emulator
Date: 18 Dec 2002 02:43:33 +0100 [thread overview]
Message-ID: <m2znr4p0e2.fsf@demo.mitica> (raw)
Hi
this patch does:
* redefine SETCX to only set cx
* define a new macre SETANDTESTCX for the few cases when we also want to
test the value set.
Later, Juan.
Index: arch/mips/math-emu/dp_cmp.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/dp_cmp.c,v
retrieving revision 1.4.2.1
diff -u -r1.4.2.1 dp_cmp.c
--- arch/mips/math-emu/dp_cmp.c 5 Aug 2002 14:18:22 -0000 1.4.2.1
+++ arch/mips/math-emu/dp_cmp.c 18 Dec 2002 00:49:18 -0000
@@ -44,7 +44,7 @@
if (cmp & IEEE754_CUN)
return 1;
if (cmp & (IEEE754_CLT | IEEE754_CGT)) {
- if (sig && SETCX(IEEE754_INVALID_OPERATION))
+ if (sig && SETANDTESTCX(IEEE754_INVALID_OPERATION))
return ieee754si_xcpt(0, "fcmpf", x);
}
return 0;
Index: arch/mips/math-emu/ieee754dp.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/ieee754dp.c,v
retrieving revision 1.5.2.3
diff -u -r1.5.2.3 ieee754dp.c
--- arch/mips/math-emu/ieee754dp.c 5 Aug 2002 23:53:34 -0000 1.5.2.3
+++ arch/mips/math-emu/ieee754dp.c 18 Dec 2002 00:49:18 -0000
@@ -69,7 +69,7 @@
if (!ieee754dp_issnan(r)) /* QNAN does not cause invalid op !! */
return r;
- if (!SETCX(IEEE754_INVALID_OPERATION)) {
+ if (!SETANDTESTCX(IEEE754_INVALID_OPERATION)) {
/* not enabled convert to a quiet NaN */
DPMANT(r) &= (~DP_MBIT(DP_MBITS-1));
if (ieee754dp_isnan(r))
Index: arch/mips/math-emu/ieee754int.h
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/ieee754int.h,v
retrieving revision 1.3.2.2
diff -u -r1.3.2.2 ieee754int.h
--- arch/mips/math-emu/ieee754int.h 5 Aug 2002 23:53:34 -0000 1.3.2.2
+++ arch/mips/math-emu/ieee754int.h 18 Dec 2002 00:49:18 -0000
@@ -61,7 +61,10 @@
(ieee754_csr.cx = 0)
#define SETCX(x) \
- (ieee754_csr.cx |= (x),ieee754_csr.sx |= (x),ieee754_csr.mx & (x))
+ (ieee754_csr.cx |= (x),ieee754_csr.sx |= (x))
+
+#define SETANDTESTCX(x) \
+ (SETCX(x),ieee754_csr.mx & (x))
#define TSTX() \
(ieee754_csr.cx & ieee754_csr.mx)
Index: arch/mips/math-emu/ieee754sp.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/ieee754sp.c,v
retrieving revision 1.6.2.2
diff -u -r1.6.2.2 ieee754sp.c
--- arch/mips/math-emu/ieee754sp.c 5 Aug 2002 23:53:34 -0000 1.6.2.2
+++ arch/mips/math-emu/ieee754sp.c 18 Dec 2002 00:49:18 -0000
@@ -70,7 +70,7 @@
if (!ieee754sp_issnan(r)) /* QNAN does not cause invalid op !! */
return r;
- if (!SETCX(IEEE754_INVALID_OPERATION)) {
+ if (!SETANDTESTCX(IEEE754_INVALID_OPERATION)) {
/* not enabled convert to a quiet NaN */
SPMANT(r) &= (~SP_MBIT(SP_MBITS-1));
if (ieee754sp_isnan(r))
Index: arch/mips/math-emu/sp_cmp.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/sp_cmp.c,v
retrieving revision 1.4.2.1
diff -u -r1.4.2.1 sp_cmp.c
--- arch/mips/math-emu/sp_cmp.c 5 Aug 2002 14:18:23 -0000 1.4.2.1
+++ arch/mips/math-emu/sp_cmp.c 18 Dec 2002 00:49:18 -0000
@@ -44,7 +44,7 @@
if (cmp & IEEE754_CUN)
return 1;
if (cmp & (IEEE754_CLT | IEEE754_CGT)) {
- if (sig && SETCX(IEEE754_INVALID_OPERATION))
+ if (sig && SETANDTESTCX(IEEE754_INVALID_OPERATION))
return ieee754si_xcpt(0, "fcmpf", x);
}
return 0;
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
next reply other threads:[~2002-12-18 1:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-18 1:43 Juan Quintela [this message]
2002-12-18 16:43 ` [PATCH]: fix compiler warnings in the math-emulator Maciej W. Rozycki
2002-12-18 17:51 ` Juan Quintela
2002-12-18 18:47 ` Maciej W. Rozycki
2002-12-18 19:42 ` Greg Lindahl
2002-12-18 19:50 ` Hartvig Ekner
2002-12-18 19:50 ` Hartvig Ekner
2002-12-18 21:09 ` Maciej W. Rozycki
2002-12-18 21:27 ` Greg Lindahl
2002-12-18 22:27 ` Juan Quintela
2002-12-19 11:52 ` Maciej W. Rozycki
2002-12-18 22:21 ` Juan Quintela
2002-12-19 11:44 ` Maciej W. Rozycki
2002-12-19 0:20 ` Ralf Baechle
2002-12-19 11:09 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2znr4p0e2.fsf@demo.mitica \
--to=quintela@mandrakesoft.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox