Re: [PATCH 1/14] lemote: Loongson2F based machines support

[Arnaud Patard <apatard@mandriva.com>]

yanhua <yanh@lemote.com> writes:

Hi,


> Mini fuloong, yeeloong are all Loongson2F based systems. Loongson2F have
> builtin DDR2 and PCIX controller. The PCIX controller have a similar
> programming interface with FPGA northbridge used in Loongson2E.

First, please read Documentation/SubmittingPatches first. There's no
signed-off-by and this patch is too big. So big patches are making
review a nightmare, please split it into smaller pieces :(

Also, I'd like to see a different directories layout. You're doing :
arch/mips/lemote/
    lm2e/
    lm2f/
        common/
        fuloong/
        yeeloong/

This is quite annoying because:
- I'll prefer seeing loongson instead of Lemote. I've some ST machines
  here they do share a lot of code with the 2e/2f so I'd like to avoid
  duplicating code.

- There's some code very similar between 2e, 2f-yeelong and
  2f-fuloong and other machines. Why not putting them in a common
  directory instead of duplicating again some code ?

To sum up, imho, it would be better to have something like :
arch/mips/loongson/
    common/
    2e/
    2f/ (or something similar)
       common/
       yeelong/
       fuloong/
       ...

Arnaud