From: Arnaud Patard <apatard@mandriva.com>
To: yajin <yajinzhou@vm-kernel.org>
Cc: Ben Dooks <ben@simtec.co.uk>, linux-mips@linux-mips.org
Subject: Re: [PATCH 10/12] add the sm501fb option to sm501 fb driver
Date: Wed, 05 May 2010 15:31:14 +0200 [thread overview]
Message-ID: <m3sk66v5jx.fsf@anduin.mandriva.com> (raw)
In-Reply-To: <o2u180e2c241005050617h299beefdm2fd046c94bdf3101@mail.gmail.com> (yajin's message of "Wed, 5 May 2010 21:17:29 +0800")
yajin <yajinzhou@vm-kernel.org> writes:
> Hi,
>
>>> Why not get this added to the main mode database instead of
>>> adding a new one into the sm501 driver?
>
>> fwiw, the original patch is putting it in the main database.
>
> According to the Documentation/fb/modedb.txt, that's because the
> modedb.c provides one generic video mode database with a fair amount
> of standard videomodes. Yes, 1024x600 can be added to maindb, but I am
> wondering whether it is a generic video mode. If so, there should be
afair it is fairly generic
> 1024x600 in main database already.
Not seeing a mode is the database doesn't mean it shouldn't go
there. It may only mean that nobody needed it before.
Arnaud
prev parent reply other threads:[~2010-05-05 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 9:55 [PATCH 10/12] add the sm501fb option to sm501 fb driver yajin
2010-05-05 12:15 ` Ben Dooks
2010-05-05 12:32 ` Arnaud Patard
2010-05-05 13:17 ` yajin
2010-05-05 13:31 ` Arnaud Patard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk66v5jx.fsf@anduin.mandriva.com \
--to=apatard@mandriva.com \
--cc=ben@simtec.co.uk \
--cc=linux-mips@linux-mips.org \
--cc=yajinzhou@vm-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox