From: Arnaud Patard <apatard@mandriva.com>
To: linux-mips@linux-mips.org
Subject: [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro
Date: Thu, 29 Apr 2010 11:58:51 +0200 [thread overview]
Message-ID: <m3tyquwpes.fsf@anduin.mandriva.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
There's a typo in the LOONGSON_ADDRWIN_CFG macro. The cpu window mmap
register address should contain the destination parameters not the
source one (this has not been noticed because the code is only using
source=destination)
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_addrwin_cfg_macro.patch --]
[-- Type: text/x-patch, Size: 573 bytes --]
Index: linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
===================================================================
--- linux-2.6.orig/arch/mips/include/asm/mach-loongson/loongson.h
+++ linux-2.6/arch/mips/include/asm/mach-loongson/loongson.h
@@ -307,7 +307,7 @@ extern unsigned long _loongson_addrwincf
*/
#define LOONGSON_ADDRWIN_CFG(s, d, w, src, dst, size) do {\
s##_WIN##w##_BASE = (src); \
- s##_WIN##w##_MMAP = (src) | ADDRWIN_MAP_DST_##d; \
+ s##_WIN##w##_MMAP = (dst) | ADDRWIN_MAP_DST_##d; \
s##_WIN##w##_MASK = ~(size-1); \
} while (0)
next reply other threads:[~2010-04-29 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 9:58 Arnaud Patard [this message]
2010-04-29 16:39 ` [PATCH] loongson.h: Fix LOONGSON_ADDRWIN_CFG macro Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyquwpes.fsf@anduin.mandriva.com \
--to=apatard@mandriva.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox