From: Arnaud Patard <apatard@mandriva.com>
To: linux-mips@linux-mips.org
Subject: [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check
Date: Thu, 29 Apr 2010 11:58:49 +0200 [thread overview]
Message-ID: <m3vdbawpeu.fsf@anduin.mandriva.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
The check used to determine if uncached accelerated should be used or
not is wrong. The parenthesis are misplaced and making the test fail.
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix_phys_mem_access_prot_check.patch --]
[-- Type: text/x-patch, Size: 537 bytes --]
Index: linux-2.6/arch/mips/loongson/common/mem.c
===================================================================
--- linux-2.6.orig/arch/mips/loongson/common/mem.c
+++ linux-2.6/arch/mips/loongson/common/mem.c
@@ -75,7 +75,7 @@ pgprot_t phys_mem_access_prot(struct fil
unsigned long end = offset + size;
if (__uncached_access(file, offset)) {
- if (((uca_start && offset) >= uca_start) &&
+ if (uca_start && (offset >= uca_start) &&
(end <= uca_end))
return __pgprot((pgprot_val(vma_prot) &
~_CACHE_MASK) |
next reply other threads:[~2010-04-29 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 9:58 Arnaud Patard [this message]
2010-04-29 16:35 ` [PATCH] arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdbawpeu.fsf@anduin.mandriva.com \
--to=apatard@mandriva.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox