From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B925C433DB for ; Thu, 14 Jan 2021 12:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06B3723A50 for ; Thu, 14 Jan 2021 12:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728205AbhANMBa (ORCPT ); Thu, 14 Jan 2021 07:01:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:50520 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbhANMBa (ORCPT ); Thu, 14 Jan 2021 07:01:30 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E6F0AB775; Thu, 14 Jan 2021 12:00:48 +0000 (UTC) Date: Thu, 14 Jan 2021 13:00:48 +0100 Message-ID: From: Takashi Iwai To: Lauri Kasanen Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de, perex@perex.cz Subject: Re: [PATCH 5/6 v6] sound: Add n64 driver In-Reply-To: <20210113171322.77105fa8f92826e6b716631a@gmx.com> References: <20210113171322.77105fa8f92826e6b716631a@gmx.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 13 Jan 2021 16:13:22 +0100, Lauri Kasanen wrote: > > This adds support for the Nintendo 64 console's sound. > > Signed-off-by: Lauri Kasanen > --- > sound/mips/Kconfig | 7 + > sound/mips/Makefile | 1 + > sound/mips/snd-n64.c | 382 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 390 insertions(+) > create mode 100644 sound/mips/snd-n64.c > > v6: > moved irq before register Looks good to me. I'm fine to apply it but without other patches it makes little sense, I suppose. If it goes through MIPS tree or any others, feel free to take my ack: Reviewed-by: Takashi Iwai thanks, Takashi