From mboxrd@z Thu Jan  1 00:00:00 1970
Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 27 Nov 2009 10:18:30 +0100 (CET)
Received: from cantor2.suse.de ([195.135.220.15]:35752 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP
        id S1492047AbZK0JSZ (ORCPT <rfc822;linux-mips@linux-mips.org>);
        Fri, 27 Nov 2009 10:18:25 +0100
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2])
        by mx2.suse.de (Postfix) with ESMTP id C8CD9A40A6;
        Fri, 27 Nov 2009 10:18:24 +0100 (CET)
Date:   Fri, 27 Nov 2009 10:18:24 +0100
Message-ID: <s5h7htc5nrz.wl%tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc:     alsa-devel@alsa-project.org, Ralf Baechle <ralf@linux-mips.org>,
        Wu Zhangjin <wuzhangjin@gmail.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@linux-mips.org, Kumar Gala <galak@gate.crashing.org>,
        Becky Bruce <beckyb@kernel.crashing.org>
Subject: Re: [PATCH 4/5] ALSA: pcm - fix page conversion on non-coherent PPC arch
In-Reply-To: <1259268704.18084.4.camel@pasglop>
References: <1259248388-20095-1-git-send-email-tiwai@suse.de>
        <1259248388-20095-2-git-send-email-tiwai@suse.de>
        <1259248388-20095-3-git-send-email-tiwai@suse.de>
        <1259248388-20095-4-git-send-email-tiwai@suse.de>
        <1259248388-20095-5-git-send-email-tiwai@suse.de>
        <1259268704.18084.4.camel@pasglop>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-Path: <tiwai@suse.de>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 25172
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: tiwai@suse.de
Precedence: bulk
X-list: linux-mips

At Fri, 27 Nov 2009 07:51:44 +1100,
Benjamin Herrenschmidt wrote:
> 
> On Thu, 2009-11-26 at 16:13 +0100, Takashi Iwai wrote:
> > The non-cohernet PPC arch doesn't give the correct address by a simple
> > virt_to_page() for pages allocated via dma_alloc_coherent().
> > This patch adds a hack to fix the conversion similarly like MIPS.
> > 
> > Note that this doesn't fix perfectly: the pages should be marked with
> > proper pgprot value.  This will be done in a future implementation like
> > the conversion to dma_mmap_coherent().
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> This will not work with swiotlb, but then, I don't think we have -yet-
> to deal with a platform that does both swiotlb and isn't DMA
> coherent :-)
> 
> Of course, the conversion to dma_mmap_coherent will makes things better
> though we really will want to push that function into the dma ops.
> 
> So it's hackish but for now its an
> 
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Thanks, I added your ack to the GIT commit.


Takashi