From: Takashi Iwai <tiwai@suse.de>
To: Lauri Kasanen <cand@gmx.com>
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de, perex@perex.cz
Subject: Re: [PATCH 5/6 v2] sound: Add n64 driver
Date: Wed, 13 Jan 2021 13:04:50 +0100 [thread overview]
Message-ID: <s5hlfcxniu5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210113135716.b8cb71c94edb7c7605002068@gmx.com>
On Wed, 13 Jan 2021 12:57:16 +0100,
Lauri Kasanen wrote:
>
> On Mon, 11 Jan 2021 16:25:08 +0100
> Takashi Iwai <tiwai@suse.de> wrote:
>
> > On Mon, 11 Jan 2021 13:02:22 +0100,
> > Lauri Kasanen wrote:
> > > This order gives correct pointer advancing etc, but now it's hitting a
> > > new problem: the pcm core is reusing the buffer from under the audio
> > > card. It's writing new data to the area that is currently being read by
> > > DMA.
> >
> > Could you elaborate? I still don't get what's going on there.
>
> I figured it out. Turns out the hw registers were double-buffered in a
> way that requires two periods' worth of buffers. The IRQ fires when one
> buffer is finished and another is queued, not when everything is
> finished as I first thought.
>
> There doesn't seem to be a way to request the PCM core to keep two
> periods' distance instead of one? I will deploy memcpy then.
We may return to the first approach, i.e. just use nextpos. But then
snd_pcm_period_elapsed() has to be called right after the trigger
callback without the IRQ, because the trigger START already queued the
full period and the position advances. So the first period-elapsed
has to be called from a work or such offload instead of IRQ.
In anyway, it's a bit tricky, yeah.
Takashi
next prev parent reply other threads:[~2021-01-13 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:35 [PATCH 5/6 v2] sound: Add n64 driver Lauri Kasanen
2021-01-08 9:06 ` Takashi Iwai
2021-01-08 10:13 ` Lauri Kasanen
2021-01-09 7:23 ` Lauri Kasanen
2021-01-09 8:16 ` Takashi Iwai
2021-01-09 17:46 ` Lauri Kasanen
2021-01-09 18:17 ` Takashi Iwai
2021-01-09 20:54 ` Takashi Iwai
2021-01-10 7:15 ` Lauri Kasanen
2021-01-10 10:24 ` Takashi Iwai
2021-01-10 17:03 ` Lauri Kasanen
2021-01-10 17:22 ` Takashi Iwai
2021-01-10 17:41 ` Lauri Kasanen
2021-01-11 8:05 ` Takashi Iwai
2021-01-11 9:43 ` Lauri Kasanen
2021-01-11 10:11 ` Takashi Iwai
2021-01-11 12:02 ` Lauri Kasanen
2021-01-11 15:25 ` Takashi Iwai
2021-01-11 15:51 ` Lauri Kasanen
2021-01-13 11:57 ` Lauri Kasanen
2021-01-13 12:04 ` Takashi Iwai [this message]
2021-01-13 12:14 ` Lauri Kasanen
2021-01-13 12:38 ` Takashi Iwai
2021-01-13 12:49 ` Lauri Kasanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hlfcxniu5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cand@gmx.com \
--cc=linux-mips@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox