From: "Måns Rullgård" <mans@mansr.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-mmc@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH, RFC] MIPS: jz4740: use dma filter function
Date: Tue, 06 Jan 2015 12:47:00 +0000 [thread overview]
Message-ID: <yw1xtx04f54r.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <54ABBCE6.8060904@metafoo.de> (Lars-Peter Clausen's message of "Tue, 06 Jan 2015 11:45:58 +0100")
Lars-Peter Clausen <lars@metafoo.de> writes:
> On 01/05/2015 11:39 PM, Arnd Bergmann wrote:
>> As discussed on the topic of shmobile DMA today, jz4740 is the only
>> user of the slave_id field in dma_slave_config besides shmobile. This
>> use is really incompatible with the way that other drivers use the
>> dmaengine API, so we should get rid of it.
>
> Do you have a link to that discussion?
>
>>
>> This adds a trivial filter function that uses the filter param to
>> pass the dma type, and uses that in both drivers.
>
> In my opinion that's just from bad to worse. Using filter functions
> isn't that great in the first place. And using them to pass data from
> the consumer to the DMA provider is just a horrible abuse of the API.
It seems to me the only sane way to use the dmaengine API is in
conjunction with DT.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-01-06 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 22:39 [PATCH, RFC] MIPS: jz4740: use dma filter function Arnd Bergmann
2015-01-06 10:45 ` Lars-Peter Clausen
2015-01-06 12:47 ` Måns Rullgård [this message]
2015-01-06 12:51 ` Lars-Peter Clausen
2015-01-06 13:48 ` Arnd Bergmann
2015-01-07 14:29 ` Lars-Peter Clausen
2015-01-07 16:13 ` Arnd Bergmann
2015-01-07 16:17 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xtx04f54r.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox