From: Marek Szyprowski <m.szyprowski@samsung.com>
To: 'Aaro Koskinen' <aaro.koskinen@iki.fi>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
'Michal Nazarewicz' <mina86@mina86.com>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Russell King' <linux@arm.linux.org.uk>,
'Andrew Morton' <akpm@linux-foundation.org>,
'KAMEZAWA Hiroyuki' <kamezawa.hiroyu@jp.fujitsu.com>,
'Daniel Walker' <dwalker@codeaurora.org>,
'Mel Gorman' <mel@csn.ul.ie>, 'Arnd Bergmann' <arnd@arndb.de>,
'Jesse Barker' <jesse.barker@linaro.org>,
'Jonathan Corbet' <corbet@lwn.net>,
'Shariq Hasnain' <shariq.hasnain@linaro.org>,
'Chunsang Jeong' <chunsang.jeong@linaro.org>,
'Dave Hansen' <dave@linux.vnet.ibm.com>,
'Benjamin Gaignard' <benjamin.gaignard@linaro.org>,
'Rob Clark' <rob.clark@linaro.org>,
'Ohad Ben-Cohen' <ohad@wizery.com>
Subject: RE: [PATCHv22 13/16] drivers: add Contiguous Memory Allocator
Date: Wed, 22 Feb 2012 17:26:43 +0100 [thread overview]
Message-ID: <000001ccf17e$c3e50040$4baf00c0$%szyprowski@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1202212121560.962@localhost>
Hello,
On Tuesday, February 21, 2012 10:30 PM Aaro Koskinen wrote:
> On Fri, 17 Feb 2012, Marek Szyprowski wrote:
> > +/**
> > + * dma_release_from_contiguous() - release allocated pages
> > + * @dev: Pointer to device for which the pages were allocated.
> > + * @pages: Allocated pages.
> > + * @count: Number of allocated pages.
> > + *
> > + * This function releases memory allocated by dma_alloc_from_contiguous().
> > + * It returns false when provided pages do not belong to contiguous area and
> > + * true otherwise.
> > + */
> > +bool dma_release_from_contiguous(struct device *dev, struct page *pages,
> > + int count)
> > +{
> > + struct cma *cma = dev_get_cma_area(dev);
> > + unsigned long pfn;
> > +
> > + if (!cma || !pages)
> > + return false;
> > +
> > + pr_debug("%s(page %p)\n", __func__, (void *)pages);
> > +
> > + pfn = page_to_pfn(pages);
> > +
> > + if (pfn < cma->base_pfn || pfn >= cma->base_pfn + cma->count)
> > + return false;
> > +
> > + VM_BUG_ON(pfn + count > cma->base_pfn);
>
> Are you sure the VM_BUG_ON() condition is correct here?
Thanks for pointing this bug. '+ cma->count' is missing in the second part.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-22 16:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 19:30 [PATCHv22 00/16] Contiguous Memory Allocator Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 01/16] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 02/16] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 03/16] mm: compaction: introduce map_pages() Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 04/16] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 05/16] mm: compaction: export some of the functions Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 06/16] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 07/16] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 08/16] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 09/16] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 10/16] mm: Serialize access to min_free_kbytes Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 11/16] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 13/16] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-02-21 21:30 ` Aaro Koskinen
2012-02-22 16:26 ` Marek Szyprowski [this message]
2012-02-17 19:30 ` [PATCHv22 14/16] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-02-22 0:18 ` Andrew Morton
2012-02-22 9:09 ` Russell King - ARM Linux
2012-02-22 13:36 ` Arnd Bergmann
2012-02-22 16:36 ` Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 15/16] ARM: " Marek Szyprowski
2012-02-17 19:30 ` [PATCHv22 16/16] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2012-02-18 0:23 ` [PATCHv22 00/16] Contiguous Memory Allocator Anca Emanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ccf17e$c3e50040$4baf00c0$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=chunsang.jeong@linaro.org \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=ohad@wizery.com \
--cc=rob.clark@linaro.org \
--cc=shariq.hasnain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).