From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A271FC83F17 for ; Fri, 18 Jul 2025 15:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45B3D6B007B; Fri, 18 Jul 2025 11:44:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40BAE6B0096; Fri, 18 Jul 2025 11:44:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9E86B0095; Fri, 18 Jul 2025 11:44:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1A1478D0001 for ; Fri, 18 Jul 2025 11:44:02 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBBD91CF7A7 for ; Fri, 18 Jul 2025 15:44:01 +0000 (UTC) X-FDA: 83677806282.29.2F5C5CC Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 62F2610000A for ; Fri, 18 Jul 2025 15:43:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eRfAiIYf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752853439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJ3ROjwqD3CLXG2IiheiI0iDXPqsbWX3BCQXRvH9p54=; b=8eDY65mo2pd6af4eYhg/mY6ohKGAprSjbQyzlHOXE0173FAy5ROdYcrOU5TF23pa3yNqh6 VpmHF6xyhZ3174xkaWC3AZjH23EDrIuKZeycswgtaJtdmsjy6TQHhhzZxttLJIu5YXsbY6 hTfH4l01kVyzyfZXbfkbBBWSx6m/s1Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752853439; a=rsa-sha256; cv=none; b=UtCyztlpJcwc3ddd+JxJ8hptPt/7lQysLvTYSb9HPz9sBiAq6P4dTIYxNffN+Gr0OlN8We 2HIZNx8z4kn/270HNlQzuJcy1f8lr2azZwgmvbW+xSjKgHAahPM3azHxKvFeIYq7W3iu+9 NO140x3EejekFZKVfhq+K1O9rgCDp74= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eRfAiIYf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-32b4c37ebf3so4314811fa.3 for ; Fri, 18 Jul 2025 08:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752853437; x=1753458237; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hJ3ROjwqD3CLXG2IiheiI0iDXPqsbWX3BCQXRvH9p54=; b=eRfAiIYfRsRWmx7d04w81LYrlI8Eb6kYm0cfDWX497Trqlq7YujL59XhX7+iymeYtm RKYIT+xKqa0nWLa35g+SI4Fc1NVTC8MzjCupWkFX+6ZkasHGQefjQmf9lh66emXvgJGm 8BwEt852Z5+VhnViZpRAhO16UojzdVBxNNIC4eMDKqmT/xeTe6+E/kI9eSeabsXvsw1F gnEsNaADsboINMMGlbcxUGkp0mWobrlduX+agkCMmZPy3yQmnqpFBC1SwpYNw7Ie8Mhd tQZ8xaNiCtISRrg9MshMM0Gu0FrB+fiDAAm/TXRDeJfrSUJ4mrujBlhI4cdIOSooYPj5 wGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752853437; x=1753458237; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hJ3ROjwqD3CLXG2IiheiI0iDXPqsbWX3BCQXRvH9p54=; b=AmlWGzeDRcww1mOT5dAAUuGRyNK5AGiASQIjlFjw4VKIAEf6kscgPCb8MqXsnU4Kw2 MPJ4Xh2SzS9hPNlP99HQu07HwZKVeS8AcNAMPNvcLqYUokTILkiwu/cOGS0F/FgC0Npn i273wOk15j+YNN3+eyekqLI2UVaxKIa5vQkqjCuu/3x7GHJhkwPdjZGlwwQKXd7Yzgig g3ZTgALul7CQIj593hVvQw1LBiwi4JQyZpoquEChMGIk50Q+KZAzYWcdZ4+JulxjNp7P JHiV/Vzk3aYWeKf3XhGvhrLr11DzijQutVEyQcQT2OQgo3cPT89e/rhtYKxM4eAxoIZq ETHg== X-Forwarded-Encrypted: i=1; AJvYcCUzut8WaSMUrYkGKyhPvNCGAU80b9GT7IJa+ckS8YwIlIDXGS73qNZbuBS21Hyhp5r0M30Q5SlBSw==@kvack.org X-Gm-Message-State: AOJu0Yy2DsgGdHfws6ajdfcNf1e+1Qe+EBejsFdeo89mTMbFBFdLcz/P vtGf1LmT/fl/kVsWJpw2ovUJuaj95E0dFgyyjostlp3D9Rmkh54q+Jfb X-Gm-Gg: ASbGncum/Er3CKOhy9g4vdDWd5RWAkbpyZmJM0Bn/dvUgDYfPFl5qio4pMpBIHDBoGf MGIGiplJ3C1F3J5LW0TdGgmSyGiKUo4EZRux/ZUZUK29E5Rtu/D8BjvTBLxH/vG+wuD6SKazkIR ZN1A7JqWRFcRi8sUBtMfi0CmkVcxeX5ZR5F9OJwSKumxpaPxjuD1nB4TO30ZLFzJBvtZ5VFUJOd bA0+eSuQT1ud5SjjgqT1gccd9BEEtV4Bd0BFGDicfcutwLHeOHObDA36b3J6yCEDiSiSS3Cy9xb L+fTUanmiYVIC0DoGngy6jRisQ2dgBeMylw+VpGOC1FppSy0yNgrTvOtyvB9b7n7dDm0ehPkJ5D lhmmruTnvZ1ljfa7h6QDJj/EqCjFf X-Google-Smtp-Source: AGHT+IHuDciecE4/7Mw37ftoaXpLaruOdcnYTZ+5ZmmnuTgI8TgOpSp8IT4jSI8HtwvRnaLKI1Zjpg== X-Received: by 2002:a05:6512:128a:b0:545:ece:82d5 with SMTP id 2adb3069b0e04-55a233a28b1mr1360799e87.13.1752853436956; Fri, 18 Jul 2025 08:43:56 -0700 (PDT) Received: from [10.214.35.248] ([80.93.240.68]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55a31d7c777sm299394e87.116.2025.07.18.08.43.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 08:43:55 -0700 (PDT) Message-ID: <0004f2ed-ac2b-4d93-8a4d-d01cbede94a2@gmail.com> Date: Fri, 18 Jul 2025 17:43:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kasan: use vmalloc_dump_obj() for vmalloc error reports To: Marco Elver , Andrew Morton Cc: Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Sebastian Andrzej Siewior , Yeoreum Yun , Yunseong Kim , stable@vger.kernel.org References: <20250716152448.3877201-1-elver@google.com> Content-Language: en-US From: Andrey Ryabinin In-Reply-To: <20250716152448.3877201-1-elver@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: audnnyonp55egyb3dmtfxrk75iaazeju X-Rspamd-Queue-Id: 62F2610000A X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752853439-934518 X-HE-Meta: U2FsdGVkX1+3lkksKHd/XNmXTe9xFQmYLtq6WjDBYMYzJcLMzGgnRGnUwHd6k0U6CDZtKfCowCOF11wByUxFVXiAXiRKQlP+yzfqAFnpB3B+TjfCIgU9UHKkLjU0f74br0i/KojuQAF+xrFeLsCm+tPJztsXPgzbQXNUw1mrCx9uhWZ5QwCWGueRYvLWr0KOsfQuIjCjJNP/9fSesAOy5u4D+I+eJX4iFNZ/q1XaECGvkqJCF/iZ2X2VzoO5GBAzjrOGnWzOPIxN7JHU/kGl82JzdLaGLB6yrUzCKC2qSjY9kx2mk5lZr69FPP2aRqTQb+2M1U0mJjHLYcBhfrp88Sp8TqrCeFu+zZ9JdedlJrgtZ1TPxCH9w5MQLeW46J2dE+U6Dc+CYyl86BMgmDrvGrVKCBIzipNAt1vA4UnyJBekYmPIy4BRB3fdpCkqqFnuTNhgQN2PvZf4AArwYOHJof9Jyu+mhqaFUB4BvxjrKCTgdXK6TBoq9/8hPTcJtZ0CrgPI7i6MqMEKvwvjlXzRdsJ2xL7ye6lpxzhnxzw2B6nin6oVat2wzoh49FvhM0CIJGmwSNLstBAyaw5MinbN0Q+WxJX8VE8YiADzoWjrKU30zpfwOG6DqUXh3J49jN8/pihV+vYRqKbjYBzclOBaSnamaCq+y7/EtcuJ0012ixwWj5GMpZSo1tepGSYUiUt/Fc4cQ465b9XaeD9omNoVDpoPVJM35UWTQ3liPzgn2hpTTOhln2WR0HdUzMvbNQIWa7r9mttn8yYQCocbvDXxf4TdWA4ci8RJgQljb9ytnYBcEYoj9FWbXqq4UXRmtw4AvTaZAFBZV8xNeuPu3vhXJXkDD3CCkhjfMpCB+OXPAE003O/7vWX8ZB5rEvLqHr6gc01f6zZO3bAFakdtabjifr23A8/OawGddP6pSdQ3ln0DbNv4Moyg1m9g7lnSaofQWp93+yIuMlYK7WYxhrl n5KJNCCB aVsWkIVX+qLfeYkWqTRXhO71fSXc2M6tl6S8HClWatihOJewM1TI1eQg8gXP3a7nST2ewTmHUk/v2c06jeJM4a2E/zFQXeten6ov/taBpvZtWwPHExjkUOupa2csQ2AZzHG/JyROFWconb3m4PBQMTZ/O7GW931YXJ8ComKjDxoP6nLWmyBgKjsq8Sy6SJea6aisTLpzPioqX0AjMq3Jov6jam3bH8XdD+l10YTHt3nLKK5W0cdHE1CvnWeHNCdX/Rj3c031O/W2hidd24uJyx3Hx9h2JTnvyocg/NUSHytYDwXrgxn+OtsuQbB0lXCn2e3yKRiegqZo017zAUho6iL3UsxHL29gFJl2Q7C4W9WJKfNBWZHjN8DRWzYMUw+GBIVt6COUJWMJR/hYsi2kkxOfeccAQs5ocDVJ1u9pRd/GhKvvKNUc2eYqB72KmNF2wydRqIWEvoTNASctFHmP6fWERRlCeBp+ZTiCXZt0yZo1jeOFrcesoIvdGVTvQc6JGROFDZxJn/E/AO6pDGapDiGgsZPgno+5jFB94MakORs+GTiLHK3KQKv9yaPoOrwQNCMdFO/Fd7tPotnzkh73Lq+rSUxednH31QZz4eWGMUDDDs/hChR0HyBhjq/MelnNk/QUoOSCTlWf18GFDHldGU1tdupVCBBKjAyDESkeutIB0Z8vjggO0N8v2CVhYVZenNSzVaM5gLpJa148= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/16/25 5:23 PM, Marco Elver wrote: > Since 6ee9b3d84775 ("kasan: remove kasan_find_vm_area() to prevent > possible deadlock"), more detailed info about the vmalloc mapping and > the origin was dropped due to potential deadlocks. > > While fixing the deadlock is necessary, that patch was too quick in > killing an otherwise useful feature, and did no due-diligence in > understanding if an alternative option is available. > > Restore printing more helpful vmalloc allocation info in KASAN reports > with the help of vmalloc_dump_obj(). Example report: > > | BUG: KASAN: vmalloc-out-of-bounds in vmalloc_oob+0x4c9/0x610 > | Read of size 1 at addr ffffc900002fd7f3 by task kunit_try_catch/493 > | > | CPU: [...] > | Call Trace: > | > | dump_stack_lvl+0xa8/0xf0 > | print_report+0x17e/0x810 > | kasan_report+0x155/0x190 > | vmalloc_oob+0x4c9/0x610 > | [...] > | > | The buggy address belongs to a 1-page vmalloc region starting at 0xffffc900002fd000 allocated at vmalloc_oob+0x36/0x610 > | The buggy address belongs to the physical page: > | page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x126364 > | flags: 0x200000000000000(node=0|zone=2) > | raw: 0200000000000000 0000000000000000 dead000000000122 0000000000000000 > | raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 > | page dumped because: kasan: bad access detected > | > | [..] > > Fixes: 6ee9b3d84775 ("kasan: remove kasan_find_vm_area() to prevent possible deadlock") > Suggested-by: Uladzislau Rezki > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Andrey Ryabinin > Cc: Sebastian Andrzej Siewior > Cc: Yeoreum Yun > Cc: Yunseong Kim > Cc: > Signed-off-by: Marco Elver Acked-by: Andrey Ryabinin