From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F00EB64D9 for ; Wed, 28 Jun 2023 02:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C17988D0002; Tue, 27 Jun 2023 22:44:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC7FF8D0001; Tue, 27 Jun 2023 22:44:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB6DD8D0002; Tue, 27 Jun 2023 22:44:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E4018D0001 for ; Tue, 27 Jun 2023 22:44:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7B219B0490 for ; Wed, 28 Jun 2023 02:44:44 +0000 (UTC) X-FDA: 80950613688.24.726654B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf17.hostedemail.com (Postfix) with ESMTP id 7006840011 for ; Wed, 28 Jun 2023 02:44:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of sunnanyong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=sunnanyong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687920282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CQc17SPLzRjTwAGr1ja5d0JjC/HqzuvDmU2OAIb7yvQ=; b=2a2GEnaOZhSYLyj7EVbDXZiqAGuf2HAicXZpYnzv9N8NYSsnDSZxygFYpxaiM611m4sezc egJP870qYZjbpAxoOS3Xz6pmN8vy0Y79CCTRqfQnzdV3OWKgG7LcGfsTeeo3OAQwngspLA Kgw2xQvYT9RmYpHEls6w3NV5Fx1gmhQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687920282; a=rsa-sha256; cv=none; b=B6BBmtJGD8g/wlakljtLNpU4rWZdB+eJGi7kbFT1xJKl8/MruGrxEi0AxgeRkfCoNV5nTG BHo8vw7L2AyDiSJ+NVVdGTthbPtcvT8jVmiASYLsThQrtHjKEShMTT715Ge+76wWtDSCMc ufHsa+XGF8x5y4/SG4GxH8evVFk9v8g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of sunnanyong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=sunnanyong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QrQnc3x20zMpjM; Wed, 28 Jun 2023 10:41:24 +0800 (CST) Received: from [10.174.179.79] (10.174.179.79) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 10:44:34 +0800 Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce in proc To: Andrew Morton CC: , , , References: <20230627133542.2446285-1-sunnanyong@huawei.com> <20230627122201.6e25819493823dfc7cca4741@linux-foundation.org> From: Nanyong Sun Message-ID: <000d6e0d-d4fc-abbf-5764-ab763e5dc8b2@huawei.com> Date: Wed, 28 Jun 2023 10:44:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20230627122201.6e25819493823dfc7cca4741@linux-foundation.org> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.79] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Stat-Signature: 3r4imncnc1yq9nngrkjy1yumrqg8jw9m X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7006840011 X-Rspam-User: X-HE-Tag: 1687920279-167741 X-HE-Meta: U2FsdGVkX18gqj+/Nflg9+1AAQ1ecsaXCpSFEwV6oDV74IanVhfL+GV77bGydgW0//yXKkBYSULK4LCdnpP21ngEaxnpUhZWQ3mB/WMf1RiYn5u1K6PTNIxmtjPdJs7QTggcmNjrVyMwDEcv3c8hDjUegFkVOmsfj6htjQck5rsIXReRTQnJ4tHlcqjXuNgGTWTmohKY5qbhYsrqT8muc0TZNnN3+7OFLEKQqepZBskniE4Uyvf8ULQo/sFXPYggifxQmNdfU3o2l7sJfa5tfsetBBKsibczF3ISbB/j9Ja3RUFG8rMz6Ikbt7Gg/DJoNSRzO5DfeiRa7CKw7y9yF4A2LYzHvNaikgdkkMLKtE1YfmeMPQvARMrfM1M7JYRHPG4jyC/BHwgJLDzd+Eysj//8t5+JrhFu8TDprIEOTTuoNjkWfmf5N9gL+j1bJufSpvXT5yP6JI4kPtCjwHorXJJvBwEy6wWiZZ2nGjZHajMOM02l9IhljOQzpAs9RTmMGNHLop+6xY62bNKvgj9nNqHqW81OGs8vZ6p9OlUWYoAgmkkdIAvqXyl73d+gVa4+Ux+X9xM3mZ6t6/GfgIjbbJZhV7syGbAFwT664Fu8tJylsG9Q+QM9oNyNOQfKF1kmX6kkcauZlIf2OCJTlsZXpv7CZofUuSyaXoirSW0cAJnvssN4nPPV9clHPj3Idj9xTMUDjxCzaoXl/2WygsoA6K1uynqesfMCMVkxbidnFtoWktYd4xc2SRk0layaKzd6gkVeUyVhcHEndyDElDSoKUI74eEzClFQxMb9Mqclct/E+B/dYjKMuRFSl8jLh/O4Tkke7W4rEVFt2QlNgPKh7h7NWrLmn9HviKxTJZH+S+lrCd1t3fUWbP3Fgrwxhedrb7VVtGv3dG5GDL2E9gUvm1OSnfvex1MBzNTWj32RHSUVee/qk3KDca0993/tmNWvWLd4/zk8l8b5uCB/JxT brMNvnAi qBa0S+DfrI2wDaTLTVWu8PnPJvV6khXPuBL4DBNxhaf3W84CovhFPRxR1SxJn9+eXhtvm2owFgJFybXMZRrgT5Fp6ZQ/HefhAo45fVoqoWYwGDCvoc9yx4iJDS/m9Nqb1+7qbePQ9aEr+FrauhpatF7RCyA46profrtbEMj1T15MIfVACjR7TzNu6WuroRb6k6cZgG6waO6Gm9PI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/28 3:22, Andrew Morton wrote: > On Tue, 27 Jun 2023 21:35:42 +0800 Nanyong Sun wrote: > >> Since the ksm_merging_pages information already included in >> /proc//ksm_stat, we can delete /proc//ksm_merging_pages to >> make the directory more clean, and can save a little bit resources. > Well, this is a non backward compatible change - any userspace > which depends on ksm_merging_pages will break. > > Yes, we could remove this but it will be a lengthy process involving > emitting a "please use ksm_stat instead" message for a few > years before removal. > . This interface was just added last year(Apr 28 2022) in commit 7609385337a4 ("ksm: count ksm merging pages for each process"), it does not have historical baggage. Additionally, as stated in the commit message, this interface is mainly used to query the deduplication effect of the application for the upper application optimization during the development phase, so deleting it would have a very small impact.