Re: [PATCH] vmscan: fix zone balance check in prepare_kswapd_sleep

["Hillf Danton" <hillf.zj@alibaba-inc.com>]

On February 05, 2017 8:46 PM Shantanu Goel wrote: 
> 
> Hi,
> 
Would you please reformat your patch and redeliver it after taking a look at 
files like 
	linux-4.9/Documentation/SubmitChecklist
	linux-4.9/Documentation/SubmittingPatches 

thanks
Hillf

> On 4.9.7 kswapd is failing to wake up kcompactd due to a mismatch in the zone balance check between balance_pgdat() and
> prepare_kswapd_sleep().  balance_pgdat() returns as soon as a single zone satisfies the allocation but prepare_kswapd_sleep()
> requires all zones to do the same.  This causes prepare_kswapd_sleep() to never succeed except in the order == 0 case and
> consequently, wakeup_kcompactd() is never called.  On my machine prior to apply this patch, the state of compaction from
> /proc/vmstat looked this way after a day and a half of uptime:
> 
> compact_migrate_scanned 240496
> compact_free_scanned 76238632
> compact_isolated 123472
> compact_stall 1791
> compact_fail 29
> compact_success 1762
> compact_daemon_wake 0
> 
> 
> After applying the patch and about 10 hours of uptime the state looks like this:
> 
> compact_migrate_scanned 59927299
> compact_free_scanned 2021075136
> compact_isolated 640926
> compact_stall 4
> compact_fail 2
> compact_success 2
> compact_daemon_wake 5160
> 
> 
> Thanks,
> Shantanu

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>