linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: 민찬호 <chanho.min@lge.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: 'Jens Axboe' <axboe@kernel.dk>,
	'Wu Fengguang' <fengguang.wu@intel.com>,
	'Andrew Morton' <akpm@linux-foundation.org>
Subject: [PATCH] mm/backing-dev.c: fix crash when USB/SCSI device is detached
Date: Mon, 2 Jan 2012 18:38:21 +0900	[thread overview]
Message-ID: <004401ccc932$444a0070$ccde0150$@min@lge.com> (raw)

from Chanho Min <chanho.min@lge.com>

System may crash in backing-dev.c when removal SCSI device is detached.
bdi task is killed by bdi_unregister()/'khubd', but task's point remains.
Shortly afterward, If 'wb->wakeup_timer' is expired before
del_timer()/bdi_forker_thread,
wakeup_timer_fn() may wake up the dead thread which cause the crash.
'bdi->wb.task' should be NULL as this patch.

Signed-off-by: Chanho Min <chanho.min@lge.com>
---
 mm/backing-dev.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 71034f4..4378a5e 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -607,6 +607,7 @@ static void bdi_wb_shutdown(struct backing_dev_info
*bdi)
        if (bdi->wb.task) {
                thaw_process(bdi->wb.task);
                kthread_stop(bdi->wb.task);
+               bdi->wb.task = NULL;
        }
 }

-- 
1.7.0.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-01-02  9:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02  9:38 민찬호 [this message]
2012-01-02  9:57 ` [PATCH] mm/backing-dev.c: fix crash when USB/SCSI device is detached Wu Fengguang
2012-01-03  3:23   ` Chanho Min
2012-01-03  4:49     ` Wu Fengguang
2012-01-03 11:22       ` Chanho Min
2012-01-03 11:22       ` Chanho Min
2012-01-03  3:23   ` Chanho Min
  -- strict thread matches above, loose matches on Subject: below --
2012-01-03  3:47 'Chanho Min'
2012-01-03  3:47 'Chanho Min'
2012-01-02  9:38 민찬호

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004401ccc932$444a0070$ccde0150$@min@lge.com' \
    --to=chanho.min@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).