From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5DD9C77B7C for ; Mon, 23 Jun 2025 19:14:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A8376B00A6; Mon, 23 Jun 2025 15:14:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67FC46B00AB; Mon, 23 Jun 2025 15:14:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595A76B00C6; Mon, 23 Jun 2025 15:14:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4A37C6B00A6 for ; Mon, 23 Jun 2025 15:14:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 165A11D8298 for ; Mon, 23 Jun 2025 19:14:43 +0000 (UTC) X-FDA: 83587617246.14.640761F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 84324140006 for ; Mon, 23 Jun 2025 19:14:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bDs7gki9; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750706080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZncvHV48CZTvf0WGCYi+9lZbCWL0+Noe/kAfOSqrJbY=; b=HDcsJkt52wyjpk+/wt9kKD5ndz0qwLLBFQ8Dh28UHUOFxWVVO0iSliAKsx2fEAVykWj8n3 ORhGbWntSghIOCgzF7A0n5ivvNcrJzAUJTSASjFmtWAwOFnHvO1EOm1OYjvPnnaywNxn6s 52wUJ0/4cHIGXDuNIvANr+lc6XF1bfA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750706080; a=rsa-sha256; cv=none; b=YEPbdFAGhntJtQIo2GbZLDzrysg0bVd5ayl6zWuR3jJI3syhaccRr9ON3gtvlTgr3OTtKN 5HmmZIqg+zY7jBiThCiaRpp+KP8SBFK9G+it/5Hckd4Mh6IYibqFRsfh9Gx9k8w3+yQ6A/ ejr2R1BE4Wnl8cbZG1smvIIOMmJZesk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bDs7gki9; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750706079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZncvHV48CZTvf0WGCYi+9lZbCWL0+Noe/kAfOSqrJbY=; b=bDs7gki9t7DbA8mHT78TkH5xmcq/FiTw62bzS3LYF/zfSgvdGFVkGyVW80Kn+vQ3nKWYrx +ePw9jxNuCRxWG9wiAjV5U6W0nsxntfHKF6SZitvAlidVLp3Ux08Yt3esQErKYz/RfaRzm DGPiHHnnaPPYEj4K0WBuJUR5sKxaXbA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-Txx6KzkVO8iDqCEJ5sC8QQ-1; Mon, 23 Jun 2025 15:14:38 -0400 X-MC-Unique: Txx6KzkVO8iDqCEJ5sC8QQ-1 X-Mimecast-MFC-AGG-ID: Txx6KzkVO8iDqCEJ5sC8QQ_1750706077 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a523ce0bb2so2526702f8f.0 for ; Mon, 23 Jun 2025 12:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750706077; x=1751310877; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZncvHV48CZTvf0WGCYi+9lZbCWL0+Noe/kAfOSqrJbY=; b=KaV91Eaz/y9WdJaNfCWRwQuaHN5Iu1m+USu1lo/I/PGSW/GD1zLPps9O+TSLiXywhk I1v5AoilGdeP+L64HW8aoyGa0GhO3/46FNXPJRoHSp+O5eLY40/IK1rpY75rrErfILJc J2nlvpHIBRjinkjW+hT+kShRu8DoezRu8QBWvQj8etz16ve5fr2Pfe0zN2sW0AE5pt/2 1Emsz/K3rBWc9sO4O+3ymP2ddfR8CzrqYB86I5X2l864xCdSs2nJ5GVSSVKuwHvKcP3+ Zwg2i/l9tYKAd2NQkD702rOnZ3Om5sFt8jrjzakB71EpqTsTQ5K1XU+RgB66/4z070O4 kL/Q== X-Forwarded-Encrypted: i=1; AJvYcCXBtqe/MGjXiL3cbgMPBEj3uyApZbw+GctT+KunOpT12+EQAMOQCpiTgUEz+c6703zv6hVvRnFGdQ==@kvack.org X-Gm-Message-State: AOJu0Yz3PgY9xSkH5tz5abemQk8ZWjQYkRzGhXolgwpGhIfdWKb6FL6o NQ+l6jQ+PNP3AkKh0JjrVb//03pZUQqRXdCR93CC3ZWDDMXnnvuGKQ27I9BD7ydQClCy43VYGFC DEscWWN9dKKlFWu7SONKIaCAatYFXJn48kibQRKkCKIgznnONw6tD X-Gm-Gg: ASbGnctzG4y6Ijm956bW0T2ZL/luoNeem6qofKUzfsz8sy2N6CGRBL6lq7Sdhxi48Mw ZfBmYnXWZVvlBsgMO1nDvVGBbEXWvN4xcOy2nghxekbCU+fh1x66xGknj+ubdSOFiy6mOW3arLM qoulypjy6kbrcr27XrX5um95DvLAxW+zEyPNSeN9vjfDPM6yUQNuwc5kv+ogveUdWIhDfcE3rnJ 4+Qbx9sa3W0giyg3sWa8z7gSSCFTJPzGw+MVaOCxoNRjBRxIO4rPRqHc1WbY75Maag5GvzYuqRs DXsGVA4u2CG0YX5UAba4tSFM9jyQs74b5A+0WLx/nF4GYGytDDf/2ly+mgeyfa4F6kraNCyguc7 tUmvY6xWnPAYM3MIJs79hC/Qoyg2XLQKIK6V4eLzuJeJ4W08pAA== X-Received: by 2002:a05:6000:2108:b0:3a3:5f36:33ee with SMTP id ffacd0b85a97d-3a6d12dea0dmr8270709f8f.32.1750706077354; Mon, 23 Jun 2025 12:14:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFuCizsmYhYUTD1NUj/lBMAvTGdZZvueK/IAkU/saIe1x5K8UrHG1Xttc8M6Neprz0Y7hDjw== X-Received: by 2002:a05:6000:2108:b0:3a3:5f36:33ee with SMTP id ffacd0b85a97d-3a6d12dea0dmr8270686f8f.32.1750706076893; Mon, 23 Jun 2025 12:14:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f10138sm10095008f8f.3.2025.06.23.12.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 12:14:36 -0700 (PDT) Message-ID: <0067568e-a604-46d3-96fd-41b62968a90e@redhat.com> Date: Mon, 23 Jun 2025 21:14:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/2] mm/mempolicy: Expose get_il_weight() to MM To: Bijan Tabatabai , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: sj@kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com References: <20250620180458.5041-1-bijan311@gmail.com> <20250620180458.5041-2-bijan311@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250620180458.5041-2-bijan311@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XBpOZNZ1Ld2rTXCz2cMVFeuSEWqf5Hc0NbEMKu3K22A_1750706077 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 84324140006 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: x6zrnxp1hm67uubun3nj6i3ci1mpr3xz X-HE-Tag: 1750706080-931802 X-HE-Meta: U2FsdGVkX1/joPk4pclyCqLG3xI+TME7LgckB5fxYKzmKxvkommwaUVOFa0QU9OGHe6WWbmClncnyGx2vYJoMfMI9xqFRHHyYY+7dpKbXsaWFQaYIW7NCpLmP3NQprKw5MGQ4+ohzm1P+2CzJbaau6ULCHZWjdAQugAXB8xVzl6uuOgW8H4gq8pZIjwhjM8Oy/7QN/imxT46K9QjhNBYrYs6DOjxD6NmFqhnWeZIoD8RKPQgVlVqpbi/9fQvQAMWYsQYIXi2CPJdGWFUX3oN4rL58qOjLHM3T6aaazve6JzkMXoFOwLENQr6Vm1xQKwrYprXWlyoLsomOBBHq1Z2Z8uhTgx2EGlWfdp1t+ZVJHvneLl5fFBYBCscL+BmTeoFVdHw53mhyUen3GixR4IZQerth6Emzqm/0QnDUsgd3HnzH9F4ut7ECHygz9T3K1cMZKjDZnHIHG95aMDG/1o8g4sOAXAf/Y6wJcAUqiFD88ih97gNpIctQsWPhRnRFtm1AjA+eQn5/kXgfCslUJOuqDncuN6rKjYIj/Tk1Kgt29Tj6VZrUUANPwYaBKMXsg5CDZpPUv9UUYVxUPRTMn4BJUEqWt38qARFvlU/E2Gy3hGX8RXEnqE81F4P+qhSa4aIuDBqg1l0h0id1FXo3McgIk20d811LaiL/vukHh6BrurBTz4ZovsD2f/+x+g3EC/hhWk7nPqAnQZPnidrMKe9uxRtny2vOHMP0p/TzFyrmM7NANAuk7fYq81P7ZJziOE5+jFPKNX6znVzxRpv5b5O9HrvKHTyz9KKVdQnmR906cYacPd6iN0nWT9d/AYx3vlWCczT5bnmUzL6y+MJIF9a1V5g2OPqY8Uj+S7GODNL1rPhc3u5pSudpMikivk6hrgp5blANfb9/RtTdybsPTP3GT3TZRqcQ2dbo26yzvQL2TlzM0oTyF3DCFkdcwO1U730v1u3+P1csZMeRZEpvUo piSq8BZZ rHEqC17wqKf11N9UX7UuO0bdVgvH0SU8LhmwvKwQ8hMi6wzNyhsBb6ptKfnkDJWIDoFtU6PQ+xorCeBm9DJw4GPRaozHbmNKvnps12HjA2AW6jyaHmh3PlmR32Z49j61EE/zdrq6G1Ofvgiw5zwcKWuTagWUAPHyZkuN97cDxTCNeV+OdUi0Zcsju/4zH+uartjN/rpYujKpho/GRmGwdj2p+D64ha8Fa5/SfC+4BPqRz0W+Re3voAChxq+UF4lXOLc+xn7oiCR+KHA748qrEnBLwgvcuALpdxaLnNAI1H27RopfcTFrmvdQn32fx3zO6tGjhDJVU+sblw0fdmKtxHjCG90G0+vlRLNMvz/Qn06KfM3LivgoKdw754Zmn3E9J8y+wz8piM3Vn7ssVbM+YHkdtPr2QHM25tW3OavkMFGeadzVXfckRNrTv3BW5t/ovLeOztmsaueJEGN39VE37k2QvKd2v3rtbkns7HSpTQoASvyuRTAOmmFJTe39VkjmTIvn5n6lf+WgR0QvbAKObtti1GOsjQyYWFzP2OGGtPoVlQElq3Zv4gcNxd5yvxB9S2UN2o+5qJk65NQw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.25 20:04, Bijan Tabatabai wrote: > From: Bijan Tabatabai > > This patch exposes get_il_weight() in mm/internal.h. This patch is to > allow other parts of the MM subsystem, such as DAMON, to make page > placement decisions based on the global interleave weights. > > Signed-off-by: Bijan Tabatabai > --- > mm/internal.h | 6 ++++++ > mm/mempolicy.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 3823fb356d3b..b718ebe7cad5 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -1169,6 +1169,7 @@ extern int node_reclaim_mode; > > extern int node_reclaim(struct pglist_data *, gfp_t, unsigned int); > extern int find_next_best_node(int node, nodemask_t *used_node_mask); > +extern u8 get_il_weight(int node); No new "extern". It's a blast from the past :) > #else > #define node_reclaim_mode 0 > > @@ -1181,6 +1182,11 @@ static inline int find_next_best_node(int node, nodemask_t *used_node_mask) > { > return NUMA_NO_NODE; > } > + > +static inline u8 get_il_weight(int node) > +{ > + return 1; > +} > #endif > > static inline bool node_reclaim_enabled(void) > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 1ff7b2174eb7..b1713430ee9c 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -165,7 +165,7 @@ static unsigned int *node_bw_table; > */ > static DEFINE_MUTEX(wi_state_lock); > > -static u8 get_il_weight(int node) > +u8 get_il_weight(int node) The function name is shockingly confusing when used outside this file. Do we have some namespace to at least highlight what this is about? node_interleave_weight() might be a lot clearer? So maybe let's just rename it to something less confusing as we use it from other files. > { > struct weighted_interleave_state *state; > u8 weight = 1; -- Cheers, David / dhildenb