From: "Chanho Min" <chanho.min@lge.com>
To: 'Zhang Yanfei' <zhangyanfei@cn.fujitsu.com>,
'Andrew Morton' <akpm@linux-foundation.org>
Cc: 'Johannes Weiner' <hannes@cmpxchg.org>,
iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org,
'Linux MM' <linux-mm@kvack.org>, 'Mel Gorman' <mgorman@suse.de>
Subject: RE: [PATCH 0/3] mm, vmalloc: cleanup for vmap block
Date: Mon, 10 Jun 2013 10:12:57 +0900 [thread overview]
Message-ID: <006801ce6577$a50317c0$ef094740$@min@lge.com> (raw)
In-Reply-To: <51B1AD2F.4030702@cn.fujitsu.com>
> This patchset is a cleanup for vmap block. And similar/same
> patches has been submitted before:
> - Johannes Weiner's patch: https://lkml.org/lkml/2011/4/14/619
> - Chanho Min's patch: https://lkml.org/lkml/2013/2/6/810
This is exactly the same patch as mine. The previous two patches are
should be concluded.
> In Johannes's thread, Mel suggested to figure out if this
> bitmap was not supposed to be doing something useful and depending
> on that implement recycling of partially used vmap blocks.
>
> Anyway, just as Johannes said, we shouldn't leave these dead/unused
> code as is, because it really is a waste of time for cpus and readers
> of the code. And this cleanup doesn't prevent anyone from improving
> the algorithm later on.
I agree. This unnecessarily bitmap operation can cause significant
overhead as https://lkml.org/lkml/2013/2/7/705.
Thanks
Chanho Min
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-10 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 9:51 [PATCH 0/3] mm, vmalloc: cleanup for vmap block Zhang Yanfei
2013-06-07 9:53 ` [PATCH 1/3] mm, vmalloc: Remove dead code in vb_alloc Zhang Yanfei
2013-06-07 9:54 ` [PATCH 2/3] mm, vmalloc: Remove unused purge_fragmented_blocks_thiscpu Zhang Yanfei
2013-06-07 9:55 ` [PATCH 3/3] mm, vmalloc: Remove alloc_map from vmap_block Zhang Yanfei
2013-06-10 1:12 ` Chanho Min [this message]
2013-06-20 6:38 ` [PATCH 0/3] mm, vmalloc: cleanup for vmap block Johannes Weiner
2013-06-10 1:12 ` Chanho Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006801ce6577$a50317c0$ef094740$@min@lge.com' \
--to=chanho.min@lge.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).