From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx163.postini.com [74.125.245.163]) by kanga.kvack.org (Postfix) with SMTP id 0BCCF6B0031 for ; Sun, 9 Jun 2013 21:12:59 -0400 (EDT) From: "Chanho Min" References: <51B1AD2F.4030702@cn.fujitsu.com> In-Reply-To: <51B1AD2F.4030702@cn.fujitsu.com> Subject: RE: [PATCH 0/3] mm, vmalloc: cleanup for vmap block Date: Mon, 10 Jun 2013 10:12:57 +0900 Message-ID: <006801ce6577$a50317c0$ef094740$@min@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ko Sender: owner-linux-mm@kvack.org List-ID: To: 'Zhang Yanfei' , 'Andrew Morton' Cc: 'Johannes Weiner' , iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, 'Linux MM' , 'Mel Gorman' > This patchset is a cleanup for vmap block. And similar/same > patches has been submitted before: > - Johannes Weiner's patch: https://lkml.org/lkml/2011/4/14/619 > - Chanho Min's patch: https://lkml.org/lkml/2013/2/6/810 This is exactly the same patch as mine. The previous two patches are should be concluded. > In Johannes's thread, Mel suggested to figure out if this > bitmap was not supposed to be doing something useful and depending > on that implement recycling of partially used vmap blocks. > > Anyway, just as Johannes said, we shouldn't leave these dead/unused > code as is, because it really is a waste of time for cpus and readers > of the code. And this cleanup doesn't prevent anyone from improving > the algorithm later on. I agree. This unnecessarily bitmap operation can cause significant overhead as https://lkml.org/lkml/2013/2/7/705. Thanks Chanho Min -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org