From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF953C04A6A for ; Thu, 3 Aug 2023 11:52:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D10C28023B; Thu, 3 Aug 2023 07:52:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4802028022C; Thu, 3 Aug 2023 07:52:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34B0628023B; Thu, 3 Aug 2023 07:52:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 26FD128022C for ; Thu, 3 Aug 2023 07:52:21 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E8F901208BF for ; Thu, 3 Aug 2023 11:52:20 +0000 (UTC) X-FDA: 81082630440.27.3BE5096 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf24.hostedemail.com (Postfix) with ESMTP id E810218000A for ; Thu, 3 Aug 2023 11:52:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="KiVP/jJm"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691063539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BvfpzHNvraxrRTuqY8Qx7g7HYM0fDeaGxzfbp5eLMZY=; b=jVNJco2dORyX7kzOUuUQSQ/HoItLSfGg/VKhtt1kX8PUDyu0lC9Ptas671BGiybXtGOJZE Lnx3IoMafWTYOZMrxDpkXVf+Vwy4tmubIVSOS4+ZTA0K6elD37IPHbBU1H10Pkoocn4h2m pPmyeFKAbwWP999tMQvhkqQVL/0HeUw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="KiVP/jJm"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691063539; a=rsa-sha256; cv=none; b=0Ssyg/saNNBFSDDSU+zYLupC+z2bK5Ey8o0H/jpIhuRfdNFIB+pbmdjbcA5clc5aOA+SX9 iDhP3kC7UPIK0d+oxHuauS7xXvTJJX4dICwpte40HdK59zwuVSYrm89cT/IxymZYwsnsAB 6+R/SkFuTJWeUMGy0UaN2jCmvWXdHBk= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4fe457ec6e7so1539562e87.3 for ; Thu, 03 Aug 2023 04:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691063537; x=1691668337; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BvfpzHNvraxrRTuqY8Qx7g7HYM0fDeaGxzfbp5eLMZY=; b=KiVP/jJm3Mv4SHlqquH9+PvoWiGwU4w43ceFJW+SVvK1dooJfh1HtQVCCsJQst7wzj 191CRtHrTNxg7iyvORcNn2rvdqjIWavgBms97K9kq+ivY7hQBtW/gaNz7ofp6M4HmzDp DN9yCDbGGKmz3sasKBFiPHuKJsi7q4UTfEvnu7OtDbPzlu0GNWeat1z15W8VMrK6IgeF fukNf2GCSLYup8R12ZkJ91letJnvIZj0cOvIjwCJowcA9pf2qg0wwLpsUWhoRwraXB7b nPBtBqfrJwIl9MtUIf+caGzToRM49uz3+yMd49z6r0Z2LaPUC08ZW+V351CEdLPjMVui TSng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691063537; x=1691668337; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BvfpzHNvraxrRTuqY8Qx7g7HYM0fDeaGxzfbp5eLMZY=; b=UerM/DtoPMu1diJoe7Z6/zxPhfvXiO3yF069KD1fmpoHwFNNAOt+kOTpAmaMhtO4Fx 5OuJoCQ/x7DP1CB7Le1U/LGmsX9qAyc5q2hS0VrlVy8veAfX0q8Ph0nquFn+bS9cbhS7 UXj95AerGmLamB646fs3XhhZ8XvGMrANncsj59F/zW1Ojk+zkIXS3QlH0X8afkbTKGUo MWj4tSPJz/vlnMWpdAIawnBpd170MKs8GdsPlky/jVx6fH8fii97MYBa8706KMPU/6l7 cGCwQNG4oQFcNTNIp9u+TXvhb8qusrJAlfXA3y1oQp5/TC4m9/dhNrOJzOqByyhydYjM PmJg== X-Gm-Message-State: ABy/qLbwUUpGKIDGLmPwG8WkZBYu2hBoBQ6LHMTL+Nz42mKEfKu44Jn6 jUEjdIL7IHXr4WBeKn5dW+E= X-Google-Smtp-Source: APBJJlFCc7jU7XPSLQb+MCmbbcT8NiK3hMDPzGpNm10epcXYfUELg5To/dMsKpdwiHJYRmJAXj+7bQ== X-Received: by 2002:ac2:4d97:0:b0:4fb:829b:197c with SMTP id g23-20020ac24d97000000b004fb829b197cmr6396758lfe.52.1691063536736; Thu, 03 Aug 2023 04:52:16 -0700 (PDT) Received: from [192.168.0.103] ([77.126.7.132]) by smtp.gmail.com with ESMTPSA id lt5-20020a170906fa8500b0098f99048053sm10663624ejb.148.2023.08.03.04.52.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 04:52:16 -0700 (PDT) Message-ID: <006fc25b-497b-7de0-1d69-b7be66ab31b3@gmail.com> Date: Thu, 3 Aug 2023 14:52:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Content-Language: en-US To: Jakub Kicinski Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> <20230726130819.6cc6aa0c@kernel.org> From: Tariq Toukan In-Reply-To: <20230726130819.6cc6aa0c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E810218000A X-Stat-Signature: 757s5y4ep7pyjuss3dtm79g6xd9io7pn X-Rspam-User: X-HE-Tag: 1691063538-785760 X-HE-Meta: U2FsdGVkX1+cTXAZUf2BZ2Km737dk8Z424n5g8UHIGsYJKdy+i9Nd206SzG4nRncAsfi4C+zLYBNIQzDvpzP6P161J1ji0zMEe2z5dlAfBX0DZBRX8OpUcyhF7yM96ziK28O5Wr5e1ELlMa0+S/ZChtLQKhzOYdVeX/u2A5C+NaWy1VtixeyVQIbUHhQsJNS8juKS3szHHshAIahQ6U99Q15jvulL67fTFbjEQ1FRnX//+17OAV329NxPAwTESc4FMz/GacaM3eQJNkYi2SzJDoB3MeFJezQoq/9YgJR7/XYMWWM4G7pYIjPjdc3n8TOstPwQB2ia5yRO4IpzUEQetfC0n93yM1du5SfwPP8J1ySAu1tEZXZvRqONpVVj3xyVmKcrpU/fzeUFLmcyR21FDFA8QlVIbkS12c9rncqDgKG4quouNZGspQQ7JyZCDuGLlnawbv8M+lCAOOdg1PYvlaCug4jQpUPaitArOz4XYbhNh5oe8kOyeb8cq1FMe1Wn6S8jqRb4tuahk2NfYM1KpHgtIBCEEPZDEilDOMHjrjHuMT8+kAeeiMXVHfl/urZ3pQlNZjMDFt7JTaTuaSCNEAk33xNZVx9vSGh8lq3afDzda8jZtkBSv1+xpbfflLB7b2vj6XvCf21AUqOjHFL910+5VeCR1Lklo4VNpU6ndXHBLJOidXrAfi2RuFf6qITwSGaGg009ID4L8ReCO5ZMjBfoypH0w3YpOadMSM/WkUer2GTCVIJ2jzjJ2uZ6VWtLUcRWbW2g4DmXj/m98Atwt1xvSqI5ujHENJJLjmg9OBEDjAoHAJvC4Sh/GT1gK9bXo5D4mDd66aV55+elepRm7kqIbXEAQtBOzuiOMsCe4e2pPD6+PZbB5Tz5yQ8AB2J+HWR5mwTqFiMdHCrBKuYQ8/IKX5hbZXkck/Cy2jRtEv1dYCiW4WYbC5p0BexT4y53WN84bPiSbOg4QKqe90 exLlIW6d 73KuYzHlbIB/PNUAlq5lHZWNYVWGwC5meAofBPvBwTBRisRok6DKfNkpTeMGYEC9Dgmwt1g0WvP+w8B9VzC2AP5tnXWGEX9AtbQChpwR0tJLHeVLdoMkeSkQRon0YjM6lRSJuRJ0/YRJ9rK5RoBOzcUYKciuuZp+vyTPs/Xd7jHCijyGHv95G9IZvuapqB2I7Avd0yG6AtLKCUD4dzP/0x4m5Y/dyft1U5asyoTFKs87b4JILcrNua7BSNjI35rwYQXLeZvosufphuHiqgy54K7Hc+UWz3CHMR4PXSM0mWQmDHSBCr1Z55KFtxG/MFgJVW/QhcMcTllMBM0rkeCmocIwlSTRvohYezibaIZo8HYtR1lqMMrehQvsqhXITZT4EXicLXoXjj0J3zbsZqYoRhtlnk1DsgulTtHX/IplW55pxKx0J/v/a3bSgGB5uAz9DFvVd8Hz0MlyrmyNjt1tgtMPmDo6F2JCgZ3fzKnp3MPQxBlaKivd2zggOXZJOJ5fJzI8k1FD4S0mJ+HoM4F7rzamM1czyzfgXyZ4lePQ9frzxOVZrU6Sm0LF+XZpRVTMOjXhQDdGzHOttzwZf5eh2YsO757HxfX7FW3dB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/07/2023 23:08, Jakub Kicinski wrote: > On Wed, 26 Jul 2023 22:20:42 +0300 Tariq Toukan wrote: >>> There is a small bug in this commit, we should always set SPLICE. >>> But I don't see how that'd cause the warning you're seeing. >>> Does your build have CONFIG_DEBUG_VM enabled? >> >> No. >> >> # CONFIG_DEBUG_VM is not set >> # CONFIG_DEBUG_VM_PGTABLE is not set > > Try testing v6.3 with DEBUG_VM enabled or just remove the IS_ENABLED() > from: https://github.com/torvalds/linux/blob/v6.4/net/ipv4/tcp.c#L1051 Tested. It doesn't repro.