From: Dave Hansen <dave.hansen@intel.com>
To: "David Hildenbrand" <david@redhat.com>,
"Gerald Schaefer" <gerald.schaefer@linux.ibm.com>,
"Michal Hocko" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Jan Höppner" <hoeppner@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-api@vger.kernel.org,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Ways to deprecate /sys/devices/system/memory/memoryX/phys_device ?
Date: Thu, 10 Sep 2020 13:57:33 -0700 [thread overview]
Message-ID: <0175453a-7969-f482-a228-34c5840fe0e0@intel.com> (raw)
In-Reply-To: <21852ccb-bd06-9281-7c8e-485ec02f2883@redhat.com>
On 9/10/20 3:20 AM, David Hildenbrand wrote:
> While I'd love to rip it out completely, I think it would break old
> lsmem/chmem completely - and I assume that's not acceptable. I was
> wondering what would be considered safe to do now/in the future:
>
> 1. Make it always return 0 (just as if "sclp.rzm" would be set to 0 on
> s390x). This will make old lsmem/chmem behave differently after
> switching to a new kernel, like if sclp.rzm would not be set by HW -
> AFAIU, it will assume all memory is in a single memory increment. Do we
> care?
> 2. Restrict it to s390x only. It always returned 0 on other
> architectures, I was not able to find any user.
By "restrict it", do you mean just remove the sysfs file on everything
other than s390x? That seems like a good idea, especially if we don't
have any users. That, plus boot option or something to reenable it
would be nice if someone trips over it disappearing.
If there is a user, we stand a chance of finding them because they'll
hopefully get a good error message. Worst case, an strace will show an
-ENOENT and should be pretty easy to track down.
next prev parent reply other threads:[~2020-09-10 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 10:20 Ways to deprecate /sys/devices/system/memory/memoryX/phys_device ? David Hildenbrand
2020-09-10 20:00 ` Dave Hansen
2020-09-10 20:31 ` David Hildenbrand
2020-09-11 7:20 ` Michal Hocko
2020-09-11 8:09 ` David Hildenbrand
2020-09-11 9:12 ` Michal Hocko
2020-09-11 10:09 ` David Hildenbrand
2020-09-11 19:24 ` Dave Hansen
2020-09-11 19:35 ` Luck, Tony
2020-09-11 19:56 ` David Hildenbrand
2020-09-11 20:09 ` Luck, Tony
2020-09-11 20:49 ` David Hildenbrand
2020-09-14 11:24 ` Michal Hocko
2020-09-14 12:14 ` David Hildenbrand
2020-09-10 20:57 ` Dave Hansen [this message]
2020-09-22 13:56 ` Gerald Schaefer
2020-09-25 14:49 ` David Hildenbrand
2020-09-25 15:00 ` Greg KH
2020-09-25 15:05 ` David Hildenbrand
2020-09-25 15:39 ` Michal Hocko
2020-09-25 15:47 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0175453a-7969-f482-a228-34c5840fe0e0@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).