From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FE35C982ED for ; Mon, 21 Sep 2026 15:31:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 290F96B00D9; Mon, 21 Sep 2026 11:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 241816B00DB; Mon, 21 Sep 2026 11:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1582F6B00DD; Mon, 21 Sep 2026 11:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E3D3D6B00D9 for ; Mon, 21 Sep 2026 11:31:55 -0400 (EDT) Received: from smtpin23.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7E0B3C021D for ; Mon, 21 Sep 2026 15:31:55 +0000 (UTC) X-FDA: 85238159790.23.8DC0AB2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id C1271120005 for ; Mon, 21 Sep 2026 15:31:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=DoYlUaGs; spf=pass (imf29.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1790004713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HHp1Y73hUq5B5utgvxhoXXSaTrrz/7rdxoOs5y+VuXA=; b=A8YlYsys/LZCmUsaCQltMxcBd//9EU0LqJ/arY+ieuGdios0I9mYm5cKWBifVsxXwYUGdr JgF/ndQSZcB/BHM+OIRiujHYf9wpZMrZjhfi9qajAhWySDmMCy86LuQOjbUoCXZDplr9uz dLZ/SrDV3gpdFAruof33gth03rC/FnQ= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1790004713; b=282qaGyaj45fOnnD14yETJvLqe10kP4BPU8DseIq2MBw/5GxbormTYKC9IcJHTB30mxqDa +Xe6duASpr9HYNTxCCmdiYpvfQEPAgJAg7t0aQb6GvcZnPTDnWa2rfYEpBecwRIwV+x38a gKam8ENhqMIO30LYanFojRe+Lhlm4zU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=DoYlUaGs; spf=pass (imf29.hostedemail.com: domain of david@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4DC45601F0; Mon, 21 Sep 2026 15:31:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91E301F0089A; Mon, 21 Sep 2026 15:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790004713; bh=HHp1Y73hUq5B5utgvxhoXXSaTrrz/7rdxoOs5y+VuXA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=DoYlUaGsRjbuMIATX6w7VdNpQ2kCFEctbChQZ1OrjLUB7G7WWRpDdz+G46Xu7WoBo 3B3rgW72KEEYe2KH/o21b8zAHLwDdRlhCWCHG6//luNfl5SWvlrHk4mWOuqEPHP0g7 Ug2WmhDVUR5AYqagNEiLogi2BCcjGYO6TBPfJ4A+8mi7+uktSfX+koJsbMxnt9EM3J bBV3+lt5Y63dyKunlnM+dVjdpokLil2KCmxHPPlY29J75QDB8O6/sazjhaGvLuuKjI tToMo1ot64rbcEF0abYjY3glR9c+QWGhZ7E/tH5HFAb4zuIifEsv/osbfyTfKA4hUi vbKkOzWg7RaWg== Message-ID: <019c8f87-2e83-4078-8ecf-cd4eb4e73abb@kernel.org> Date: Mon, 21 Sep 2026 17:31:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro To: Yeoreum Yun , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Peter Xu , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , Shuah Khan , Jason Gunthorpe , Leon Romanovsky , Sarthak Sharma References: <20260921-fix_hpage_macro-v4-0-cdea4fc6ce3f@arm.com> <20260921-fix_hpage_macro-v4-2-cdea4fc6ce3f@arm.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260921-fix_hpage_macro-v4-2-cdea4fc6ce3f@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspam-User: X-Stat-Signature: a6or398dd6hkh5pomi9wzu8oqpzuu7pu X-Rspamd-Queue-Id: C1271120005 X-HE-Tag: 1790004713-657517 X-HE-Meta: U2FsdGVkX18doFvjzH3HqbUbyZ/xOnJVLUTKkX+ibLFf+z0fQBMIQFH+pXlvU7PZxJ8ALyrWSe0Ihw5urxHO8jGfQ+vvymK8b7IZewGW2B7kxoCqvRkxecG373YD8ggQ5bVqyYY78+agu2mtNKLJXu3gc1E9tojFwc90zQpE6Toh+3XGPwcnoj5kzfX9dX0uAApyUlJNt5hwqaUG48ct8ZmsSRFZrvkOFY1vv9zoVw3h7YNp5erX+cRrHau64HQNxc2hPK9Z+nV05/tgFD0jYTq1ZjsiRJgRHR7BdxOUBgZc21YIKUpnu2HXuX23yzSk+UWCB1wtd3ZA6H3QaVMkzydgVu4YGYms7i/e7vFv4qF1MyfjOjD7PduGjI17nBo303q11y7gGG05KTYbU/H/ITrVv/gtI93bAM4LsOFd9PKjMGzk4VG+MnMWc+Pzt9yIo50EKXEZfvDMJDkrKaybsvfvz8dKUSBr5YT2FLXrVY0ij0E8mBcTTegmYq/QoqIXUiK+NYwtUudKirHDiENWLS3k8nHIXwJFj9XyHis2/0/oti7dTIzm4Y3v3qFvgbj4oqp+h2B3/CnooVk3AssMLXjNaGcGVD1Kgt+b2Dt8wrLhAXd9RULZYLYz9n2aggPAhTG2Lk+RWryYuTaOYLFI6lM6EzVB1WJEi/OQsIMhVvD2GvrCWB72s9f1JXHrW3w3JYsprVr8kWVc5JNPW8/mUx3R9BvsIafsnlA303QY23sodb25ABaQDHVNXxT60syEyoUVUMTmpKYSj+GHLTrJEkqOIpiwOujzPgHU1AC0bxGij4Wd+gm/+M625ezu96qhZ0UICljd5QJP0iOgZLd1nNJxDyYDogkGwZL7dDwPyMa7/jmccp6dmCHrzbnoJEpByevqyxzSRyHPDqkcI+K/Af7F/T+xpEqcfa/CFKy/TYnBhDiC//YOT4qS1Fmm77dTxiezqnaCNNj3veDIyEp U7XA+GB2 UnWAdqQ4NBwrHmwkJOn7IQu1qxrdvpk7rWAdTROcC1YaEkgPaJtJvNbxFrl/1TE0L2A2WjeBPET7UnzGPMpFcfIyow+NB5opvtGI+HVs7A50sTXSLO9dsVJje/HF95NHzKkpcYpgQ+XWT1R2oF1Hl4jF1/AF/PQi+LA9GauUgShx2PoBOq2xrdPbA00pugq2CZrCZeKIxLqBRMYD0IjlbHwYIYdxMgvM5PpuaQdC8XbfMb9polxA50hhaTysQbbVP8rnUV9JxpG+X3GkuwUG+lx+5f5hb6I4i1+sLZ01UZ/fgWbePtc8OshKAX08ZlEduwN4vmzBfuk4D16N9Ts1GSK3zM+lAPUI5cmxMpAmioNKUHJV6fovY3faGw5SYRQk+xJ9svxoq1yV/NAF6hnTwIgoG7wnKvcF64y7E Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/21/26 12:36, Yeoreum Yun wrote: > HPAGE_SIZE and HPAGE_SHIFT macro is written based on the 4KB PAGE_SIZE. > When this macro is used in some test, test result would be strange in > the system where PAGE_SIZE is more then 4KB. > > Here is the example with transhuge-stress test with 16KB PAGE_SIZE: > > transhuge-stress: allocate 61073 transhuge pages, using 122146 MiB virtual memory and 1908 MiB of ram > 3.292 s/loop, 0.054 ms/page, 37106.002 MiB/s 2566 succeed, 58507 failed, 2566 different pages > 0.591 s/loop, 0.010 ms/page, 206850.792 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231895.107 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231839.704 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.528 s/loop, 0.009 ms/page, 231544.782 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.528 s/loop, 0.009 ms/page, 231462.074 MiB/s 0 succeed, 61073 failed, 0 different pages > 0.527 s/loop, 0.009 ms/page, 231770.300 MiB/s 0 succeed, 61073 failed, 0 different pages > ... > ok 1 Completed > > Remove the HPAGE_SIZE and HPAGE_SHIFT macro and introduce pmd_pshift() > helper to get the HPAGE_SHIFT properly. For HPAGE_SIZE, use pre-existing > helper, pmd_psize(). > > Also, run the KSM_MERGE_TIME_HUGE_PAGES test with a size of 512 MiB, > which is the least common multiple of the PMD sizes for 4 KiB, 16 KiB, > and 64 KiB base pages. Since allocate_transhuge() allocates mappings in > PMD-sized units, the test may fail with the previous size of 100 MiB, > which is not a multiple of the PMD size when the base page size is > 16 KiB or 64 KiB. > > After this patch, output of transhuge-stress: > > transhuge-stress: allocate 3817 transhuge pages, using 122146 MiB virtual memory and 119 MiB of ram > 2.558 s/loop, 0.670 ms/page, 47755.759 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.640 s/loop, 0.692 ms/page, 46268.432 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.635 s/loop, 0.690 ms/page, 46360.298 MiB/s 2585 succeed, 1232 failed, 2585 different pages > 2.782 s/loop, 0.729 ms/page, 43899.795 MiB/s 2616 succeed, 1201 failed, 2616 different pages > 2.692 s/loop, 0.705 ms/page, 45380.876 MiB/s 2627 succeed, 1190 failed, 2627 different pages > 2.612 s/loop, 0.684 ms/page, 46765.812 MiB/s 2628 succeed, 1189 failed, 2628 different pages > 2.683 s/loop, 0.703 ms/page, 45520.990 MiB/s 2630 succeed, 1187 failed, 2630 different pages > 2.727 s/loop, 0.714 ms/page, 44789.321 MiB/s 2631 succeed, 1186 failed, 2631 different pages > ... > ok 1 Completed > > Suggested-by: Lorenzo Stoakes (ARM) > Reviewed-by: Zi Yan > Signed-off-by: Yeoreum Yun > --- Acked-by: David Hildenbrand (Arm) -- Cheers, David