From: David Rientjes <rientjes@google.com>
To: Charan Teja Kalla <quic_charante@quicinc.com>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
mhocko@suse.com, david@redhat.com, vbabka@suse.cz,
hannes@cmpxchg.org, quic_pkondeti@quicinc.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/2] mm: page_alloc: enforce minimum zone size to do high atomic reserves
Date: Fri, 24 Nov 2023 11:24:28 -0800 (PST) [thread overview]
Message-ID: <01c81f6a-f090-a544-49db-ed9cd97ab8ee@google.com> (raw)
In-Reply-To: <c3a2a48e2cfe08176a80eaf01c110deb9e918055.1700821416.git.quic_charante@quicinc.com>
On Fri, 24 Nov 2023, Charan Teja Kalla wrote:
> Highatomic reserves are set to roughly 1% of zone for maximum and a
> pageblock size for minimum. Encountered a system with the below
> configuration:
> Normal free:7728kB boost:0kB min:804kB low:1004kB high:1204kB
> reserved_highatomic:8192KB managed:49224kB
>
> On such systems, even a single pageblock makes highatomic reserves are
> set to ~8% of the zone memory. This high value can easily exert pressure
> on the zone.
>
> Per discussion with Michal and Mel, it is not much useful to reserve
> the memory for highatomic allocations on such small systems[1]. Since
> the minimum size for high atomic reserves is always going to be a
> pageblock size and if 1% of zone managed pages is going to be below
> pageblock size, don't reserve memory for high atomic allocations. Thanks
> Michal for this suggestion[2].
>
> Since no memory is being reserved for high atomic allocations and if
> respective allocation failures are seen, this patch can be reverted.
>
> [1] https://lore.kernel.org/linux-mm/20231117161956.d3yjdxhhm4rhl7h2@techsingularity.net/
> [2] https://lore.kernel.org/linux-mm/ZVYRJMUitykepLRy@tiehlicka/
>
> Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com>
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2023-11-24 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 11:05 [PATCH V3 0/2] mm: page_alloc: fixes for high atomic reserve caluculations Charan Teja Kalla
2023-11-24 11:05 ` [PATCH V3 1/2] mm: page_alloc: correct high atomic reserve calculations Charan Teja Kalla
2023-11-24 19:24 ` David Rientjes
2023-11-24 11:05 ` [PATCH V3 2/2] mm: page_alloc: enforce minimum zone size to do high atomic reserves Charan Teja Kalla
2023-11-24 19:24 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c81f6a-f090-a544-49db-ed9cd97ab8ee@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=quic_charante@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).