From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83351606A332 for ; Mon, 16 Nov 2026 13:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=ODKhTewZ Received: by kanga.kvack.org (Postfix) id A58DC6B05B1; Mon, 16 Nov 2026 08:35:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A094D6B05B2; Mon, 16 Nov 2026 08:35:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F9346B05B3; Mon, 16 Nov 2026 08:35:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6598C6B05B1 for ; Mon, 16 Nov 2026 08:35:07 -0500 (EST) Received: from smtpin19.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7EF5806B4 for ; Mon, 16 Nov 2026 13:35:06 +0000 (UTC) X-FDA: 85441078212.19.84A86EC Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf12.hostedemail.com (Postfix) with ESMTP id 62AA940005 for ; Mon, 16 Nov 2026 13:34:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ODKhTewZ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1794836105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VTdh+RQXIjKegFBkHqeV/SunRho35ClvmITrODAwJgE=; b=2vzGHEbT2WUdxx1qUtG2gaV5ev4eHEqpPBhk3WTuDjMZcYNSqH9F0YkPC+D8VclFBDatBk b8H55fvIDmqT5XrDvKPWpV1NoZ7IWrY4ao4NM7Xeyfp3TPqlSihMvoDg6wMAjOuS3KIoi2 wG48VTDq9wedfSeqccuLBT0eSLJmTLs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ODKhTewZ; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1794836105; b=Lg3kyHMmPOsIBWDRXOq+ZXOtcSPcpflkPZ2GWZ7ulhIj8/NaFkY7zvhI99+uYCsEaZFeIb SiNJg2MuMmirHgH7HElR2nQlli1i8Oho3WN7w5M0eKjR//eboTamDfhspudfeQM1IJeboG 35a3IiTBw95ngU9MmcbuyYNROBRxg6o= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1794836096; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=VTdh+RQXIjKegFBkHqeV/SunRho35ClvmITrODAwJgE=; b=ODKhTewZERc1NGVZvep3c5vaMLOOzI/ARU7ajdvzjHuYHRTRkvFl+ezcIekIsMGwXeJMZHDPqXWQ02PzHKSSIh5mOoFa5b66kcpQgWAnJbh/AexJHkpqgdmbnB30nn9K8jwvofIzQk5/kfFoF5CT5Z9gEmyWwcwAke2pIkzvkMU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R651e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037033178;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0XEtLy1f_1794836094; Received: from 30.251.68.229(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0XEtLy1f_1794836094 cluster:ay36) by smtp.aliyun-inc.com; Mon, 16 Nov 2026 21:34:55 +0800 Message-ID: <01d59bbc-46d4-4da2-805c-bf540d50eb37@linux.alibaba.com> Date: Mon, 16 Nov 2026 21:34:53 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: synchronize with PTE table reclaim for all folio sizes To: "David Hildenbrand (Arm)" , akpm@linux-foundation.org, ljs@kernel.org Cc: riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, qi.zheng@linux.dev, pfalcato@suse.de, ayushr@modal.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <16bb1a14-04f4-4524-9882-20d452175a3d@kernel.org> <9e66d5f7-ee81-4204-8d62-b06d26a00623@kernel.org> From: Baolin Wang In-Reply-To: <9e66d5f7-ee81-4204-8d62-b06d26a00623@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 62AA940005 X-Stat-Signature: bf1gndxrtiitgrztk6mdi9x7zs1io8ft X-Rspam-User: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=4.0.1 X-HE-Tag: 1794836098-713773 X-HE-Meta: U2FsdGVkX1/nHxLBUE0oHaX6mHthF/zkW/rW62yUTz4JmKC56zoQrU39Ha7o+bOlMPzsdBgnIps4VlYE+nzhqys/ay6cYET5pR/RRM9xXsO4dwImD5GPpiDkQgiWFh1RcZhEFVihzkKIspZQpPchFUaUYdGIMvSXNigvCUzv5Yi8rI3O6EEYl7ydyIUPqTiq2iOmk+ZOc+bj1IyZjSK9NyIDe1+vxLpnOi22R3L1JGOgh+Mx0EoCaXTdQytO3ieHM6ADYuQso1C+MnnRBZ7E4IDpem7zrRltJP/UWVvv+VElog7cpF1sMRygz3cTlu7sz8s/m/G32eSekjETh69AaY2ZLFjctF9hCSiT8FV53U8p+a2TgiDZdUvndyNzvwDix+v73UaoxKILh9rRczODNWnvE+WRaOCAvqWdE2ta7ADVON1MLe0h0rNROeN1CAzIhK2hfCFQATDzg6PWd6pp46WrE7+s/m5d74FXcIjajqzIAvpo7nk8hVsafvuf2ef9B1iamM+genLoTIa8vY0O52Z/Fmk8kOJ11qTgR8hhGCkZOX7c/Rlf/YwKeqP8lfDpNkKklcTFGooJeal4Q3ydnqykqDd4qOooO7yACehqiCbgMYq0sLFlADteOLxAmRLvMjcEK20jtaN0JvjnLvT2PPfBUCi4AfRoqd4d5vwmjIWWWKTmkZs3Cv1AMTe181FMhiUlg9PtsxTmg18C7cnZ90ZuRAFMH3ajP9tl5dmHFP6Ciz9fiNO6fGhT69tvTb8dJMHpNUxncYVsHAz8T5S9w6pMHDEmrmDQRf6wTDEm6I0xmSR713vUl058naEHzuoMQm2iGf3SJ5YPGj062wmPZwtYGj/mFdKmOl8jJm0f7wgxJcxbc2IZ8nP3j8qm1lJ7cSG8dKfQvZZBEgnzpJI/6nMapx0eJBdJu0JYJ4PgkhFt+3R9YAbniSUZWlMAbkPvkivpFVeNS5tM+lzCeJF 9FAKuyLP jCdeZss80FVODgE+pA9NvY4gcNLSNG8Pynck7CSC1DuW5gdXBSkiukqUAtUsxWNIlwa7p4RC9tCcNqzic2GrbRGBWJ/9T2xEWvToUU8pWrgix0WMvUYpr9hyXXcB3p69cU5po+sj/sxFkr8h8FVUvI2+JCRd1Capfjkr9ZUcmunAYbX282Vw3KUBIQ/EbsSF7qGqyS4ba9uvyJ8e1+yarKaUzJr5XSqxQz6HXw7Tr02gFfBXTXLdYCG33j0WocQAZLsi5FQVs4z147VO5C2wocT+898YLK4/mlOg8UCsfGelLl1AJ+pSuw9U1sgA7zGhinAL+dNs0pQO53XM= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/16/26 8:03 PM, David Hildenbrand (Arm) wrote: > On 11/16/26 04:44, Baolin Wang wrote: >> >> >> On 11/14/26 1:39 AM, David Hildenbrand (Arm) wrote: >>> On 11/5/26 03:56, Baolin Wang wrote: >>>> Similar to commit 243cf1f67b36 ("mm: memory: fix truncation removing mapped >>>> folios"), the '!pmd_present()' check in page_vma_mapped_walk() can also race >>>> with concurrent page table reclamation via zap_empty_pte_table(). >>>> >>>> page_vma_mapped_walk() is used by many functions including try_to_unmap(), >>>> try_to_migrate(), folio_mkclean(), pfn_mkclean_range(), remove_migration_ptes(), >>>> page_mapped_in_vma(), and mapping_wrprotect_range(). Except for try_to_unmap() >>>> and try_to_migrate(), the other callers do not perform post-walk accounting >>>> checks, so the race has no observable impact on them. >>>> >>>> For migration, the race can cause unnecessary retries. For reclaim via >>>> try_to_unmap(), the race can cause failure to reclaim a folio that is in >>>> fact already unmapped (as shown below), which may lead to unexpected OOM >>>> or increased refaults. >>>> >>>> CPU 0 (reclaim) CPU 1 (MADV_DONTNEED) >>>> -------------------------------- -------------------------------- >>>> folio_lock(F) >>>> try_to_unmap(F, TTU_SYNC) >>>> zap_pte_range(full PMD range) >>>> spin_lock(ptl) >>>> clear PTEs >>>> zap_empty_pte_table() >>>> spin_trylock(pml) >>>> pmd_clear() >>>> spin_unlock(pml) >>>> >>>> page_vma_mapped_walk() >>>> observe !pmd_present(pmde) >>>> nr_pages < HPAGE_PMD_NR >>>> skip synchronization >>>> return false >>>> >>>> try_to_unmap() returns >>>> folio_mapped(F) == true >>>> nr_unmap_fail += folio_nr_pages(F) >>>> tlb_flush_mmu_tlbonly() >>>> tlb_flush_rmaps() >>>> remove F's rmaps >>>> spin_unlock(ptl) >>>> >>>> Commit 243cf1f67b36 ("mm: memory: fix truncation removing mapped folios") >>>> has already moved the PMD clear operation (via zap_empty_pte_table()) to >>>> after tlb_flush_rmaps(). Similarly, page_vma_mapped_walk() also needs to >>>> use sync_with_folio_pmd_zap() to synchronize and avoid memory ordering >>>> issues on weakly ordered CPUs. >>>> >>>> Fixes: 6375e95f381e ("mm: pgtable: reclaim empty PTE page in madvise(MADV_DONTNEED)") >>>> Cc: stable@vger.kernel.org >>>> Suggested-by: David Hildenbrand (Arm) >>>> Signed-off-by: Baolin Wang >>>> --- >>>> mm/page_vma_mapped.c | 5 +---- >>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>> >>>> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c >>>> index e6b6170c2f4f..8797467b6f0c 100644 >>>> --- a/mm/page_vma_mapped.c >>>> +++ b/mm/page_vma_mapped.c >>>> @@ -293,10 +293,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) >>>> spin_unlock(pvmw->ptl); >>>> pvmw->ptl = NULL; >>>> } else if (!pmd_present(pmde)) { >>>> - if ((pvmw->flags & PVMW_SYNC) && >>>> - thp_vma_suitable_order(vma, pvmw->address, >>>> - PMD_ORDER) && >>>> - (pvmw->nr_pages >= HPAGE_PMD_NR)) >>>> + if (pvmw->flags & PVMW_SYNC) >>>> sync_with_folio_pmd_zap(mm, pvmw->pmd); >>>> >>>> goto next_pmd; >>> >>> Baolin, how to proceed with that? Are you intending a resend? Including some of >>> the performance impact and ways forward to optimize? >> >> I hope we can merge this fix first if no other objections. As I replied >> to Barry, whether to set TTU_SYNC for small folios should be done in a >> separate patch (this is a pre-existing issue) with proper measurement >> (though it may be hard to measure the actual impact). What do you think? > > Can you update the patch description to include some of the performance aspects > and planned next steps? Sure. However, regarding performance aspects, I'm not sure what kind of testing you expect. Since this fixes a uncommon concurrent race, do you want performance data under that race condition, or impact on common paths like try_to_unmap/try_to_migrate()?