* Re: [PATCH] lib: test_hmm: Use min() to improve dmirror_exclusive()
[not found] <20240726131245.161695-1-thorsten.blum@toblux.com>
@ 2024-08-01 9:33 ` David Hildenbrand
0 siblings, 0 replies; only message in thread
From: David Hildenbrand @ 2024-08-01 9:33 UTC (permalink / raw)
To: Thorsten Blum, jglisse, akpm; +Cc: linux-mm, linux-kernel
On 26.07.24 15:12, Thorsten Blum wrote:
> Use min() to simplify the dmirror_exclusive() function and improve its
> readability.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
> lib/test_hmm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/lib/test_hmm.c b/lib/test_hmm.c
> index ee20e1f9bae9..056f2e411d7b 100644
> --- a/lib/test_hmm.c
> +++ b/lib/test_hmm.c
> @@ -799,10 +799,7 @@ static int dmirror_exclusive(struct dmirror *dmirror,
> unsigned long mapped = 0;
> int i;
>
> - if (end < addr + (ARRAY_SIZE(pages) << PAGE_SHIFT))
> - next = end;
> - else
> - next = addr + (ARRAY_SIZE(pages) << PAGE_SHIFT);
> + next = min(end, addr + (ARRAY_SIZE(pages) << PAGE_SHIFT));
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-08-01 9:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240726131245.161695-1-thorsten.blum@toblux.com>
2024-08-01 9:33 ` [PATCH] lib: test_hmm: Use min() to improve dmirror_exclusive() David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).