From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9003BC3DA64 for ; Thu, 1 Aug 2024 09:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23CB76B008A; Thu, 1 Aug 2024 05:33:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ECE06B008C; Thu, 1 Aug 2024 05:33:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08E176B0092; Thu, 1 Aug 2024 05:33:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DAC0B6B008A for ; Thu, 1 Aug 2024 05:33:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9EFB61A09C7 for ; Thu, 1 Aug 2024 09:33:27 +0000 (UTC) X-FDA: 82403163654.13.9728FCC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 535EB180027 for ; Thu, 1 Aug 2024 09:33:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="QdWY0r/n"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722504763; a=rsa-sha256; cv=none; b=Dy6geOQOtJyLZIZZE9uby6T7EMSABs7P5tUf+g0JwQxJfESRW3n7zOOQAeSoJnVUqCQPyP hiPRoh4Z4Pl9lYrsZe0N5IJkPm64uF1PZ64e0UnLOZ4u08QZdNBPwAgSehjUA84n1FjyWh zdNf+XXSVzmHj3okiFpXujRFnvBpKxg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="QdWY0r/n"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722504763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sLXqfsBH+7KyNG7/uuZi6mautKAwsxhIgQaoMiRA1p4=; b=g3fXQ0VrctGq3qQ3Wrh7m3RM5mVNEpHbxDeRbkAC+MSWQ1xOH14Xo89SXlN0M+H5hNqAwX GEsG8lqq3IcRC6+U00kyDTwqx9ofbY2fft3MuVul9jTTA5w9odNsXInIz44/VamQNXY2mD s1t+bzGW8MkSv87ac7gKMX/T69YTCwE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722504804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sLXqfsBH+7KyNG7/uuZi6mautKAwsxhIgQaoMiRA1p4=; b=QdWY0r/nDjdKPIE0ySmPz884n+9JYiM6/p9qfWyRLjsrUoyNB8DdCeJ4JH7/bL7a+NTz4w oYtGgtGg2Mi0WQnUbcwm4374ooQv4fsYseLwL/GixQV94oH8MgS24rLv/IsTxxbguS//3h OVaXnVhhJclgxOSFnkAR/ybLtMoi/cc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-AavS9-sRPn-r23TjsAGUUw-1; Thu, 01 Aug 2024 05:33:23 -0400 X-MC-Unique: AavS9-sRPn-r23TjsAGUUw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-369bbbdb5a1so970883f8f.1 for ; Thu, 01 Aug 2024 02:33:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722504802; x=1723109602; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sLXqfsBH+7KyNG7/uuZi6mautKAwsxhIgQaoMiRA1p4=; b=lJcOervZIIbx7k96kAINnj9Z+WwVHnenJlwRnRbK2mkPRWbEY+HeAgP0wGgWZdkr+i nWryG4PZt2wSknBgI9zcbE3hwdoH3Qs1Vt0QK+KaPWSoQkFJe+3UBjbdYOLbae3VZMrP wya1Y46zudCQHF9GCatBWHDnzG3kTrrdf24ci1lmXLl5r27VJErxiRYD6W7CfG/5ksU3 zw+luw4GYq3FAajClirWjUelMO54xinyQ6XY+yyxKIjBgqTwDpsjsryqH+oEmR6I2npv teeVhnAur9lvDKukoNPnISC1PxH1W9KpUa52lS/PZnKNFsrM137qLOnIcpqquWqbZ1EP Xq7w== X-Gm-Message-State: AOJu0YyDXnR8VKG9YPv07GanTdh45YCUmMNpFekPT1vsy4OYz208rSsv 0BbA8JxAE5+uuuuaHWTCbr9zlVUAk7/YtnvYIv9VdQ9JpsIk8O+Cx6979TeICsfKtQq77azTyF4 nLjU7dkAgQX45UHotgyJGWIBVUvIVbJ2A75vORMx1q1SEpyXo X-Received: by 2002:a05:6000:144d:b0:367:895f:619e with SMTP id ffacd0b85a97d-36bb359d1camr815771f8f.11.1722504801993; Thu, 01 Aug 2024 02:33:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/heK2udYQw8AV5R+mx/dv56mwC6hCjVhpsvhsrfIylOeKjaFuFUQERaFi7WvrnS7oyxE4Wg== X-Received: by 2002:a05:6000:144d:b0:367:895f:619e with SMTP id ffacd0b85a97d-36bb359d1camr815749f8f.11.1722504801549; Thu, 01 Aug 2024 02:33:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bb6405csm50737225e9.34.2024.08.01.02.33.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 02:33:21 -0700 (PDT) Message-ID: <01e36e70-4e3e-464f-a14b-57a892b07f61@redhat.com> Date: Thu, 1 Aug 2024 11:33:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib: test_hmm: Use min() to improve dmirror_exclusive() To: Thorsten Blum , jglisse@redhat.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240726131245.161695-1-thorsten.blum@toblux.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240726131245.161695-1-thorsten.blum@toblux.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 535EB180027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wdtrrcm47rb3tbyuh5gzow6z6ob6e4i1 X-HE-Tag: 1722504805-75582 X-HE-Meta: U2FsdGVkX1/sNiLXRGxWiUT8C8r8sNuRqvp8NnADZJGKjC77Hhe4XQLYYRLw/M6bcGpN2uNFstMESOMorSdzNiX+0odUCNjip0KN0AM2s3SimJzZDD3hlCvL7wW0NgxNWgoVilYbxAPxgmDH+z5t997kozDBEgzxE23ZFtzHv1h7akB7Q94GQji0H//sFe8/02dt1g0V6QRYH1AS5ArkKs+Fft3dOMM8DD8UP3ROmgRLV6NMXAm7CyHpbxuk6gzZIPFRD7/c/QBR0XH2CGKQWYNJgYyIMM6WFKKg4S2C7CMVoDaxcFOMsL8bD1npoym7DuHSoB9WyVJztgDb2r6W9YJhO61fNQ+jgmPzY6b7iVUTxOPRFwq706hstfM/Cfs0A6A+9OelOKBGNd6+G4Glhz50Ts/iXP54Jx3bQD1yXFl5hdxFilFS5dIH7msA8Y0vgZxBzVlQ21Zjd+su+27O0A0vr8dVkTX/KsQtg4yFGc6zcmEViA00e+oRmm3Zq0tZcTGQx6pOd4GP9xCDLi1zVes7gK5xUZhiucA4beIuhd/TLgpVluCbeOgI9rmfO49TWvJyR+0Eg4lpL+Vo2fTCW3GwvDfV215TdXKzwmUri+tOzzmY4Ya088zRHP8ieizwRTP3vKbTyFgItT7ZKVigS8GJeLunBHSbgaA0zZZgSsUrfzaBUt9qva3MVowzkoP6NxRDXKIXco0j+NOjQjHlW8fdSS5g/L9yUW2WjNiIU7EpaSifqXQM+wo7jF7O+1GlH2j889oFHBiybK+lE6J2w0E4kwSpZX3F5Zy0W6sCJOtaPnv9rNEVbYn5MfNYnw7E3xLZwDvHiO9IrpelELp79RKP9uT2VBjgSjQk4m+WVa+9HPYWchFZfOVjrVQz2x/8h4R4KVV0FbgGQJFLB0g+nftZtitVhc1aGzxSAaUa5XQR3PZ+myscYbqLKgcYwHJaPjpOwGKUOOJnhcyZ56n NyVBtaDm jeSMw2poiVrPdukIeyQUpAmS1YWOzWK7KITaNgGNMZqiEV9ZNSl3mD1f9GI4ndTZmT6g32g9j6R9mXoH6hsqh/wNGwvMBI8tu6uBe4Mu2CcCsAkDzAZ7sI9rMXAgt8V3OrEZz/NoQKVoIaFu4br4Nw3HgxKdgmxFAhdlB8HS2JkMX0eXiJpmVBxzyUbKsyny/YHoaDlsIHM+uFfF5h/8zEGPegfx+lxaYkTjNZKKAo2ybi5P2LLzYkgzOd2GramwYYQCXpz9ODFX4BJcYiZwwYs/ENBGinRureTM3IPWwr9ImrlgPamNkC4zDi5LWnWRHZ+zmSqvyN8cgfTGnjWJBYwNzjnnjKFQktad7mB/S+NiPXt/wqn2XlRtXdel2iXYxZ2lIOmf1kSmLR+3VqhuiwzSPmmSk9iDey30FoKcXqaRA34fuJ3bI/Hc3Wq6Mv/uEtate89YF1vHaBdL+ONkrnb6fxDPZb+1LgjH+j1vhKDS9KNp50JaKkjcTnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.07.24 15:12, Thorsten Blum wrote: > Use min() to simplify the dmirror_exclusive() function and improve its > readability. > > Signed-off-by: Thorsten Blum > --- > lib/test_hmm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index ee20e1f9bae9..056f2e411d7b 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -799,10 +799,7 @@ static int dmirror_exclusive(struct dmirror *dmirror, > unsigned long mapped = 0; > int i; > > - if (end < addr + (ARRAY_SIZE(pages) << PAGE_SHIFT)) > - next = end; > - else > - next = addr + (ARRAY_SIZE(pages) << PAGE_SHIFT); > + next = min(end, addr + (ARRAY_SIZE(pages) << PAGE_SHIFT)); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb