From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243C3C41513 for ; Mon, 24 Jul 2023 12:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25F86B0075; Mon, 24 Jul 2023 08:17:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6BC8E0002; Mon, 24 Jul 2023 08:17:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C5016B007B; Mon, 24 Jul 2023 08:17:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E1E66B0075 for ; Mon, 24 Jul 2023 08:17:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47D1D80A01 for ; Mon, 24 Jul 2023 12:17:48 +0000 (UTC) X-FDA: 81046406616.06.6EB22F6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 57A18100025 for ; Mon, 24 Jul 2023 12:17:46 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lFo5/uyf"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690201066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xzLHOlmF+CIoF0WI8Vm/YOZazXEsf4Ui2aFePuMd4C8=; b=p9K4ZyNLQ3J78t3AnnpOJFH9YFHT4xDlzf6mQZFLkRRxJJHkYcwSwXhQxLsadIa4DuwnM5 KvKQkGEnMmkFiMsEq2/3htGgrvP0udbYUatYr9W/fTB615vfXlNf0gIIVtb89+5s7pbG2r cOMjvRW1cuPnvqBsVqKT8jTKhhjvCSc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="lFo5/uyf"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690201066; a=rsa-sha256; cv=none; b=0DFScM9LOJw9cZNd5wmQYffDxzlNDdvyTi4PK++e/elwR9QwUsv9Y9OyUaWPAwTyO8flWR 3ryFTVnBdUcXwhkui0GbbfstnPf5iFoHgopFUHnl33T6nijXwpSaswz5wBIremSaWhjzSp HCydkbX7nZqfW3lF2012rqyHbypAdHc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21BA160F6A; Mon, 24 Jul 2023 12:17:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE84DC433C7; Mon, 24 Jul 2023 12:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690201064; bh=QrEpSq7cPtZ3cWIhHPElPK38cx6jwtPbdBU+j7U7fKM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=lFo5/uyfnIZhAXSNnfYH/zs0wLPvsdGmMHFPu1gPwZUyuOP10nfFnm2e23E9mVHox RPTdsfQNauiU49m1hBahLSzV9+gtG/J7umAiMCAj2AameE5Kr8rrBCOJ9W6HPjIMkc lBp1NfEAIBufJmTKwy4+ZdRStOdLezK2HhFQXgRbYXDnNec/zH0oZOEiZUwOk3URR0 CwbOA3I9uES6cdgV2JXRUz8O/MvIwDzgSFlH2Jg5PAfwuqtmwK87bHc16vNtVYlbJG hfzmJLudml4J90E2WDeTwJcjuLZaZewiSQ45z8+KBeEkpGI5axaDFLzZmilBUDvalQ cGU58i/dTyQGA== Message-ID: <01e8445d033314b6d9cd67bece74ca1c3ce89945.camel@kernel.org> Subject: Re: [PATCH v2 34/47] nfsd: dynamically allocate the nfsd-client shrinker From: Jeff Layton To: Qi Zheng , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Chuck Lever Date: Mon, 24 Jul 2023 08:17:39 -0400 In-Reply-To: <20230724094354.90817-35-zhengqi.arch@bytedance.com> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-35-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 6hj38y1hfxsc6f1k44dsff75w6uu881x X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 57A18100025 X-HE-Tag: 1690201066-742653 X-HE-Meta: U2FsdGVkX18yGGOnWmnb0dMBJAM5kqvhdK73p5PNgLCIBxcNV81ZPhoOvOlq2yP5yzBUoTWhhVxnYISUyPZ0SDhxx5NdwebsSFfkhgzhmzkX3Ft3NqylAhMk67n5/RlX59CSjusMr/sLDpHoz2WebybpF1IaNTGn6EiKF2kebHaF9ZbWZtpKo5pM8tdMDBCBIUWUX+PE1gCFnTbK8XyK7X/Z4eLy21oOufgwWUELPcZM4QEwqSGdCt4S5lnYgMxtaFd6ECwjLCmqflI6a5RrbkDZu1Cg06GErgydKMgnw+iINvci8P5AiKuTgn5kLkjXKpwi5yI3fCekUDVqq/7YLXjfMnC09fUC+drKfsDr3YPZCHVWEvkGHJ+Hxq0w2j53PKuht0Ky4PgWhaR4zuc6p9tHYlX/IgchXoUlJt/WqgtHMi5BY8pIOaDCWqCMkbpDy8x3iDdzLHR9lCAFil4bLSveS5k3hJ7oAFEiox/M0shaAewmdEV7nMnNhn7VhmPuXjzR0l7btz2BFwyZUzI8SHqzpWRtr1KW7vJdC4n/uNHxfAodvSLJuuVZn6LUmTmkX5dCdenI1nNrVUyDz4W5edMRn8BNIbb4FsidG4tz4kZx4graKVyRS4T4mTShtoD2k3jUDwfDM1OIKtO5OvmDiSlx2rSB+5sXq29dtqAXZJt6Va7CbOFdQCqALYN3e37DtEaFwHfdxTt6X6sfFDHrZiVH82CbdQ2E1ipP8ssErzO3Vl3Wc0iL0Xu8vIfp9292vFmwLnShqh+RPyzaG9rJcg8NZxJ9G3ZxAyt0pe7NYh3e3R/A2xt5MzshYlmH+0i9MIXn/ogdx1CervaCkutsANQgQXzvqNWEkD4G63/CfHnTRHZX+r+OnXMicFiXLIoQsEJdbWTKHhMAWGAJHkoGltDtQWkZS2vwJ650g4d1IohsK0+WCAZpC53fAoQgvZRFiM9OGqJp3/tXlkClpOb tA0/iBw6 1n9Qp0keGCxryScfJ0g4lu0yYb6KDe3WwbfAtMrzk2K/9ilHO1KjWS71qlds7p0Ok6Rxyv7V4bMuao7Yi64HcOHHjamCu+CXPz3g60XjdqHENOuV/ueX8EoqCUXblxzvvcwSNrc3hz6NFNJ5j2nLSuUTIGPqBQV1EtIUcxtxDc6MWflFGYvFs/WfHXbNPX21lZWIxwTl02sfr8Ombl3pMMfOdInBAsN64tWhB0gzETUNG8ImuvsoLExFijZsqkVKZHOoLfz7+T8paEPLWbEk1msKklMAHXunjl4zSvcAuCpK4vm7S5twlxcTZWNBBnaEKMzt+OBjJaJ3f1hkuXh8hlF7pMKQS6se1s9oyHdkouwp+N4r1o61lr1Tx//rkDlZ2fBX2irnsZin1GirpIGQ2y48LODoQm2HdCI7vi1JYskt/LTVneFKNWRfNGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-07-24 at 17:43 +0800, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the nfsd-client shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct nfsd_net. >=20 > Acked-by: Chuck Lever > Signed-off-by: Qi Zheng > --- > fs/nfsd/netns.h | 2 +- > fs/nfsd/nfs4state.c | 20 ++++++++++++-------- > 2 files changed, 13 insertions(+), 9 deletions(-) >=20 > diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h > index ec49b200b797..f669444d5336 100644 > --- a/fs/nfsd/netns.h > +++ b/fs/nfsd/netns.h > @@ -195,7 +195,7 @@ struct nfsd_net { > int nfs4_max_clients; > =20 > atomic_t nfsd_courtesy_clients; > - struct shrinker nfsd_client_shrinker; > + struct shrinker *nfsd_client_shrinker; > struct work_struct nfsd_shrinker_work; > }; > =20 > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 3339177f8e2f..c7a4616cd866 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -4388,8 +4388,7 @@ static unsigned long > nfsd4_state_shrinker_count(struct shrinker *shrink, struct shrink_contro= l *sc) > { > int count; > - struct nfsd_net *nn =3D container_of(shrink, > - struct nfsd_net, nfsd_client_shrinker); > + struct nfsd_net *nn =3D shrink->private_data; > =20 > count =3D atomic_read(&nn->nfsd_courtesy_clients); > if (!count) > @@ -8125,12 +8124,17 @@ static int nfs4_state_create_net(struct net *net) > INIT_WORK(&nn->nfsd_shrinker_work, nfsd4_state_shrinker_worker); > get_net(net); > =20 > - nn->nfsd_client_shrinker.scan_objects =3D nfsd4_state_shrinker_scan; > - nn->nfsd_client_shrinker.count_objects =3D nfsd4_state_shrinker_count; > - nn->nfsd_client_shrinker.seeks =3D DEFAULT_SEEKS; > - > - if (register_shrinker(&nn->nfsd_client_shrinker, "nfsd-client")) > + nn->nfsd_client_shrinker =3D shrinker_alloc(0, "nfsd-client"); > + if (!nn->nfsd_client_shrinker) > goto err_shrinker; > + > + nn->nfsd_client_shrinker->scan_objects =3D nfsd4_state_shrinker_scan; > + nn->nfsd_client_shrinker->count_objects =3D nfsd4_state_shrinker_count; > + nn->nfsd_client_shrinker->seeks =3D DEFAULT_SEEKS; > + nn->nfsd_client_shrinker->private_data =3D nn; > + > + shrinker_register(nn->nfsd_client_shrinker); > + > return 0; > =20 > err_shrinker: > @@ -8228,7 +8232,7 @@ nfs4_state_shutdown_net(struct net *net) > struct list_head *pos, *next, reaplist; > struct nfsd_net *nn =3D net_generic(net, nfsd_net_id); > =20 > - unregister_shrinker(&nn->nfsd_client_shrinker); > + shrinker_unregister(nn->nfsd_client_shrinker); > cancel_work(&nn->nfsd_shrinker_work); > cancel_delayed_work_sync(&nn->laundromat_work); > locks_end_grace(&nn->nfsd4_manager); Acked-by: Jeff Layton