From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97958C71136 for ; Fri, 13 Jun 2025 13:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36C596B008C; Fri, 13 Jun 2025 09:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31D8E6B0092; Fri, 13 Jun 2025 09:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 233CE6B0095; Fri, 13 Jun 2025 09:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0517C6B008C for ; Fri, 13 Jun 2025 09:48:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 76990100EC9 for ; Fri, 13 Jun 2025 13:48:18 +0000 (UTC) X-FDA: 83550506676.28.A2A9222 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id C823A4000E for ; Fri, 13 Jun 2025 13:48:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IKg46gTY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749822496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FlpStz9Nu7mGd6bh3NaiGT/FtozOWPpuATqW9fvPa2E=; b=EiNTrHmVv0sOLi6l4UFRa6PjERLOYXYvBGvDMn1uKe+leoNErXHht/VdPi2BWage+V4QdB d4K7eHM3rmLo2nPhPc/Kue35cuKIn9Xs1tRF7oHvhov6dXOEWs+f7kIOgH4ZKbmmMixRUE 3foCFWjjE0NSbJ4FzgzAeI9+uts23KA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749822496; a=rsa-sha256; cv=none; b=MSQcIp7egLyxLtldDN8zI+SRZnx0u8gT/LsSV7ep+SxPWCK3NZ457geeKgytO0xGJRNZwu f9UOqBk21p+XGNn9PkDC+78kt1uWEeJQmIULGLPPTpMERYVwqvX2nLmMviM95rNWmnhlCz QMfmA8UF3a3l65Zi9wr0eBXUchA9h+c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IKg46gTY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749822495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FlpStz9Nu7mGd6bh3NaiGT/FtozOWPpuATqW9fvPa2E=; b=IKg46gTYvRX4fpkhF6A9eGicnbn1y+qUpY3phCgjX5s1sS726ITgT/7RS87drjlRsv36Gd 1w8DHSQcXpN8kq36cWqRl9C+9zmFgyldw/d+pvSlKV/F6oFWokX8qfa8yKRoR1meuYv1CM RRvyqoB6My6mDJLHFDemWuEN2cTz37s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-Gyo9fccMMD6U4_7kOvOovw-1; Fri, 13 Jun 2025 09:48:13 -0400 X-MC-Unique: Gyo9fccMMD6U4_7kOvOovw-1 X-Mimecast-MFC-AGG-ID: Gyo9fccMMD6U4_7kOvOovw_1749822492 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4ee113461so866141f8f.1 for ; Fri, 13 Jun 2025 06:48:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822492; x=1750427292; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FlpStz9Nu7mGd6bh3NaiGT/FtozOWPpuATqW9fvPa2E=; b=LhWKf7e1pdNIFA5/ZzooSWc7j4GgV7WGYQkI5mEOzcbvJBO5qYfLFTugJvuHevKKz0 qXx7vsnr+oDvsJFiTlQkw0GIX/+ps/c320Qgw5Y5PzXxMtEwx3Y2oU18pIE/orE86cGe Ir5yoxRJ7r5JwOj0eafxaN6pWpQ5qFaAfmoKeSG7klyGg1eg0EHjuaNMywpwo9EM+Y9H TR8lXQqMEgyA929g7AJNOT/mt8Y0vyqrqi0v6advY72LN3+FTTUS4ZmTgGgrKfU2UmeO 0W2Xzh+OSadrHh4VwoTNtbxp4mHz/UlUfbCABt6reaIo1twf6a+xUxpOnT2T0qjYktez 1URg== X-Forwarded-Encrypted: i=1; AJvYcCWPirg0tGT60GSYkJEmoqrVuJg6eXBTNsez5q5ajVS+ZbCEpXZoe7zCnvqsrQRCXAs5jDVPFZ0OHA==@kvack.org X-Gm-Message-State: AOJu0YzGZVtqSlJCGVpy++RPSl867MtVcKhFLlNkV7GSu5b8OHgpyIA+ XSaDeRqBKlYJEVALe7MRpUfoQhNCSKaWXiteXIUWk4xQ5GTBc39fkci4I+0t0HsDjPm9q0m7Vw9 Ih0a9xECgTp4z84xKx3P+66GVT3a6oGXKUd+JNBUFo3jmPvvKQ+R7 X-Gm-Gg: ASbGncuuAmTQpx5B3huQ9vXbqmgHlXLKlgLXwdMngZ4qyUtJ2JLtWc8qYQziPne65Lx YyxVtsgKOFglLVdP/e3Tzw7fhfUKnfD76e0t0jRi0YrdBCDVqku/rB5E7i+xYkUK0Xl9XYXipW8 c49gpxPGhyxLDvDlYZLkp8DqxUskWvqAFmHqaXR251sakXmh8mn8DUbzo9vr4rZkHhMs1DRH7aV g5dx2r9Q+M2MmISRoT1KrGpZ4iElEZ4iEXibwEOyEJ6HxpBF9lpKEzMUOOmFD/SI92QQ0zrNJvM g5SknDXgpGCiSqhbET4idBT0eXBKWUS1ZOhM6fj2sjFoFjeFSPTmLGGy7g3Kqj+2ncSHFDA0unp JsNg3K9IQm+U9kP07VnvI8ST/UQmgBX5wafZNhVUmzkBjsNLm9A== X-Received: by 2002:a5d:5850:0:b0:3a4:f902:3872 with SMTP id ffacd0b85a97d-3a568670cdfmr2821173f8f.19.1749822492517; Fri, 13 Jun 2025 06:48:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFTnixNMJ19dkd58TRRn/1gXW0L9xoxbp5v9Jh6vXM5f9pE1YKSwySO7tZwzmqh4vxHpG8xQ== X-Received: by 2002:a5d:5850:0:b0:3a4:f902:3872 with SMTP id ffacd0b85a97d-3a568670cdfmr2821144f8f.19.1749822492155; Fri, 13 Jun 2025 06:48:12 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b087a9sm2465743f8f.55.2025.06.13.06.48.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 06:48:11 -0700 (PDT) Message-ID: <01f0f47e-1992-4991-b11d-c3d51b470da0@redhat.com> Date: Fri, 13 Jun 2025 15:48:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] mm,hugetlb: Conver anon_rmap into boolean To: Oscar Salvador , Andrew Morton Cc: Muchun Song , James Houghton , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250612134701.377855-1-osalvador@suse.de> <20250612134701.377855-4-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250612134701.377855-4-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1BYYq2TlXXYqBYXOvjVtfPyibF_dYxxzarFJFI4WPX8_1749822492 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: airm9rfhp4oyuc6wgefa6ifftdscf3pe X-Rspamd-Queue-Id: C823A4000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749822495-846618 X-HE-Meta: U2FsdGVkX1/3I6A3iTU52YnUfL5BKsVtoQzVY1CFQmLhu87Ysn9UOjYkF5hAjTT4ojdXmyxk58yc1rOEJqkdv5kcEVAonWfuG+DQVoo2htpNSkZMZcj0KQd3m2Q/YqcIOzfI09Rgaa7Cqyyvm77wQfqVG/kD4Km5eSVs+EZ0nKVkB6W9eTm3GAuGVdUAbYSH38i0aOL0kzO74Fuks/iqYsh+R1bBAURSjhLUXS0bM3UzKSH2JaUB0SSsPYOZK9C7xMme42uvdDR0nuoIAceqdJL56vLFgoqhaTyi1rvYEASKoiJseboVige0+28LYpd/ghn0JBTyk+BEYOkyAOS/DoGlWZn0bULck8N76mTOwA9lK5XWwtly+qkl5AEEX4+6WcHs1uN4RzswBO6MXvyzW+eTDeLqvg63oaG8AtNY34XiWUx0mzLgdGPAUlfvE3gCQGPir5FquU6x2phSCT5R30FneRO4zpVTc4mJduTRuRWQJnGLoAqeZf+xJc8foShYJ4V5wl2tRRr2szc9zU5aYSlD6VP9qJ6KCb1+Gp0QwJguPfPDISTROIgKgWnvwG+4oAenWe4nftx68nbS3WYx7iuls62m3TwZNNGIOHjnI3V2dgzjCCeiwyilqj3eJdvB9yZySt4oysIWOZHDae611TWokQoECjDAtWLvBmCcYnuhRcwR/E83LDeT+OhTQ/92Uew1FMdamzboqM1yuFNTY0d3zXohcIZdc9dCFeleS1uK1ySna2xrBXnc1oZQ4rp129+VqCgQbNOPAGxN/lX897ZYrSLDEJ8qUty2ulDl40TrSo7/0SaOy/BEAzDQp91MMOgkck305jS4+H3REDi+qb5LA3+mQNMgPGavptbvAoKW8M1Xp9SdLw+l+zz67c2gk/uw7RmSFIqqkcjWcB9ghvRQRPY0CKnOkGZDtN2Ux4zWyrYAF84C1Higekm5AMhBBNczbR93nYo1jcYm0f1 8gmyFZJf pwvQyYwkGuufhY2paWo4V4Q0LMl2jOv2R1zeVOL0NVw8uldzen7YergYQDt6hdpaa+xbqAauJVQc+eXzOsaiubmDPbobV88nlif0QauSDd5XMCVKE3Vy9sIETVJAcx2Jj8xxdFFPDJCOVru67fGlAqvV6qmk0a51kJTL6vUxkGWkoJREtl7IdkUvB3thMr2pCZsM7gkEGp7iPXRZ3fPY7fDNq6rfuqmIuBpoKdu8BufIOf2SrMxrxrRV2uqT9HV7XvyxpaamcL0NS5S+LIOMX/ne4eOy8W0ovvNjh/Mhen44kYsIsnBPBWHALJa7aY54YucooBG34eLfiPThEuhQHr09KzrQm6W7q1WwOEjR7SUZBPdlXHxyOi8PFKImAZ8Wutkmmnd8nEzzeII9U5w0uBib1tBEbtjC9XL7dQpeJdfZXF8N6CWOlWC+8wCxNJCjdKjIhR+jn4d2ncumHj7xDpqrYtx2LMdS4tx9b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 15:46, Oscar Salvador wrote: > We use anon_rmap as a boolean, so declare it as that. > > Signed-off-by: Oscar Salvador > --- > mm/hugetlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index dfa09fc3b2c6..62bc3808f99e 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6431,7 +6431,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, > struct mm_struct *mm = vma->vm_mm; > struct hstate *h = hstate_vma(vma); > vm_fault_t ret = VM_FAULT_SIGBUS; > - int anon_rmap = 0; > + bool anon_rmap = false; > unsigned long size; > struct folio *folio; > pte_t new_pte; > @@ -6542,7 +6542,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping, > * check whether we can re-use this page exclusively for us. > */ > folio_lock(folio); > - anon_rmap = 1; > + anon_rmap = true; > } > } else { > /* While at it, I would rename that to "new_anon_folio" or sth like that. It's used to distinguish whether we create an anon or a file folio. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb