From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61603D374A2 for ; Thu, 17 Oct 2024 14:37:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F280B6B0082; Thu, 17 Oct 2024 10:36:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED7B96B0089; Thu, 17 Oct 2024 10:36:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D51F16B0095; Thu, 17 Oct 2024 10:36:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3B746B0082 for ; Thu, 17 Oct 2024 10:36:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9B3E8C123D for ; Thu, 17 Oct 2024 14:36:47 +0000 (UTC) X-FDA: 82683345948.11.5E96048 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E908C1C0024 for ; Thu, 17 Oct 2024 14:36:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YYO0ZkzM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729175671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UzfXLoTrDUyX1VJYFE3FTnLV0X70G74YSwU8euehzao=; b=cAglJR+SvPfR8+X7cbst87CayutIe4Zeayi8N840GodlYy2fphZfsZ7OlpmrpHEWo3qJGR x+zSQ87GZf3GdNJlHhcMNlBM+C9KOeIeBmrrqDYvyWoUhw6ZyCOdpJ+Kw5aAkqY34zqVnz +szNtQ/vpquT7DoFyXrPoNJYORpL0og= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729175671; a=rsa-sha256; cv=none; b=C8+y8WLW5uDhJUPMGtmhoXy0bvHadJrouFr0oV/E8V0sMEypaBsDUwuXHx+fVMBLf6QmSC gN+iFAJCad/CbCVj4LA61H/lIIexswox+zY0k1mNZUGewuCEAvVNLxskthu7RwVBEuNgyb GlECRPRzO7CRRcE3D0BkDtiYDqU7sgM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YYO0ZkzM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729175816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UzfXLoTrDUyX1VJYFE3FTnLV0X70G74YSwU8euehzao=; b=YYO0ZkzMlbGZhSuJ1Ojp1KELzju8ZA7i+NcCsjf/YxHiSvYQH6vh1WqvfcCaXoqYsl6sOz zAOKKlOLCC3sZiVlJqigXqh58Rvpk8cG+K1tTZxJWLxvbAhxvX06szDZGbyXgzDdQi9Ste Bm7pH7bFHk2UAMwqhhOlM4ZWDvx/IrE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-nEeFHt_KMVm4hOhAKjzVqg-1; Thu, 17 Oct 2024 10:36:55 -0400 X-MC-Unique: nEeFHt_KMVm4hOhAKjzVqg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43124676f8aso8393855e9.0 for ; Thu, 17 Oct 2024 07:36:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729175814; x=1729780614; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UzfXLoTrDUyX1VJYFE3FTnLV0X70G74YSwU8euehzao=; b=IDD0mgIOU5FFnqUOXPQTxQYLso6nKc5oJmJRlMSSZDJGT03YKUQ+xS4bHgGvC07txn ykLaT7C8rHJN93uPgei97F4Ct70O7ucSZNAMiw7xB+nte0N8aEFE3LK8KaCmXkqWxQQ4 aHMj/GrWLm4GSqc4NysMKypvE0RzyRELlE7FF35zmcMJiAZOZfLfRyrOYJZaywF6WgXJ iWeYVZPNqhUJsOreySn12RxnFHkvXUKljFul+1hyZmee01TWgsKZ/wDnahDgHs6IehU8 PnRjPH3qVehYbjh2stxSAcDfPb5N8V6JSH8vkSa3b2+6uD8Gk2lPxdUscLkzhYxB4EO2 pLJg== X-Forwarded-Encrypted: i=1; AJvYcCWFJsKiN75rWrB2+xQaFyFeqrxmcPjWrA9hqrnjRvDRe5X08/BnJXPbnmsG6MCUc1lTd/7TnmCHog==@kvack.org X-Gm-Message-State: AOJu0YxcEfkxkf5du6VeYVlK/C7S5KD+7FRYWvNVNnEr0QkiZKKNIUQe 0vLM+pv1on4wfpi5jaJZ/Z71gg8k30HsryJEMvBl0wsqgUoid6NqOinB1lXW5rCpky/ZHqB9Eoh 7ZXNq8q12rnetD8Nn1mgbnP94GQGnbhk7iXygB5Scy46sQJYwBq2GMFsbsAE= X-Received: by 2002:a05:600c:3b99:b0:426:647b:1bfc with SMTP id 5b1f17b1804b1-4314a3abe93mr69661365e9.30.1729175814111; Thu, 17 Oct 2024 07:36:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHpU9cpWS3yeJ12WQ1qdRFSatXmwxIJA5brFMmY8AiQ4Fgny5eENTh1y2xj5WODUe0A3g91w== X-Received: by 2002:a05:600c:3b99:b0:426:647b:1bfc with SMTP id 5b1f17b1804b1-4314a3abe93mr69661145e9.30.1729175813692; Thu, 17 Oct 2024 07:36:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4314f1c3197sm42435665e9.0.2024.10.17.07.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 07:36:53 -0700 (PDT) Message-ID: <0224bd06-3a77-474e-917d-814d2082186e@redhat.com> Date: Thu, 17 Oct 2024 16:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-5-david@redhat.com> <04d5169f-3289-4aac-abca-90b20ad4e9c9@redhat.com> <1c7ef09e-9ba2-488e-a249-4db3f65e077d@redhat.com> <45de474c-9af3-4d71-959f-6dbc223b432b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E908C1C0024 X-Stat-Signature: zy5ruzhqkyd6nixwy4oc8617qu5uzkph X-HE-Tag: 1729175812-35599 X-HE-Meta: U2FsdGVkX1/cf0XYuAEGN9Q0KmhE0zpDn8EHrQAPlzrJgsdRZ4LkpEgdHWhj9Mu4UrjqVBVh08aesSS9OSubGobmYU45wBL9lR5I1LfB93MLhFBszgGmsW6jyQ9GyRXbb/l7u4t2A2s7FZEkrpogIFDhv4U05BUB2L0WEXHcjBQlcEX0hyaerF721UTyvWIg1IFynrhOSvxe7dxAanbG7W3ldu4N1y8BbSJuAYycEnDy8cIMLFkRuK6v7o3JejMHSuyXNdwQENmsNkZkCH1qLv2KtDro1kuYPaZY7/Yx0joP2VYsCFuHQN9y4fhwV5vdWpwYVI4gieD/dFivj7zgnfpRZl4ppGlmzPFbjd1odd7+NiPrsoxJ5ElmFT3IqCcQiyHmugGbuDRWgVa4RBpNIQ52+IbveCqkOPoocRZEATnj8rHhIUz2av07umSPp+oABmYh9pFvUkTnSP6nsLj6rSyLbRv5dmrSEZT5/u532ZBWzR0PRLal4oa9/YT+LbyBpjpggHiTyUqjAPX8BWcaysYIWcFotfep4MMSDvuYL2HEBoWmJN2EL9LVHnuhV58IX0KPSCupEUhLNyLJ+R6lvA4VQwHQyutXoklVaAq5V7L8GlBkuCX2yEWqsY3K5wcNPQQYom0wEw00ioz4Ov9dBjY6T69ft1bmMsbztRngsVj3ZbUbHiMvHXFQXc225ytdva1/U5h31sj7Q0xKjvG4Yo+N5SWG76TTgqk5OxWhtTebWt1q8C1W+0zw8+ym+xLxUFZ4wEnDuO8xd0bTiZ2aSQSkTIdtG0ff+E5k/emlcUGg0x/uQLNzscvNtJ1qzoBd1oFDOg//CFs9pilBeQCsie++U7+4ZTkcEijDxU2hlzFyYWxldeg8c3uouioGSeEsFN3bl0Fs1iOdqgk33o8BxjpIoy0mRFTB3OFGUDKsib2bIMCJ5vSJuyT1Dlx4fVLg2hfj3114rtx/R1DIXRA k6TuwMAx OCeE3B6UxJPQYwsuiDKYKB/xEjD2cXkLFdGiXkMBZ8DDgqu5yyh5+3Khdu2zuhr3Nu3XurEeAiHBVSODmpYn9nyFGEOxWc0BZoUuhHkV6B7r/k8inrpajeNo7yHMciuPXZLiR9SnDXDSkJzIYPw38iiWzWzPAk4jnIzAzo91GAAXYQRfutQ1tDfFVXgT6ThwOfNgyDrdB1nlck9Fx5m+l99/TmjGucVLbTc4bKIo9capC6C+0Lm0bOZERn3Xfu64mLKghjobdZskM+71ROsU2ijaLSau4RYwPYyyaNoOjYON3d2zLZruse2gLjUb87oB/xoqEnq4YDnq2Xt+9cfcK0S+CbyVImmrd+/6eSAP1XLqFVHPLH38bu3fipmCicPvZNQVMa8RQUo9sK8os7Ju0Zbgtn21fy6kAbGp1P+BhilXAqIDpZTCiKJJm+eWPbCUyJcDk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 16:32, Alexander Gordeev wrote: > On Thu, Oct 17, 2024 at 02:07:12PM +0200, David Hildenbrand wrote: >> On 17.10.24 12:00, David Hildenbrand wrote: >>> Well, DIAGNOSE 260 is z/VM only and DIAG 500 is KVM only. So there are >>> currently not really any other reasonable ways besides SCLP. >> >> Correction: Staring at the code again, in detect_physmem_online_ranges() >> we will indeed try: >> >> a) sclp_early_read_storage_info() >> b) diag260() > > So why care to call diag260() in case of DIAGNOSE 500? What about the below? > > void detect_physmem_online_ranges(unsigned long max_physmem_end) > { > if (!sclp_early_read_storage_info()) { > physmem_info.info_source = MEM_DETECT_SCLP_STOR_INFO; > } else if (physmem_info.info_source == MEM_DETECT_DIAG500_STOR_LIMIT) { > unsigned long online_end; > > if (!sclp_early_get_memsize(&online_end)) { > physmem_info.info_source = MEM_DETECT_SCLP_READ_INFO; > add_physmem_online_range(0, online_end); > } > } else if (!diag260()) { > physmem_info.info_source = MEM_DETECT_DIAG260; > } else if (max_physmem_end) { > add_physmem_online_range(0, max_physmem_end); > } > } Works for me, thanks! -- Cheers, David / dhildenb