From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC011C05027 for ; Mon, 23 Jan 2023 10:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67FBA6B0073; Mon, 23 Jan 2023 05:43:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 630156B0074; Mon, 23 Jan 2023 05:43:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D19A6B0075; Mon, 23 Jan 2023 05:43:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3F6FB6B0073 for ; Mon, 23 Jan 2023 05:43:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0E5D9C036A for ; Mon, 23 Jan 2023 10:43:38 +0000 (UTC) X-FDA: 80385727716.14.5EC80C9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id EA01940011 for ; Mon, 23 Jan 2023 10:43:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U5s3kYAb; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674470616; a=rsa-sha256; cv=none; b=19g5uFletvgnGTKJvfy++cScu3YtxaojeckCS14+xksNZ//lLEBKQmvkL2CPGY+95jkD+D dIGgeFpUFeiIjPpELLYUKBeH3oq7N4kNC77HIBC5t+lpFryet0e8aXH9nGOAG/3RklpJ3d Azg+JySHt/I+rTsuYH48yeCoB4mpcig= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U5s3kYAb; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674470616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3S/hxP8bYZ34/3gqxEk5MUbZrc/WTJVLxhNd9rhpOcU=; b=q2SeOChQphr5wVYQ0EAim8mDQeQkX7GP6z8Uefylj7HgT567Va6pi/Uhhm29IPSZcGcVVw OJLrQ3NyZQNcg6ZNnbhYv9ZjaEiIxRAmlLm7MGpwjT6nr4iKI/PrjWgna5FRyPaKo1PD+g zM+3h0MMDPyPIfv/SE6q1irbI2n9Qjg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674470615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3S/hxP8bYZ34/3gqxEk5MUbZrc/WTJVLxhNd9rhpOcU=; b=U5s3kYAbjESCGuw28oKyQMNiukk5XVC/Jo3yyF4eWRjWE8/kWWEoWhofdnYQt4cmvBJgB2 XRNm7FzjefpTDR78iqN/1/blyBjtyFsZ36/VG0A5wBeDzM6bpIwsR8El7G7ZKr0fIU9fIi vgjnrb13ofW35aooAo5abCGijfRNFSI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648--fYTyeR-MD21D454WZCx6g-1; Mon, 23 Jan 2023 05:43:33 -0500 X-MC-Unique: -fYTyeR-MD21D454WZCx6g-1 Received: by mail-wm1-f69.google.com with SMTP id m7-20020a05600c4f4700b003d971a5e770so7304965wmq.3 for ; Mon, 23 Jan 2023 02:43:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3S/hxP8bYZ34/3gqxEk5MUbZrc/WTJVLxhNd9rhpOcU=; b=72nxtedHSoIw8gJ/dogz0kY+NilCOwJtO1opUV2RWcv+8iHO+QC2VBcmqyl2Gs+h5A Y/mf+BUGz29MYY1nYrGMO/w4coi1TjvRymWQBXucvmP50D2cimy7D4bupadGk3s+3GD/ kZLLoWZQ3tAfiYVPzNvY+As9FeWIDjlqkmfCC4pGwuyJwIVIHpSSAmWm3rLQZVkOLOxt VO35ETdefUTqueJardeRYY5oR4gQTyZoYc5lmvvpB3kjfHXQR0RV8HTKczQe3YaQUB/p jVrnNltO/YQ6HIe4x8vMlYkfuQ6x5OrOo8qE8EqswBSGtbvedkSkq24lgIWfa5j59rzp iaqQ== X-Gm-Message-State: AFqh2kr/rkd1T5A3KfQ1j6V9IW37Oq1ob5sI+KS84LuEgo6c1fqoEm7y R9i4gp5BbiYtKRJVrH0c0pNM4DWFobwYsZgPV0GFP80A5o8cmdjVQjCGyTGgjdyoygbvoQf76Xw VYgXLoagTELI= X-Received: by 2002:a05:600c:1695:b0:3d3:4ae6:a71b with SMTP id k21-20020a05600c169500b003d34ae6a71bmr22540955wmn.2.1674470612617; Mon, 23 Jan 2023 02:43:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpACNafkMIq3tlcSAgDrMm4KNWVFK1ZqRAd5zmXogEFUKxsihzOS3rLfsoNxwht+HKX2XAeQ== X-Received: by 2002:a05:600c:1695:b0:3d3:4ae6:a71b with SMTP id k21-20020a05600c169500b003d34ae6a71bmr22540937wmn.2.1674470612385; Mon, 23 Jan 2023 02:43:32 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1100:65a0:c03a:142a:f914? (p200300cbc704110065a0c03a142af914.dip0.t-ipconnect.de. [2003:cb:c704:1100:65a0:c03a:142a:f914]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c021100b003dafb0c8dfbsm11777199wmi.14.2023.01.23.02.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 02:43:31 -0800 (PST) Message-ID: <02bc3d67-3457-ff17-0810-e75555609873@redhat.com> Date: Mon, 23 Jan 2023 11:43:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 08/10] mm: move debug checks from __vunmap to remove_vm_area To: Christoph Hellwig , Andrew Morton , Uladzislau Rezki Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org References: <20230121071051.1143058-1-hch@lst.de> <20230121071051.1143058-9-hch@lst.de> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230121071051.1143058-9-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: EA01940011 X-Rspamd-Server: rspam01 X-Stat-Signature: hk4qz56noc1e13j3jzntfx3q48dpjb6z X-HE-Tag: 1674470615-446426 X-HE-Meta: U2FsdGVkX19l9+yBZ24KWkhxb+ylTVUk8MdP10xRlXBVmuwezTE3zguqbe2F5THIUKUImPz58ZOLhUEr7plJoFPZUD0vnmLXsbFLpd3256N5QGcgv0hOklKPcvYdo13XxF4i536/PLemMoeQTYy0A8R4mKlaBHPkghotyLvC1McPKq2xUC/dBXVHbMUtFS39fWZlNJ+R0RB2PbwtSGPBgx/0ja0DrzQyoPkwMsvsB0ZYXbevm0hB9lMqBo6T5WG4ITk6pDA/sFhBOkEQsM1D+zXuf/LNdugZU9Ga2K5uNrh697jF+rpDHYEtEHZWD9AroL2s99DN9Jz90z79aBx9TCT8d4WdEolbDvGvTvxJLSm+qzNryFdBo5EUIv7FFCJ97Kr9PuSOSBA8MxzfRTDuDO7JqZGeOZOeMGNtJVgS2In0+IaNTw77E8oOOEmfGQyXiWWP/ryyc1clH13q2SBwGY6y7YkoSjxwsyYxh/iXZpcSU2UnGm/n/KzKDNIHCVnhJxTQkUSEpaA/C5jnMb0LLxqC8HodyqnNs6uSthGfoeXL65qAte/vIIUqtZhN+Q1IYwyvvT5Z58H98Ngs6uet3xDcP0Z1RK9sLCoE56HLRJ5BG510/pe0OQPXp4oEoyZNTKzAnB/i/W9/opMzZMwEmrUzv5tn6RA7E6RMjb3drZt9qHDqpzmYghwn15BLHSjZdbX8ygoKAVgcDXx+Mki4cE+tnoa6dj4R3B4cqEGMch3pv8nRI8JSkOdaads+EaaOXcbYLQKjKCbNfMe7dJvrj9S+anOpH4nti2ObHS3UXZZ0NRc1DVMYdUO6qAL5LGK5nP4F317jnt0vi9ilY6ifbXrGrvE8LF+aKcAQrMtnWwfHt8LsPZFNtrFKuOWgT0Dsmw8Kv1KCZejjPpSul8zFJN1S1CWAl+VBJYMqfBxzaQaAYOowzZ4Rk8atoDrSMcYBU5iEalygBmdqOEelvIZ CPRyafYT vnBGDyv9IBY64UqfI6HXiqVdTSJ6mBJEik7l4agh1c8n0312MXa+43cofiluxY1+hvnhrefdi87Mb1UaQocDGzYFlyaDOPAU/tGeqiBQ9l9Cz/UDKj5DEH/Gq/ElmLiixPQT0YJfExGEh+urOt2b6nMhgWmIRdvmp+7g68kOGauClWzL7j4YjKLAQ9Q5H1b8ioAqqgI2wtqhYtxQiO3PHKNJhJ5ewiGiMNgBUvqbv9yKHa+wC9CaYf5prOXAn4EF8kxE+L62loyjBKWIXfiwbc6Wl0ZyT5AlQXqfx6OJwP5bl/FA6bjmonp68u2L6flqyAIG0qD7qM0CpfHqSLiueIFNLf5ZQlgVpunpP2jIzKqSyXc1M6qe7LRQYAt9I+y2eS/bzULQhpMSafxFe+Pk3KZWH9a1XFusCF7uIu5RiPp1wAatemAEmREPihlObptwy7bdYV9iarqX7PjTcjlxU/dI2pp+GH9BWfXiknicwL6qX8uFKDh+JhIRn6wgrYdQcry/EPyJVeA+BX2ajlPvYja7Mbl2feH8E3XfvpgjD6FoImk0xOatxFz4swA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.01.23 08:10, Christoph Hellwig wrote: > All these checks apply to the free_vm_area interface as well, so move > them to the common routine. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 97156eab6fe581..5b432508319a4f 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2588,11 +2588,20 @@ struct vm_struct *remove_vm_area(const void *addr) > > might_sleep(); > > + if (WARN(!PAGE_ALIGNED(addr), "Trying to vfree() bad address (%p)\n", > + addr)) > + return NULL; While at it, might want to use WARN_ONCE() instead. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb