From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F4BC5B543 for ; Thu, 5 Jun 2025 14:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0854B6B0149; Thu, 5 Jun 2025 10:27:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 035F86B014A; Thu, 5 Jun 2025 10:27:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E66A76B014B; Thu, 5 Jun 2025 10:27:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C7E6E6B0149 for ; Thu, 5 Jun 2025 10:27:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 72A905D29E for ; Thu, 5 Jun 2025 14:27:12 +0000 (UTC) X-FDA: 83521574304.07.85B5940 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id A0DD81A0005 for ; Thu, 5 Jun 2025 14:27:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NBSUi9TZ; spf=pass (imf19.hostedemail.com: domain of jirislaby@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749133630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mp9z4kv2cjeuySdA4rlb75ja+ymQC8xNsMOyzDJ647E=; b=oGAzd1v7MnEoInONXPM2tTTvjIeqH0V9QWy76oc0ZOJSaVo1G3a/Nla05w4xLuFjKZmnYO 9SuSI76S25WFaGYZuzQuTyJ5eL0ly49hBcvuK+K4BzmgreApUlnJT3ZAIjDCYHM0lbLjdY a1qc15TNAEWSk0K8P56l1LUDBNr1bTk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749133630; a=rsa-sha256; cv=none; b=8pXS3mlv51L9t102ISVzyjuhq5ZRzB/ClB8uQIvOlIvrvKbIDP1xBZINZbFB0ZMdvNHK4S KPsOkuiX2NodYoYKHuDpxMPWgw16geiJhuer/LXX2wawi5jMMe+GwzB65bsYoVNUYBteng AyXm24oUAsyzHt3X/q4OsMhkqGMkHBg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NBSUi9TZ; spf=pass (imf19.hostedemail.com: domain of jirislaby@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jirislaby@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C1FB95C6825; Thu, 5 Jun 2025 14:24:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28EBCC4CEE7; Thu, 5 Jun 2025 14:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749133629; bh=OqihrxSS4GkRLJ/+zmwRzLqFFD7y9+7mna+63hB3CtI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NBSUi9TZN2up+vkvBNbcTWzcHjsUiDsqAPf2AouOJIZP+TIWpHsGVpWs+Ux+7sM8T vyp4wfOBr9jMRoh8Oh78l/+o+1DqDPhRHaEMUblKdlmX/bZL5nB2BapOJcfdCvOVXR PhZCzYOcx4OsEEFlH7SYYq1quLd+wBosFyyjMfjc03x75eLUr61TIX65cn6MDa/uGU bc/z1heVwFAz9LM2UcIZatvxZZkcsgcqUee8eb5twVhBWJDwlaItoVkkkyOSKjNnYT Y4H5mJFdPaEK482do+KagBqulvRUPKAVy8++hYtTlBWczHvBrIiydDvkIjjbPGLTAZ rhU7a2aoHtkww== Message-ID: <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> Date: Thu, 5 Jun 2025 16:27:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Uros Bizjak , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org Cc: Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250127160709.80604-7-ubizjak@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A0DD81A0005 X-Stat-Signature: bjwfx3nnzintm5zxm7rty6w31syj4u4x X-Rspam-User: X-HE-Tag: 1749133630-965718 X-HE-Meta: U2FsdGVkX1/kOjSeq25ibz/cC1jN3vEtbVsUuTULItkAg6xYcNkpSqR2np3naQbQrMBBqwKUrdBTaciHQThsX3UExWVihpIVxoXC6n2gMg/qaRjhkGpzG99HaW6e9fks6XJUQfbhdWhRLRGgqOetE/c3mqFhGGl3GQF3FzS/9Pkhuzd1v4eOGAf1u892Wf0Pb762jKaMeBVIgy1tDkbFNQQxPz++6ios9ZAFn7k24AQQ2wLkeNI8RIw2rkhORAju6IJNB8ttzy3T9b0m3XYkQflHerdoA0zo11NfnKE3dDL8sre1R+DWigAK3F6Y330PjX+I8z64NjOjpS+oqd33/TeqrqfwB1HMV7Pwfw6SXM5Z/0m1sOUpLjW78b7sj+rgzMyGLUj5sBMfptxCKMJiohHJ+HAZuTOljG2rTzf25U9LVBR9PvALPY+/kfKEm8WQp9E6Yz7Y925Pcy/ufWHBVVY/WcDiW1HLYN7Yd7JnSXce3w41a8YRjetf6W253g2BjclBLlT+J3S9CY1xTqX0NbiyEoyYA6Dtc1/4sXDNoPmJ/qMeFAT2vzXsJsrEXhjlakfpL6U88QKime6zO85yT290DX6Zn71k3k5u5mG6oV2pHbkek3CKeTpgXyreZnJkNkTPj9r/uQZV2LsysRUAWFI2aDkXokF5C4HuPee747+1uXGPy+qY7dYC2W7Hdf4uNkmAtf2JcRSgRR8CZG6sr5BGki766HYAfDtgV7t5FHH0GWBi+xULYHAe74F/CGmUmtmtvM2KBv9pL5qkKWl91bR5parK+jBvYzpftNuwZ1l5r4GnI8BSCxbHAIO/qUr27Bup+52VtVHQFT3t1p8ofJtDeBnoljqCvp/SC9zANfQkTnr+GShmKS9/QEH6xmtqES00BlVjJqJtJK8Al5pKIOt0MXal7BYv3Zmw5gRLUTbqRuGDNOCc30irTlTP8//vllUL+wYpHSK6xvHtFnM 2niPweNG Wm1xMT/Ew3cT02EUoYNFqpPv0T8tMhkD4SB3RvlA/XrFccsudpspzelG1WNjkt6Nygjttm+L8SDD4ozfBfAj+ZIPIMFdciNdXpn4HlqI8EZFL730tG4nM/8C1Qb1WB7r/s0YTa2xEqiywu4rjsORa1GynPAiB7h/1tA/MS62n+1T3duHucIR5cpV7HhjMW5RRPOpt/aME0mksoLYABpNQot+e74NURmgDtqoAbNPHYtLOVTGTshLcZdjdFoI1AHInbPjolYdmjVTvJa5qU8uJNye8dupusmDVjQmAkn0GVa2RPf2+alse8rxBVhkY0bdTde8WJsh4Evi0yM62kVXoP2DesTSD7BoIKP5KdFaOgjI83eWYZ7IzX5g5uOCd/crXzj7bDZW9Ppc7mDbRHQqlmjbnjXdQmHSQHqKXbYVm2LRx+ZkgoEx7lS0Gv148q1LhAWQnp6Ub5SIr/Ei7ytRV7dMaRGrJH+NZP0dhjOep10bFvFMlGN+nbf17y1quNtd6osPq4kGDhw3z3A4Lg4W4wBZPuD/R9x5qISxvG0cPdrwfrNQlZ8dm4fPoaD+tL0H6PG+ZVTSfIx8JKpknIIdeT4hR4jt/ySce23AVdseYRsWvraPtB5pU9P5Lf0/4UKLow9hxzpHpzABnocaUa9j1/pk3Rd7Fh+wCP89xRGB5K5gvzLhMmYgJMLt8wigQICP+e00u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27. 01. 25, 17:05, Uros Bizjak wrote: > This patch declares percpu variables in __seg_gs/__seg_fs named AS > and keeps them named AS qualified until they are dereferenced with > percpu accessor. This approach enables various compiler check > for cross-namespace variable assignments. > > Signed-off-by: Uros Bizjak > Acked-by: Nadav Amit > Cc: Dennis Zhou > Cc: Tejun Heo > Cc: Christoph Lameter > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "H. Peter Anvin" > Cc: Linus Torvalds > Cc: Andy Lutomirski > Cc: Brian Gerst > Cc: Peter Zijlstra > --- > arch/x86/include/asm/percpu.h | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h > index 27f668660abe..474d648bca9a 100644 > --- a/arch/x86/include/asm/percpu.h > +++ b/arch/x86/include/asm/percpu.h > @@ -95,9 +95,18 @@ > > #endif /* CONFIG_SMP */ > > -#define __my_cpu_type(var) typeof(var) __percpu_seg_override > -#define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr) > -#define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > +#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL) > +# define __my_cpu_type(var) typeof(var) > +# define __my_cpu_ptr(ptr) (ptr) > +# define __my_cpu_var(var) (var) > + > +# define __percpu_qual __percpu_seg_override > +#else > +# define __my_cpu_type(var) typeof(var) __percpu_seg_override > +# define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr) > +# define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > +#endif > + Another issue with this is this causes all modules in 6.15 are 2-4 times (compressed size) bigger: $ ll /usr/lib/modules/*-[0-9]-default/kernel/drivers/atm/atmtcp.ko.zst > -rw-r--r--. 1 root root 10325 May 13 11:49 /usr/lib/modules/6.14.6-2-default/kernel/drivers/atm/atmtcp.ko.zst > -rw-r--r--. 1 root root 39677 Jun 2 09:13 /usr/lib/modules/6.15.0-1-default/kernel/drivers/atm/atmtcp.ko.zst It's due to larger .BTF section: .BTF PROGBITS 0000000000000000 [-00003080-] [- 00000000000011a8-] {+00003100+} {+ 0000000000012cf8+} 0000000000000000 0 0 1 There are a lot of new BTF types defined in each module like: +attribute_group STRUCT +backing_dev_info STRUCT +bdi_writeback STRUCT +bin_attribute STRUCT +bio_end_io_t TYPEDEF +bio_list STRUCT +bio_set STRUCT +bio STRUCT +bio_vec STRUCT Reverting this gives me back to normal sizes. Any ideas? FTR downstream report: https://bugzilla.suse.com/show_bug.cgi?id=1244135 thanks, -- js suse labs